[INFO] fetching crate bagr 0.3.0... [INFO] checking bagr-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bagr 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bagr 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bagr 0.3.0 [INFO] finished tweaking crates.io crate bagr 0.3.0 [INFO] tweaked toml for crates.io crate bagr 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate bagr 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12195eb50cebcd262efe89273553eb030cde43b767d150d2fafe5be4205ad67e [INFO] running `Command { std: "docker" "start" "-a" "12195eb50cebcd262efe89273553eb030cde43b767d150d2fafe5be4205ad67e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12195eb50cebcd262efe89273553eb030cde43b767d150d2fafe5be4205ad67e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12195eb50cebcd262efe89273553eb030cde43b767d150d2fafe5be4205ad67e", kill_on_drop: false }` [INFO] [stdout] 12195eb50cebcd262efe89273553eb030cde43b767d150d2fafe5be4205ad67e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b77a47465ef54a6fd6c00d4ca4c489fed93c9fbfefee099d7d35495bf45bbb36 [INFO] running `Command { std: "docker" "start" "-a" "b77a47465ef54a6fd6c00d4ca4c489fed93c9fbfefee099d7d35495bf45bbb36", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.7 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking combine v4.6.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking concolor-query v0.0.5 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking concolor v0.0.8 [INFO] [stderr] Checking os_pipe v1.0.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking yansi v0.5.0 [INFO] [stderr] Checking dunce v1.0.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking md-5 v0.10.1 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Checking blake2 v0.10.4 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling snafu-derive v0.7.0 [INFO] [stderr] Compiling clap_derive v3.1.2 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Checking clap v3.1.2 [INFO] [stderr] Checking snafu v0.7.0 [INFO] [stderr] Checking bagr v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `FETCH_TXT` is never used [INFO] [stdout] --> src/bagit/consts.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 32 | pub const FETCH_TXT: &str = "fetch.txt"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/bag.rs:431:27 [INFO] [stdout] | [INFO] [stdout] 431 | .map(|n| !TAG_MANIFEST_MATCHER.is_match(n)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/bag.rs:539:5 [INFO] [stdout] | [INFO] [stdout] 535 | fn rename, T: AsRef>(from: F, to: T) -> Result<()> { [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | fs::rename(from, to).context(IoMoveSnafu { from, to }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/bag.rs:546:5 [INFO] [stdout] | [INFO] [stdout] 542 | fn copy, T: AsRef>(from: F, to: T) -> Result<()> { [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | / fs::copy(from, to) [INFO] [stdout] 547 | | .map(|_| ()) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/bag.rs:553:38 [INFO] [stdout] | [INFO] [stdout] 552 | fn delete_payload_manifests>(base_dir: P) -> Result<()> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 553 | delete_matching_files(base_dir, &PAYLOAD_MANIFEST_MATCHER) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/bag.rs:558:38 [INFO] [stdout] | [INFO] [stdout] 557 | fn delete_tag_manifests>(base_dir: P) -> Result<()> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | delete_matching_files(base_dir, &TAG_MANIFEST_MATCHER) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/consts.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | Lazy::new(|| Regex::new(r"^manifest-([[:alnum:]]+)\.txt$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/consts.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | Lazy::new(|| Regex::new(r"^tagmanifest-([[:alnum:]]+)\.txt$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/digest.rs:71:27 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn reader(&self, reader: R) -> DigestReader { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | DigestReader::new(self.new_digest(), reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bagr` (lib) due to 13 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/digest.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn writer(&self, writer: W) -> DigestWriter { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | DigestWriter::new(self.new_digest(), writer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/digest.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn finalize_hex(self) -> HexDigest { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | self.digest.finalize().to_vec().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/digest.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn finalize_hex(self) -> HexDigest { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | self.digest.finalize().to_vec().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bagit/io.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Self { [INFO] [stdout] 109 | reader: LineReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b77a47465ef54a6fd6c00d4ca4c489fed93c9fbfefee099d7d35495bf45bbb36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b77a47465ef54a6fd6c00d4ca4c489fed93c9fbfefee099d7d35495bf45bbb36", kill_on_drop: false }` [INFO] [stdout] b77a47465ef54a6fd6c00d4ca4c489fed93c9fbfefee099d7d35495bf45bbb36