[INFO] fetching crate backtrace 0.3.73... [INFO] checking backtrace-0.3.73 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate backtrace 0.3.73 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate backtrace 0.3.73 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate backtrace 0.3.73 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate backtrace 0.3.73 [INFO] tweaked toml for crates.io crate backtrace 0.3.73 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate backtrace 0.3.73 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f9adb4017ace821fe65c3bfdee73026cb6cf9949d349296447fbf4e49d890d8 [INFO] running `Command { std: "docker" "start" "-a" "2f9adb4017ace821fe65c3bfdee73026cb6cf9949d349296447fbf4e49d890d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f9adb4017ace821fe65c3bfdee73026cb6cf9949d349296447fbf4e49d890d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f9adb4017ace821fe65c3bfdee73026cb6cf9949d349296447fbf4e49d890d8", kill_on_drop: false }` [INFO] [stdout] 2f9adb4017ace821fe65c3bfdee73026cb6cf9949d349296447fbf4e49d890d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6b116fd7cc3d54209c446a1b291a36b45b418c818a8e3c630a38f306af49475 [INFO] running `Command { std: "docker" "start" "-a" "b6b116fd7cc3d54209c446a1b291a36b45b418c818a8e3c630a38f306af49475", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking object v0.36.0 [INFO] [stderr] Compiling backtrace v0.3.73 (/opt/rustwide/workdir) [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 77 | fn mk(data: Mmap, mk: F) -> Option [INFO] [stdout] | ---------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Mapping::mk_or_other(data, move |data, stash| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 82 | | let cx = mk(data, stash)?; [INFO] [stdout] 83 | | Some(Either::B(cx)) [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 77 | fn mk(data: Mmap, mk: F) -> Option [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let cx = mk(data, stash)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(Either::B(cx)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:98:14 [INFO] [stdout] | [INFO] [stdout] 89 | fn mk_or_other(data: Mmap, mk: F) -> Option [INFO] [stdout] | ---------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let stash = Stash::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let cx = match mk(&data, &stash)? { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Either::A(mapping) => return Some(mapping), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Either::B(cx) => cx, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | }; [INFO] [stdout] 98 | Some(Mapping { [INFO] [stdout] | ______________^ [INFO] [stdout] 99 | | // Convert to 'static lifetimes since the symbols should [INFO] [stdout] 100 | | // only borrow `map` and `stash` and we're preserving them below. [INFO] [stdout] 101 | | cx: unsafe { core::mem::transmute::, Context<'static>>(cx) }, [INFO] [stdout] 102 | | _map: data, [INFO] [stdout] 103 | | stash: stash, [INFO] [stdout] 104 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 121 | let mut sections = gimli::Dwarf::load(|id| -> Result<_, ()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let dwarf = addr2line::Context::from_dwarf(sections).ok()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Some(Context { [INFO] [stdout] | ______________^ [INFO] [stdout] 164 | | dwarf, [INFO] [stdout] 165 | | object, [INFO] [stdout] 166 | | package, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:339:11 [INFO] [stdout] | [INFO] [stdout] 326 | unsafe fn with_global(f: impl FnOnce(&mut Self)) { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | f(MAPPINGS_CACHE.get_or_insert_with(|| Cache::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `backtrace` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 77 | fn mk(data: Mmap, mk: F) -> Option [INFO] [stdout] | ---------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Mapping::mk_or_other(data, move |data, stash| { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 82 | | let cx = mk(data, stash)?; [INFO] [stdout] 83 | | Some(Either::B(cx)) [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 77 | fn mk(data: Mmap, mk: F) -> Option [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let cx = mk(data, stash)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(Either::B(cx)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:98:14 [INFO] [stdout] | [INFO] [stdout] 89 | fn mk_or_other(data: Mmap, mk: F) -> Option [INFO] [stdout] | ---------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let stash = Stash::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let cx = match mk(&data, &stash)? { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Either::A(mapping) => return Some(mapping), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Either::B(cx) => cx, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | }; [INFO] [stdout] 98 | Some(Mapping { [INFO] [stdout] | ______________^ [INFO] [stdout] 99 | | // Convert to 'static lifetimes since the symbols should [INFO] [stdout] 100 | | // only borrow `map` and `stash` and we're preserving them below. [INFO] [stdout] 101 | | cx: unsafe { core::mem::transmute::, Context<'static>>(cx) }, [INFO] [stdout] 102 | | _map: data, [INFO] [stdout] 103 | | stash: stash, [INFO] [stdout] 104 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 121 | let mut sections = gimli::Dwarf::load(|id| -> Result<_, ()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let dwarf = addr2line::Context::from_dwarf(sections).ok()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Some(Context { [INFO] [stdout] | ______________^ [INFO] [stdout] 164 | | dwarf, [INFO] [stdout] 165 | | object, [INFO] [stdout] 166 | | package, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbolize/gimli.rs:339:11 [INFO] [stdout] | [INFO] [stdout] 326 | unsafe fn with_global(f: impl FnOnce(&mut Self)) { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | f(MAPPINGS_CACHE.get_or_insert_with(|| Cache::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `backtrace` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b6b116fd7cc3d54209c446a1b291a36b45b418c818a8e3c630a38f306af49475", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6b116fd7cc3d54209c446a1b291a36b45b418c818a8e3c630a38f306af49475", kill_on_drop: false }` [INFO] [stdout] b6b116fd7cc3d54209c446a1b291a36b45b418c818a8e3c630a38f306af49475