[INFO] fetching crate background-jobs-metrics 0.19.0... [INFO] checking background-jobs-metrics-0.19.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate background-jobs-metrics 0.19.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate background-jobs-metrics 0.19.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate background-jobs-metrics 0.19.0 [INFO] finished tweaking crates.io crate background-jobs-metrics 0.19.0 [INFO] tweaked toml for crates.io crate background-jobs-metrics 0.19.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding endian-type v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding sketches-ddsketch v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc890c5075597aba5c25dad48866eb31a606296168fedc6be56ede8b4d3f2fd6 [INFO] running `Command { std: "docker" "start" "-a" "dc890c5075597aba5c25dad48866eb31a606296168fedc6be56ede8b4d3f2fd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc890c5075597aba5c25dad48866eb31a606296168fedc6be56ede8b4d3f2fd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc890c5075597aba5c25dad48866eb31a606296168fedc6be56ede8b4d3f2fd6", kill_on_drop: false }` [INFO] [stdout] dc890c5075597aba5c25dad48866eb31a606296168fedc6be56ede8b4d3f2fd6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c01b745e6620999e39b914be55865505d79bc134850f484902682e92fed9ddfa [INFO] running `Command { std: "docker" "start" "-a" "c01b745e6620999e39b914be55865505d79bc134850f484902682e92fed9ddfa", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking metrics v0.23.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking metrics-util v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking background-jobs-core v0.19.0 [INFO] [stderr] Checking background-jobs-metrics v0.19.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 133 | let storage = Arc::new(StatsStorageInner::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let registry = Registry::new(StatsStorage { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (StatsRecorder { registry }, StatsHandle { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:139:38 [INFO] [stdout] | [INFO] [stdout] 133 | let storage = Arc::new(StatsStorageInner::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let registry = Registry::new(StatsStorage { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (StatsRecorder { registry }, StatsHandle { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:212:45 [INFO] [stdout] | [INFO] [stdout] 212 | .get_or_create_counter(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:216:52 [INFO] [stdout] | [INFO] [stdout] 216 | self.registry.get_or_create_gauge(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | .get_or_create_histogram(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `background-jobs-metrics` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 133 | let storage = Arc::new(StatsStorageInner::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let registry = Registry::new(StatsStorage { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (StatsRecorder { registry }, StatsHandle { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:139:38 [INFO] [stdout] | [INFO] [stdout] 133 | let storage = Arc::new(StatsStorageInner::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let registry = Registry::new(StatsStorage { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (StatsRecorder { registry }, StatsHandle { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:212:45 [INFO] [stdout] | [INFO] [stdout] 212 | .get_or_create_counter(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:216:52 [INFO] [stdout] | [INFO] [stdout] 216 | self.registry.get_or_create_gauge(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | .get_or_create_histogram(key, |c| c.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `background-jobs-metrics` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c01b745e6620999e39b914be55865505d79bc134850f484902682e92fed9ddfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c01b745e6620999e39b914be55865505d79bc134850f484902682e92fed9ddfa", kill_on_drop: false }` [INFO] [stdout] c01b745e6620999e39b914be55865505d79bc134850f484902682e92fed9ddfa