[INFO] fetching crate baba 0.2.1... [INFO] checking baba-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate baba 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate baba 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate baba 0.2.1 [INFO] finished tweaking crates.io crate baba 0.2.1 [INFO] tweaked toml for crates.io crate baba 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate baba 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5c932e100e5234c3e0dfb769964f41968ffe04eb163615310aaa947e1e4f603 [INFO] running `Command { std: "docker" "start" "-a" "d5c932e100e5234c3e0dfb769964f41968ffe04eb163615310aaa947e1e4f603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5c932e100e5234c3e0dfb769964f41968ffe04eb163615310aaa947e1e4f603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5c932e100e5234c3e0dfb769964f41968ffe04eb163615310aaa947e1e4f603", kill_on_drop: false }` [INFO] [stdout] d5c932e100e5234c3e0dfb769964f41968ffe04eb163615310aaa947e1e4f603 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28b22926355d5e49ef49b2d05b53da7a14e886049d99891239dfe8a8c6bc7929 [INFO] running `Command { std: "docker" "start" "-a" "28b22926355d5e49ef49b2d05b53da7a14e886049d99891239dfe8a8c6bc7929", kill_on_drop: false }` [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling sdl2 v0.37.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Compiling sdl2-sys v0.37.0 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking zune-jpeg v0.4.11 [INFO] [stderr] Checking glam v0.28.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking image v0.25.1 [INFO] [stderr] Checking baba v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn run(name: impl Into, update: impl Fn(&mut S)) -> Result [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | game(name, update).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 138 | let sdl = sdl2::init().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut canvas = gfx::Canvas::new(&sdl.video().unwrap(), flags)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok((canvas, mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn with_canvas(f: impl FnOnce(&mut Canvas) -> T) -> T { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | CANVAS.with_borrow_mut(|canvas| f(canvas.as_mut().expect("no active renderer"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn draw(object: &T, transform: impl Into) { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | with_canvas(|canvas| object.draw(canvas, transform.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx/texture.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn load_with(path: impl AsRef, options: impl Into) -> Self { [INFO] [stdout] | ---------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | / Self::try_load(path.as_ref(), options) [INFO] [stdout] 185 | | .inspect_err(|e| log::error!("Failed to load {}: {e}", path.as_ref().display())) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx/texture.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 200 | options: impl Into, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let data = Rc::new(TextureData::from_image(img, &options)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { data, origin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn run(name: impl Into, update: impl Fn(&mut S)) -> Result [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | game(name, update).run() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 138 | let sdl = sdl2::init().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut canvas = gfx::Canvas::new(&sdl.video().unwrap(), flags)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok((canvas, mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn with_canvas(f: impl FnOnce(&mut Canvas) -> T) -> T { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | CANVAS.with_borrow_mut(|canvas| f(canvas.as_mut().expect("no active renderer"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn draw(object: &T, transform: impl Into) { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | with_canvas(|canvas| object.draw(canvas, transform.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx/texture.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn load_with(path: impl AsRef, options: impl Into) -> Self { [INFO] [stdout] | ---------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | / Self::try_load(path.as_ref(), options) [INFO] [stdout] 185 | | .inspect_err(|e| log::error!("Failed to load {}: {e}", path.as_ref().display())) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gfx/texture.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 200 | options: impl Into, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let data = Rc::new(TextureData::from_image(img, &options)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { data, origin }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `baba` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `baba` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "28b22926355d5e49ef49b2d05b53da7a14e886049d99891239dfe8a8c6bc7929", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28b22926355d5e49ef49b2d05b53da7a14e886049d99891239dfe8a8c6bc7929", kill_on_drop: false }` [INFO] [stdout] 28b22926355d5e49ef49b2d05b53da7a14e886049d99891239dfe8a8c6bc7929