[INFO] fetching crate bab 0.0.1... [INFO] checking bab-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bab 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate bab 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bab 0.0.1 [INFO] finished tweaking crates.io crate bab 0.0.1 [INFO] tweaked toml for crates.io crate bab 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate bab 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8c085bd15eda7ab7fa4bdd6b996c9ebd9c39ccf72570f1870708e0058bdf8ea [INFO] running `Command { std: "docker" "start" "-a" "b8c085bd15eda7ab7fa4bdd6b996c9ebd9c39ccf72570f1870708e0058bdf8ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8c085bd15eda7ab7fa4bdd6b996c9ebd9c39ccf72570f1870708e0058bdf8ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8c085bd15eda7ab7fa4bdd6b996c9ebd9c39ccf72570f1870708e0058bdf8ea", kill_on_drop: false }` [INFO] [stdout] b8c085bd15eda7ab7fa4bdd6b996c9ebd9c39ccf72570f1870708e0058bdf8ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3bd3a1007fdfd99f4be993d3420ff50cae7f4ecbe9d4c86414381c0cb1f8bfc [INFO] running `Command { std: "docker" "start" "-a" "b3bd3a1007fdfd99f4be993d3420ff50cae7f4ecbe9d4c86414381c0cb1f8bfc", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking async-unsync v0.3.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking bab v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write_flusher.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 24 | flush_queue: WriterFlushQueue, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | flush_fn: impl FnMut(Flush) + 'static, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | flush_fn: Box::new(flush_fn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn get_or(&self, create: F) -> &T [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | self.insert(thread_id, create()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn get_or_try(&self, create: F) -> Result<&T, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(self.insert(thread_id, create()?)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:245:20 [INFO] [stdout] | [INFO] [stdout] 241 | buffer_pool: HeapBufferPool, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | flush_queue: WriterFlushQueue, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | inner: Arc::new(WriterInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 246 | | buffer_pool: buffer_pool, [INFO] [stdout] 247 | | cursor: CachePadded::new(AtomicU64::new( [INFO] [stdout] 248 | | CURSOR_INIT [INFO] [stdout] ... | [INFO] [stdout] 252 | | switch_buffer_waiters: WaiterQueue::new(), [INFO] [stdout] 253 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/waiter_queue.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 92 | fn with_state(&self, f: impl FnOnce(&mut WaiterNodeState) -> R) -> R { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | f(&mut self.state.lock()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/waiter_queue.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 96 | fn fulfill(&self, fulfillment: Fulfillment) -> Option { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | self.with_state(|state| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 98 | | Self::fulfill_common(state, fulfillment) [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bab` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b3bd3a1007fdfd99f4be993d3420ff50cae7f4ecbe9d4c86414381c0cb1f8bfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3bd3a1007fdfd99f4be993d3420ff50cae7f4ecbe9d4c86414381c0cb1f8bfc", kill_on_drop: false }` [INFO] [stdout] b3bd3a1007fdfd99f4be993d3420ff50cae7f4ecbe9d4c86414381c0cb1f8bfc