[INFO] fetching crate azi 0.4.4... [INFO] checking azi-0.4.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate azi 0.4.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate azi 0.4.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config [INFO] started tweaking crates.io crate azi 0.4.4 [INFO] finished tweaking crates.io crate azi 0.4.4 [INFO] tweaked toml for crates.io crate azi 0.4.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate azi 0.4.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63c0d1e21ca232f59bce9ebe18335715fb672ec64210ba0427e6ba3b0a02c01b [INFO] running `Command { std: "docker" "start" "-a" "63c0d1e21ca232f59bce9ebe18335715fb672ec64210ba0427e6ba3b0a02c01b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63c0d1e21ca232f59bce9ebe18335715fb672ec64210ba0427e6ba3b0a02c01b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63c0d1e21ca232f59bce9ebe18335715fb672ec64210ba0427e6ba3b0a02c01b", kill_on_drop: false }` [INFO] [stdout] 63c0d1e21ca232f59bce9ebe18335715fb672ec64210ba0427e6ba3b0a02c01b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f22f83f22d2309f1612bc3642f5553188937595b0ec41cdaf344903b457a8ab [INFO] running `Command { std: "docker" "start" "-a" "6f22f83f22d2309f1612bc3642f5553188937595b0ec41cdaf344903b457a8ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking rustls-pemfile v0.3.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.2 [INFO] [stderr] Checking ureq v2.4.0 [INFO] [stderr] Checking azi v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | for mut t in token_sets.iter_mut() { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | for mut t in token_sets.iter_mut() { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/error.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | HttpError(u16, Value), [INFO] [stdout] | --------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | HttpError(u16, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/object.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait Named { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 12 | fn name(&self) -> &String; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `location` is never read [INFO] [stdout] --> src/object.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct ManagedCluster { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 79 | pub id: String, [INFO] [stdout] 80 | pub location: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ManagedCluster` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/service.rs:515:9 [INFO] [stdout] | [INFO] [stdout] 514 | pub struct KubernetesCluster { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 515 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_u64` and `to_str` are never used [INFO] [stdout] --> src/utils.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub trait ValueExt { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 66 | fn to(self) -> Result; [INFO] [stdout] 67 | fn to_u64(&self) -> Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 68 | fn to_str(&self) -> Result<&str>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 58 | .ok_or_else(|| UnexpectedJson(decoded.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:298:11 [INFO] [stdout] | [INFO] [stdout] 136 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let mut logger = env_logger::Builder::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | match run_command() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 87 | let http = Http::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | tenant: RefCell::new(tenant), [INFO] [stdout] 101 | | access_token_file, [INFO] [stdout] 102 | | token_sets: RefCell::new(token_sets), [INFO] [stdout] 103 | | http, [INFO] [stdout] 104 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:123:15 [INFO] [stdout] | [INFO] [stdout] 123 | match self.execute_request(request, &token_set)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 220 | let tenant = self.tenant.try_borrow()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | match self.http.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 234 | | &refresh_url, [INFO] [stdout] 235 | | Some(&vec![Header::content_form()]), [INFO] [stdout] 236 | | Some(&body), [INFO] [stdout] 237 | | )? { [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 66 | let client_config = ClientConfig::builder() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Self::for_agent( [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | AgentBuilder::new() [INFO] [stdout] 72 | | .tls_config(Arc::new(client_config)) [INFO] [stdout] 73 | | .build(), [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | .or_else(|_| Err(InvalidCertificate(ca.to_owned())).into())?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 185 | fn to_json(response: ureq::Response) -> Value { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | match from_reader::<_, Value>(response.into_reader()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:551:36 [INFO] [stdout] | [INFO] [stdout] 551 | let to_str = |yaml: &Yaml| yaml.as_str().ok_or_else(err).map(|s| s.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tenant.rs:59:37 [INFO] [stdout] | [INFO] [stdout] 59 | .ok_or_else(|| UnexpectedJson(json.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 74 | fn to(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Ok(serde_json::from_value(self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "u64").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "str").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "string").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 96 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "array").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `azi` (bin "azi") due to 16 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/error.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | HttpError(u16, Value), [INFO] [stdout] | --------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | HttpError(u16, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/object.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait Named { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 12 | fn name(&self) -> &String; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `location` is never read [INFO] [stdout] --> src/object.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub struct ManagedCluster { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 79 | pub id: String, [INFO] [stdout] 80 | pub location: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ManagedCluster` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_u64` and `to_str` are never used [INFO] [stdout] --> src/utils.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub trait ValueExt { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 66 | fn to(self) -> Result; [INFO] [stdout] 67 | fn to_u64(&self) -> Result; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 68 | fn to_str(&self) -> Result<&str>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 58 | .ok_or_else(|| UnexpectedJson(decoded.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:298:11 [INFO] [stdout] | [INFO] [stdout] 136 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let mut logger = env_logger::Builder::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | match run_command() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 87 | let http = Http::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Client { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | tenant: RefCell::new(tenant), [INFO] [stdout] 101 | | access_token_file, [INFO] [stdout] 102 | | token_sets: RefCell::new(token_sets), [INFO] [stdout] 103 | | http, [INFO] [stdout] 104 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:123:15 [INFO] [stdout] | [INFO] [stdout] 123 | match self.execute_request(request, &token_set)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 220 | let tenant = self.tenant.try_borrow()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | match self.http.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 234 | | &refresh_url, [INFO] [stdout] 235 | | Some(&vec![Header::content_form()]), [INFO] [stdout] 236 | | Some(&body), [INFO] [stdout] 237 | | )? { [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 66 | let client_config = ClientConfig::builder() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Self::for_agent( [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | AgentBuilder::new() [INFO] [stdout] 72 | | .tls_config(Arc::new(client_config)) [INFO] [stdout] 73 | | .build(), [INFO] [stdout] 74 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | .or_else(|_| Err(InvalidCertificate(ca.to_owned())).into())?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 185 | fn to_json(response: ureq::Response) -> Value { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | match from_reader::<_, Value>(response.into_reader()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:551:36 [INFO] [stdout] | [INFO] [stdout] 551 | let to_str = |yaml: &Yaml| yaml.as_str().ok_or_else(err).map(|s| s.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tenant.rs:59:37 [INFO] [stdout] | [INFO] [stdout] 59 | .ok_or_else(|| UnexpectedJson(json.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 74 | fn to(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Ok(serde_json::from_value(self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "u64").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "str").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "string").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 96 | .ok_or_else(|| UnexpectedJsonType(self.clone(), "array").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `azi` (bin "azi" test) due to 16 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6f22f83f22d2309f1612bc3642f5553188937595b0ec41cdaf344903b457a8ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f22f83f22d2309f1612bc3642f5553188937595b0ec41cdaf344903b457a8ab", kill_on_drop: false }` [INFO] [stdout] 6f22f83f22d2309f1612bc3642f5553188937595b0ec41cdaf344903b457a8ab