[INFO] fetching crate ax25_tnc 0.3.0... [INFO] checking ax25_tnc-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ax25_tnc 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ax25_tnc 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ax25_tnc 0.3.0 [INFO] finished tweaking crates.io crate ax25_tnc 0.3.0 [INFO] tweaked toml for crates.io crate ax25_tnc 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ax25_tnc 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07b1b03ea23ba916b9244c1753f3643cd8e65f9dd968d51cc94e7c8dc0d40806 [INFO] running `Command { std: "docker" "start" "-a" "07b1b03ea23ba916b9244c1753f3643cd8e65f9dd968d51cc94e7c8dc0d40806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07b1b03ea23ba916b9244c1753f3643cd8e65f9dd968d51cc94e7c8dc0d40806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07b1b03ea23ba916b9244c1753f3643cd8e65f9dd968d51cc94e7c8dc0d40806", kill_on_drop: false }` [INFO] [stdout] 07b1b03ea23ba916b9244c1753f3643cd8e65f9dd968d51cc94e7c8dc0d40806 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e2e4c45c569f7f006d839fd4e27b9f894a8857a1a8701e25ad904ff0f109f9f [INFO] running `Command { std: "docker" "start" "-a" "8e2e4c45c569f7f006d839fd4e27b9f894a8857a1a8701e25ad904ff0f109f9f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking ax25 v0.3.0 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking deranged v0.3.8 [INFO] [stderr] Checking time v0.3.26 [INFO] [stderr] Checking ax25_tnc v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tnc.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 214 | let imp: Box = match &address.config { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(Tnc(Arc::new(Mutex::new(TncInner::new(imp))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tnc.rs:314:12 [INFO] [stdout] | [INFO] [stdout] 300 | let socket = linux::Ax25RawSocket::new().map_err(|e| TncError::OpenTnc { source: e })?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 315 | | socket: Arc::new(socket), [INFO] [stdout] 316 | | ifindex, [INFO] [stdout] 317 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kiss.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn new(addr: A) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let tx_stream = TcpStream::connect(addr)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let rx_stream = tx_stream.try_clone()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(TcpKissInterface { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | tx_stream: Mutex::new(tx_stream), [INFO] [stdout] 29 | | rx_stream: Mutex::new(rx_stream), [INFO] [stdout] 30 | | buffer: Mutex::new(Vec::new()), [INFO] [stdout] 31 | | is_shutdown: AtomicBool::new(false), [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ax25_tnc` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8e2e4c45c569f7f006d839fd4e27b9f894a8857a1a8701e25ad904ff0f109f9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e2e4c45c569f7f006d839fd4e27b9f894a8857a1a8701e25ad904ff0f109f9f", kill_on_drop: false }` [INFO] [stdout] 8e2e4c45c569f7f006d839fd4e27b9f894a8857a1a8701e25ad904ff0f109f9f