[INFO] fetching crate aws_secretsmanager_agent 1.0.0... [INFO] checking aws_secretsmanager_agent-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aws_secretsmanager_agent 1.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate aws_secretsmanager_agent 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aws_secretsmanager_agent 1.0.0 [INFO] finished tweaking crates.io crate aws_secretsmanager_agent 1.0.0 [INFO] tweaked toml for crates.io crate aws_secretsmanager_agent 1.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate aws_secretsmanager_agent 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35fdba3a026ea01961fd8996eed6c322b9b2abae915f27ede19c2013ccf2e920 [INFO] running `Command { std: "docker" "start" "-a" "35fdba3a026ea01961fd8996eed6c322b9b2abae915f27ede19c2013ccf2e920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35fdba3a026ea01961fd8996eed6c322b9b2abae915f27ede19c2013ccf2e920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35fdba3a026ea01961fd8996eed6c322b9b2abae915f27ede19c2013ccf2e920", kill_on_drop: false }` [INFO] [stdout] 35fdba3a026ea01961fd8996eed6c322b9b2abae915f27ede19c2013ccf2e920 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55ecd87c31ebebff20d660f9352866dfe878253c2d8756c909391ab9c517b178 [INFO] running `Command { std: "docker" "start" "-a" "55ecd87c31ebebff20d660f9352866dfe878253c2d8756c909391ab9c517b178", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking uuid v1.9.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking thread-id v4.2.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling darling_core v0.20.9 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling extend v0.1.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.9 [INFO] [stderr] Compiling darling v0.20.9 [INFO] [stderr] Compiling serde_with_macros v3.8.3 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking hyper v1.4.0 [INFO] [stderr] Checking aws-smithy-types v1.2.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking serde_with v3.8.3 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking aws-smithy-http v0.60.9 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking assert-json-diff v1.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking aws-smithy-protocol-test v0.60.7 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking aws-runtime v1.3.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.6.1 [INFO] [stderr] Checking aws-sdk-ssooidc v1.35.0 [INFO] [stderr] Checking aws-sdk-sso v1.34.0 [INFO] [stderr] Checking aws-sdk-sts v1.34.0 [INFO] [stderr] Checking aws-sdk-secretsmanager v1.38.0 [INFO] [stderr] Checking aws-config v1.5.4 [INFO] [stderr] Checking aws_secretsmanager_caching v1.0.0 [INFO] [stderr] Checking aws_secretsmanager_agent v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:78:53 [INFO] [stdout] | [INFO] [stdout] 77 | let svc_fn = service_fn(|req: Request| async { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | svr_clone.complete_req(req, rq_cnt).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws_secretsmanager_agent` (bin "aws_secretsmanager_agent") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_manager.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 284 | let fake_creds = secretsmanager::config::Credentials::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | let http_client = infallible_client_fn(|_req| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | / secretsmanager::Config::builder() [INFO] [stdout] 301 | | .behavior_version(BehaviorVersion::latest()) [INFO] [stdout] 302 | | .credentials_provider(fake_creds) [INFO] [stdout] 303 | | .interceptor(AgentModifierInterceptor) [INFO] [stdout] 304 | | .region(secretsmanager::config::Region::new("us-west-2")) [INFO] [stdout] 305 | | .http_client(http_client) [INFO] [stdout] 306 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_manager.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 291 | let http_client = infallible_client_fn(|_req| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let (code, rsp) = format_rsp(_req); [INFO] [stdout] 293 | / Response::builder() [INFO] [stdout] 294 | | .status(code) [INFO] [stdout] 295 | | .body(SdkBody::from(rsp)) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_manager.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 312 | let fake_creds = secretsmanager::config::Credentials::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | / secretsmanager::Config::builder() [INFO] [stdout] 322 | | .behavior_version(BehaviorVersion::latest()) [INFO] [stdout] 323 | | .credentials_provider(fake_creds) [INFO] [stdout] 324 | | .region(secretsmanager::config::Region::new("us-west-2")) [INFO] [stdout] 325 | | .http_client(NeverClient::new()) [INFO] [stdout] 326 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:78:53 [INFO] [stdout] | [INFO] [stdout] 77 | let svc_fn = service_fn(|req: Request| async { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | svr_clone.complete_req(req, rq_cnt).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:314:25 [INFO] [stdout] | [INFO] [stdout] 289 | opt_client: Option, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let end = move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let rpt = move |addr: &SocketAddr| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | rt.block_on(async move { [INFO] [stdout] | _________________________^ [INFO] [stdout] 315 | | if let Some(client) = opt_client { [INFO] [stdout] 316 | | set_client(client); [INFO] [stdout] 317 | | } [INFO] [stdout] 318 | | run(args, rpt, end).await.expect("could not run server"); [INFO] [stdout] 319 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:414:28 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|x| (x.1, x.2.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws_secretsmanager_agent` (bin "aws_secretsmanager_agent" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "55ecd87c31ebebff20d660f9352866dfe878253c2d8756c909391ab9c517b178", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55ecd87c31ebebff20d660f9352866dfe878253c2d8756c909391ab9c517b178", kill_on_drop: false }` [INFO] [stdout] 55ecd87c31ebebff20d660f9352866dfe878253c2d8756c909391ab9c517b178