[INFO] fetching crate aws-smithy-json 0.60.7... [INFO] checking aws-smithy-json-0.60.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aws-smithy-json 0.60.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate aws-smithy-json 0.60.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aws-smithy-json 0.60.7 [INFO] finished tweaking crates.io crate aws-smithy-json 0.60.7 [INFO] tweaked toml for crates.io crate aws-smithy-json 0.60.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b7596e12f417ce42ccab67f4886b98de932b152942f181ccd8c8db6e642714f [INFO] running `Command { std: "docker" "start" "-a" "5b7596e12f417ce42ccab67f4886b98de932b152942f181ccd8c8db6e642714f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b7596e12f417ce42ccab67f4886b98de932b152942f181ccd8c8db6e642714f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b7596e12f417ce42ccab67f4886b98de932b152942f181ccd8c8db6e642714f", kill_on_drop: false }` [INFO] [stdout] 5b7596e12f417ce42ccab67f4886b98de932b152942f181ccd8c8db6e642714f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b65c6e5eb06da6be9b8d012a86b745ad68b809c932bed883a797773daead32f1 [INFO] running `Command { std: "docker" "start" "-a" "b65c6e5eb06da6be9b8d012a86b745ad68b809c932bed883a797773daead32f1", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking aws-smithy-types v1.2.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking aws-smithy-json v0.60.7 (/opt/rustwide/workdir) [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:74:51 [INFO] [stdout] | [INFO] [stdout] 74 | self.peek_byte().ok_or_else(|| self.error(UnexpectedEos)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | self.next_byte().ok_or_else(|| self.error(UnexpectedEos)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:187:49 [INFO] [stdout] | [INFO] [stdout] 187 | .map_err(|_| self.error(InvalidUtf8))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:327:59 [INFO] [stdout] | [INFO] [stdout] 327 | .map_err(|_| self.error_at(start, InvalidNumber)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:329:80 [INFO] [stdout] | [INFO] [stdout] 329 | ... must_be_finite(f).map_err(|_| self.error_at(start, InvalidNumber)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:335:55 [INFO] [stdout] | [INFO] [stdout] 335 | .map_err(|_| self.error_at(start, InvalidNumber))?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:344:80 [INFO] [stdout] | [INFO] [stdout] 344 | u64::from_str(number_str).map_err(|_| self.error_at(start, InvalidNumber))?, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/error.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn custom(message: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self::new( [INFO] [stdout] 42 | / DeserializeErrorKind::Custom { [INFO] [stdout] 43 | | message: message.into(), [INFO] [stdout] 44 | | source: None, [INFO] [stdout] 45 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/error.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 52 | message: impl Into>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | source: impl Into>, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / DeserializeErrorKind::Custom { [INFO] [stdout] 57 | | message: message.into(), [INFO] [stdout] 58 | | source: Some(source.into()), [INFO] [stdout] 59 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws-smithy-json` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b65c6e5eb06da6be9b8d012a86b745ad68b809c932bed883a797773daead32f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b65c6e5eb06da6be9b8d012a86b745ad68b809c932bed883a797773daead32f1", kill_on_drop: false }` [INFO] [stdout] b65c6e5eb06da6be9b8d012a86b745ad68b809c932bed883a797773daead32f1