[INFO] fetching crate aws-smithy-async 1.2.1... [INFO] checking aws-smithy-async-1.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aws-smithy-async 1.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate aws-smithy-async 1.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aws-smithy-async 1.2.1 [INFO] finished tweaking crates.io crate aws-smithy-async 1.2.1 [INFO] tweaked toml for crates.io crate aws-smithy-async 1.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 725b592f8b805fff3103af3c8240bd31afbc13a2eb5bb1d03eea2335ff262b23 [INFO] running `Command { std: "docker" "start" "-a" "725b592f8b805fff3103af3c8240bd31afbc13a2eb5bb1d03eea2335ff262b23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "725b592f8b805fff3103af3c8240bd31afbc13a2eb5bb1d03eea2335ff262b23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "725b592f8b805fff3103af3c8240bd31afbc13a2eb5bb1d03eea2335ff262b23", kill_on_drop: false }` [INFO] [stdout] 725b592f8b805fff3103af3c8240bd31afbc13a2eb5bb1d03eea2335ff262b23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9542ac5150e1e84d64a62760a787818631ebe3449843b9c81db17fa00eb06c31 [INFO] running `Command { std: "docker" "start" "-a" "9542ac5150e1e84d64a62760a787818631ebe3449843b9c81db17fa00eb06c31", kill_on_drop: false }` [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking aws-smithy-async v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/now_or_later.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn new(future: F) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Self { [INFO] [stdout] 115 | inner: Inner::Later { future }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/now_or_later.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn ready(value: T) -> NowOrLater { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let value = Some(value); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Self { [INFO] [stdout] 123 | inner: Inner::Now { value }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/pagination_stream.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn flat_map(mut self, map: M) -> PaginationStream> [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | PaginationStream::new(FnStream::new(|tx| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 113 | | Box::pin(async move { [INFO] [stdout] 114 | | while let Some(page) = self.0.next().await { [INFO] [stdout] 115 | | match page { [INFO] [stdout] ... | [INFO] [stdout] 128 | | }) as Pin + Send>> [INFO] [stdout] 129 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/pagination_stream.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn flat_map(mut self, map: M) -> PaginationStream> [INFO] [stdout] | ---- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | PaginationStream::new(FnStream::new(|tx| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | / Box::pin(async move { [INFO] [stdout] 114 | | while let Some(page) = self.0.next().await { [INFO] [stdout] 115 | | match page { [INFO] [stdout] 116 | | Ok(page) => { [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | }) as Pin + Send>> [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/pagination_stream/fn_stream.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(generator: T) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let (tx, rx) = rendezvous::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | generator: Some(Box::pin(generator(tx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/rendezvous.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 26 | let (tx, rx) = tokio::sync::mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let semaphore = Arc::new(Semaphore::new(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ( [INFO] [stdout] 29 | / Sender { [INFO] [stdout] 30 | | semaphore: semaphore.clone(), [INFO] [stdout] 31 | | chan: tx, [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/rendezvous.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 26 | let (tx, rx) = tokio::sync::mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let semaphore = Arc::new(Semaphore::new(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / Receiver { [INFO] [stdout] 34 | | semaphore, [INFO] [stdout] 35 | | chan: rx, [INFO] [stdout] 36 | | needs_permit: false, [INFO] [stdout] 37 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt/sleep.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(sleep: impl AsyncSleep + 'static) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self(Arc::new(sleep)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt/sleep.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn new(future: impl Future + Send + Sync + 'static) -> Sleep { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Sleep(Box::pin(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(source: impl TimeSource + 'static) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Self(Arc::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws-smithy-async` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9542ac5150e1e84d64a62760a787818631ebe3449843b9c81db17fa00eb06c31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9542ac5150e1e84d64a62760a787818631ebe3449843b9c81db17fa00eb06c31", kill_on_drop: false }` [INFO] [stdout] 9542ac5150e1e84d64a62760a787818631ebe3449843b9c81db17fa00eb06c31