[INFO] fetching crate await-tree 0.2.1... [INFO] checking await-tree-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate await-tree 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate await-tree 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate await-tree 0.2.1 [INFO] finished tweaking crates.io crate await-tree 0.2.1 [INFO] tweaked toml for crates.io crate await-tree 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate await-tree 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c28dc05ad2b0fa89421a30a65810e1cfd514bd84c560de097db218041f7536e5 [INFO] running `Command { std: "docker" "start" "-a" "c28dc05ad2b0fa89421a30a65810e1cfd514bd84c560de097db218041f7536e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c28dc05ad2b0fa89421a30a65810e1cfd514bd84c560de097db218041f7536e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c28dc05ad2b0fa89421a30a65810e1cfd514bd84c560de097db218041f7536e5", kill_on_drop: false }` [INFO] [stdout] c28dc05ad2b0fa89421a30a65810e1cfd514bd84c560de097db218041f7536e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 571f6b123fcb4d0c4ab8f2138093f46c6cb59da30b55c64dd34fb58c1ef5158a [INFO] running `Command { std: "docker" "start" "-a" "571f6b123fcb4d0c4ab8f2138093f46c6cb59da30b55c64dd34fb58c1ef5158a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.152 [INFO] [stderr] Compiling crossbeam-epoch v0.9.14 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling futures-core v0.3.26 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Compiling futures-task v0.3.26 [INFO] [stderr] Compiling tokio v1.25.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rayon-core v1.10.2 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling futures-channel v0.3.26 [INFO] [stderr] Compiling futures-util v0.3.26 [INFO] [stderr] Compiling serde_json v1.0.93 [INFO] [stderr] Checking futures-sink v0.3.26 [INFO] [stderr] Checking crossbeam-channel v0.5.7 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking ryu v1.0.12 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking ciborium-io v0.2.0 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking plotters-svg v0.3.3 [INFO] [stderr] Checking ciborium-ll v0.2.0 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking tracing-core v0.1.30 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking futures-io v0.3.26 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking plotters v0.3.4 [INFO] [stderr] Checking flexstr v0.9.2 [INFO] [stderr] Checking rayon v1.6.1 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking coarsetime v0.1.23 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking weak-table v0.3.2 [INFO] [stderr] Checking indextree v4.5.0 [INFO] [stderr] Checking futures v0.3.26 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling pin-project-internal v1.0.12 [INFO] [stderr] Compiling tracing-attributes v0.1.23 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Checking pin-project v1.0.12 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking await-tree v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 45 | fn from(value: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Self(flexstr::SharedStr::from_ref(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:33 [INFO] [stdout] | [INFO] [stdout] 59 | fn instrument_await(self, span: impl Into) -> Instrumented { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Instrumented::new(self, span.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:33 [INFO] [stdout] | [INFO] [stdout] 65 | fn verbose_instrument_await(self, span: impl Into) -> Instrumented { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Instrumented::new(self, span.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) fn new(root_span: Span, verbose: bool) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let mut arena = Arena::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | tree: Tree { [INFO] [stdout] | ___________________^ [INFO] [stdout] 234 | | arena, [INFO] [stdout] 235 | | root, [INFO] [stdout] 236 | | current: root, [INFO] [stdout] 237 | | } [INFO] [stdout] 238 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:262:31 [INFO] [stdout] | [INFO] [stdout] 262 | current_context().map(|c| c.tree().clone()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) fn new(inner: F, span: Span) -> Self { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | state: State::Initial(span), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:119:15 [INFO] [stdout] | [INFO] [stdout] 61 | let context = current_context(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let (context, this_node) = match this.state { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Some(c) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Some(c) if c.id() == *this_context => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | match this.inner.poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 93 | fn new(key: impl ObjKey) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Self(Arc::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:177:23 [INFO] [stdout] | [INFO] [stdout] 170 | fn register_inner(&self, key: impl Key, context: Arc) -> TreeRoot { [INFO] [stdout] | ------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | registry: WeakRegistry(Arc::downgrade(&self.0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn get(&self, key: impl Key) -> Option { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | / self.contexts() [INFO] [stdout] 205 | | .read() [INFO] [stdout] 206 | | .get(&AnyKey::new(key)) // TODO: accept ref can? [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:207:22 [INFO] [stdout] | [INFO] [stdout] 207 | .map(|v| v.tree().clone()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:224:31 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|k| (k.clone(), v.tree().clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:224:42 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|k| (k.clone(), v.tree().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:249:28 [INFO] [stdout] | [INFO] [stdout] 249 | .map(|(k, v)| (k.clone(), v.tree().clone())) [INFO] [stdout] | ------ ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:249:39 [INFO] [stdout] | [INFO] [stdout] 249 | .map(|(k, v)| (k.clone(), v.tree().clone())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `await-tree` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "571f6b123fcb4d0c4ab8f2138093f46c6cb59da30b55c64dd34fb58c1ef5158a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "571f6b123fcb4d0c4ab8f2138093f46c6cb59da30b55c64dd34fb58c1ef5158a", kill_on_drop: false }` [INFO] [stdout] 571f6b123fcb4d0c4ab8f2138093f46c6cb59da30b55c64dd34fb58c1ef5158a