[INFO] fetching crate avr-tester 0.2.4... [INFO] checking avr-tester-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate avr-tester 0.2.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate avr-tester 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate avr-tester 0.2.4 [INFO] finished tweaking crates.io crate avr-tester 0.2.4 [INFO] tweaked toml for crates.io crate avr-tester 0.2.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66a57eb053c759615ea4b507d804a5e5c44b7c9f02b300ce2d942c23c5ad0048 [INFO] running `Command { std: "docker" "start" "-a" "66a57eb053c759615ea4b507d804a5e5c44b7c9f02b300ce2d942c23c5ad0048", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66a57eb053c759615ea4b507d804a5e5c44b7c9f02b300ce2d942c23c5ad0048", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66a57eb053c759615ea4b507d804a5e5c44b7c9f02b300ce2d942c23c5ad0048", kill_on_drop: false }` [INFO] [stdout] 66a57eb053c759615ea4b507d804a5e5c44b7c9f02b300ce2d942c23c5ad0048 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ec8fcbc3370393c4cc50fc636f7aba02385e405920cb5e38f8b8db271d9206c [INFO] running `Command { std: "docker" "start" "-a" "7ec8fcbc3370393c4cc50fc636f7aba02385e405920cb5e38f8b8db271d9206c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling simavr-ffi v1.0.1 [INFO] [stderr] Checking avr-simulator v0.2.4 [INFO] [stderr] Checking avr-tester v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 66 | firmware: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | sim: Some(AvrSimulator::new(mcu, clock_frequency, firmware)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 66 | firmware: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | components: Components::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/component_runtime.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn setup(sim: AvrSimulator, clock_frequency: u32, tt: AvrDuration) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | RUNTIME.with(move |rt| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 13 | | *rt.borrow_mut() = Some(Self { [INFO] [stdout] 14 | | sim, [INFO] [stdout] 15 | | clock_frequency, [INFO] [stdout] 16 | | tt, [INFO] [stdout] 17 | | }); [INFO] [stdout] 18 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/component_runtime.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with(f: impl FnOnce(&mut Self) -> T) -> T { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | RUNTIME.with(|rt| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 32 | | let mut rt = rt.borrow_mut(); [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | let rt = rt [INFO] [stdout] ... | [INFO] [stdout] 38 | | f(rt) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn write(&mut self, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.with(|spi| spi.write(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 66 | firmware: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | sim: Some(AvrSimulator::new(mcu, clock_frequency, firmware)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 66 | firmware: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | components: Components::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 134 | fn with(&self, f: impl FnOnce(&mut Spi) -> T) -> T { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ComponentRuntime::with(|rt| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 136 | | let mut spi = Spi::new(rt.sim(), self.id); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | f(&mut spi) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uart.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn write(&mut self, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.with(|uart| uart.write(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uart.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 134 | fn with(&self, f: impl FnOnce(&mut Uart) -> T) -> T { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ComponentRuntime::with(|rt| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 136 | | let mut uart = Uart::new(rt.sim(), self.id); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | f(&mut uart) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/component_runtime.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn setup(sim: AvrSimulator, clock_frequency: u32, tt: AvrDuration) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | RUNTIME.with(move |rt| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 13 | | *rt.borrow_mut() = Some(Self { [INFO] [stdout] 14 | | sim, [INFO] [stdout] 15 | | clock_frequency, [INFO] [stdout] 16 | | tt, [INFO] [stdout] 17 | | }); [INFO] [stdout] 18 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/component_runtime.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with(f: impl FnOnce(&mut Self) -> T) -> T { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | RUNTIME.with(|rt| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 32 | | let mut rt = rt.borrow_mut(); [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | let rt = rt [INFO] [stdout] ... | [INFO] [stdout] 38 | | f(rt) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn write(&mut self, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.with(|spi| spi.write(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 134 | fn with(&self, f: impl FnOnce(&mut Spi) -> T) -> T { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ComponentRuntime::with(|rt| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 136 | | let mut spi = Spi::new(rt.sim(), self.id); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | f(&mut spi) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uart.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn write(&mut self, value: T) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | self.with(|uart| uart.write(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uart.rs:135:32 [INFO] [stdout] | [INFO] [stdout] 134 | fn with(&self, f: impl FnOnce(&mut Uart) -> T) -> T { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ComponentRuntime::with(|rt| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 136 | | let mut uart = Uart::new(rt.sim(), self.id); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | f(&mut uart) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avr-tester` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `avr-tester` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "7ec8fcbc3370393c4cc50fc636f7aba02385e405920cb5e38f8b8db271d9206c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ec8fcbc3370393c4cc50fc636f7aba02385e405920cb5e38f8b8db271d9206c", kill_on_drop: false }` [INFO] [stdout] 7ec8fcbc3370393c4cc50fc636f7aba02385e405920cb5e38f8b8db271d9206c