[INFO] fetching crate avenger-vega 0.0.8... [INFO] checking avenger-vega-0.0.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate avenger-vega 0.0.8 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate avenger-vega 0.0.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate avenger-vega 0.0.8 [INFO] finished tweaking crates.io crate avenger-vega 0.0.8 [INFO] tweaked toml for crates.io crate avenger-vega 0.0.8 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 223 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding csscolorparser v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding fontdb v0.16.2 (latest: v0.21.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gif v0.12.0 (latest: v0.13.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding imagesize v0.12.0 (latest: v0.13.0) [INFO] [stderr] Adding kurbo v0.9.5 (latest: v0.11.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pyo3 v0.20.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.20.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.20.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.20.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.20.3 (latest: v0.22.2) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding resvg v0.38.0 (latest: v0.43.0) [INFO] [stderr] Adding roxmltree v0.19.0 (latest: v0.20.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding rustybuzz v0.12.1 (latest: v0.18.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strict-num v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding svgtypes v0.13.0 (latest: v0.15.2) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding ttf-parser v0.20.0 (latest: v0.24.1) [INFO] [stderr] Adding unicode-bidi-mirroring v0.1.0 (latest: v0.3.0) [INFO] [stderr] Adding unicode-ccc v0.1.2 (latest: v0.3.0) [INFO] [stderr] Adding usvg v0.38.0 (latest: v0.43.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0da530227c54889c73308247cad49dd63e4601f7a94da13bd8274cde60f1de4b [INFO] running `Command { std: "docker" "start" "-a" "0da530227c54889c73308247cad49dd63e4601f7a94da13bd8274cde60f1de4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0da530227c54889c73308247cad49dd63e4601f7a94da13bd8274cde60f1de4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0da530227c54889c73308247cad49dd63e4601f7a94da13bd8274cde60f1de4b", kill_on_drop: false }` [INFO] [stdout] 0da530227c54889c73308247cad49dd63e4601f7a94da13bd8274cde60f1de4b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff8bf6db316361af95f2b8c6993334cc257b35754af576202d28cc9a6d8f32a2 [INFO] running `Command { std: "docker" "start" "-a" "ff8bf6db316361af95f2b8c6993334cc257b35754af576202d28cc9a6d8f32a2", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking csscolorparser v0.6.2 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking lyon_geom v1.0.5 [INFO] [stderr] Checking lyon_path v1.0.5 [INFO] [stderr] Checking lyon_extra v1.0.2 [INFO] [stderr] Checking avenger v0.0.8 [INFO] [stderr] Checking avenger-vega v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/image.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 56 | let fetcher = make_image_fetcher()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(SceneMark::Image(Box::new(ImageMark { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | name, [INFO] [stdout] 99 | | clip: self.clip || force_clip, [INFO] [stdout] 100 | | len: self.items.len() as u32, [INFO] [stdout] ... | [INFO] [stdout] 111 | | zindex: self.zindex, [INFO] [stdout] 112 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/path.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 52 | let mut mark = PathMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(SceneMark::Path(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/shape.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut mark = PathMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(SceneMark::Path(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/symbol.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 106 | let mut mark = SymbolMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(SceneMark::Symbol(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/values.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 175 | fn deserialize(deserializer: D) -> std::result::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Option::deserialize(deserializer).map(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/image.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 56 | let fetcher = make_image_fetcher()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(SceneMark::Image(Box::new(ImageMark { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | name, [INFO] [stdout] 99 | | clip: self.clip || force_clip, [INFO] [stdout] 100 | | len: self.items.len() as u32, [INFO] [stdout] ... | [INFO] [stdout] 111 | | zindex: self.zindex, [INFO] [stdout] 112 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/path.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 52 | let mut mark = PathMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(SceneMark::Path(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/shape.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut mark = PathMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(SceneMark::Path(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/symbol.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 106 | let mut mark = SymbolMark { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(SceneMark::Symbol(mark)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marks/values.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 175 | fn deserialize(deserializer: D) -> std::result::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Option::deserialize(deserializer).map(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avenger-vega` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avenger-vega` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "ff8bf6db316361af95f2b8c6993334cc257b35754af576202d28cc9a6d8f32a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff8bf6db316361af95f2b8c6993334cc257b35754af576202d28cc9a6d8f32a2", kill_on_drop: false }` [INFO] [stdout] ff8bf6db316361af95f2b8c6993334cc257b35754af576202d28cc9a6d8f32a2