[INFO] fetching crate autosurgeon 0.8.5... [INFO] checking autosurgeon-0.8.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate autosurgeon 0.8.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate autosurgeon 0.8.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate autosurgeon 0.8.5 [INFO] finished tweaking crates.io crate autosurgeon 0.8.5 [INFO] tweaked toml for crates.io crate autosurgeon 0.8.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b69dd1838ed69ec03f5af69ddec7d42bcfda15848442b1d3fcce2e313b93593 [INFO] running `Command { std: "docker" "start" "-a" "0b69dd1838ed69ec03f5af69ddec7d42bcfda15848442b1d3fcce2e313b93593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b69dd1838ed69ec03f5af69ddec7d42bcfda15848442b1d3fcce2e313b93593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b69dd1838ed69ec03f5af69ddec7d42bcfda15848442b1d3fcce2e313b93593", kill_on_drop: false }` [INFO] [stdout] 0b69dd1838ed69ec03f5af69ddec7d42bcfda15848442b1d3fcce2e313b93593 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b20669d691b6f3fd91e21845c4c3d36ec50521b85c1769abd5813cc1e71d95f [INFO] running `Command { std: "docker" "start" "-a" "0b20669d691b6f3fd91e21845c4c3d36ec50521b85c1769abd5813cc1e71d95f", kill_on_drop: false }` [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling autosurgeon-derive v0.8.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Checking automerge v0.5.11 [INFO] [stderr] Checking automerge-test v0.4.3 [INFO] [stderr] Checking autosurgeon v0.8.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/reconcile/impls.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | if let Ok(v) = $ty::try_from(*i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | int_impl!(u64, Uint, u64); [INFO] [stdout] | ------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `int_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/reconcile/impls.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | if let Ok(v) = $ty::try_from(*i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | int_impl!(i64, Int, i64); [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: this warning originates in the macro `int_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 104 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 152 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 154 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 202 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 129 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | ) -> Result, HydrateError> { [INFO] [stdout] 131 | let mut path = path.into_iter().peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Some(hydrate_prop::<_, H, _, _>(doc, obj, prop)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | hydrate_map_impl(doc, obj, |k| Ok(K::from(k.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | hydrate_map_impl(doc, obj, |k| Ok(K::from(k.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 39 | extract_key: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .map(move |am::iter::MapRangeItem { key, .. }| { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let val = V::hydrate(doc, obj, key.into())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let key_parsed: K = extract_key(key)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok((key_parsed, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:432:13 [INFO] [stdout] | [INFO] [stdout] 431 | fn bytes>(&mut self, _value: B) -> Result<(), Self::Error> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | Err(ReconcileError::TopLevelNotMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 443 | fn str>(&mut self, _value: S) -> Result<(), Self::Error> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | Err(ReconcileError::TopLevelNotMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:551:9 [INFO] [stdout] | [INFO] [stdout] 550 | fn bytes>(&mut self, value: B) -> Result<(), Self::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 551 | / self.action [INFO] [stdout] 552 | | .create_primitive(self.doc, &self.current_obj, value.as_ref().to_vec()) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:569:9 [INFO] [stdout] | [INFO] [stdout] 568 | fn str>(&mut self, value: S) -> Result<(), Self::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | / self.action [INFO] [stdout] 570 | | .create_primitive(self.doc, &self.current_obj, value.as_ref()) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 717 | fn entry>(&self, prop: P) -> Option> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 718 | / self.doc [INFO] [stdout] 719 | | .get(&self.current_obj, prop.as_ref()) [INFO] [stdout] 720 | | .ok() [INFO] [stdout] 721 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:737:9 [INFO] [stdout] | [INFO] [stdout] 736 | fn delete>(&mut self, prop: P) -> Result<(), Self::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 737 | / self.doc [INFO] [stdout] 738 | | .delete(&self.current_obj, prop.as_ref()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map_with_parseable_keys.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn reconcile<'a, K, V, I, R>(items: I, reconciler: R) -> Result<(), R::Error> [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | items.into_iter().map(|(k, v)| (k.to_string(), v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map_with_parseable_keys.rs:64:52 [INFO] [stdout] | [INFO] [stdout] 64 | .map_err(|e| HydrateError::ParseMapKey(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `autosurgeon` (lib) due to 16 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/reconcile/impls.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | if let Ok(v) = $ty::try_from(*i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | int_impl!(u64, Uint, u64); [INFO] [stdout] | ------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `int_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/reconcile/impls.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | if let Ok(v) = $ty::try_from(*i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | int_impl!(i64, Int, i64); [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: this warning originates in the macro `int_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 104 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 152 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 154 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doc.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | fn object_type>(&self, obj: O) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | / am::ReadDoc::object_type(self, obj) [INFO] [stdout] 202 | | .map(Some) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 129 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | ) -> Result, HydrateError> { [INFO] [stdout] 131 | let mut path = path.into_iter().peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Some(hydrate_prop::<_, H, _, _>(doc, obj, prop)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | hydrate_map_impl(doc, obj, |k| Ok(K::from(k.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | hydrate_map_impl(doc, obj, |k| Ok(K::from(k.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate/map.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 39 | extract_key: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .map(move |am::iter::MapRangeItem { key, .. }| { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let val = V::hydrate(doc, obj, key.into())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let key_parsed: K = extract_key(key)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok((key_parsed, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:432:13 [INFO] [stdout] | [INFO] [stdout] 431 | fn bytes>(&mut self, _value: B) -> Result<(), Self::Error> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | Err(ReconcileError::TopLevelNotMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 443 | fn str>(&mut self, _value: S) -> Result<(), Self::Error> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | Err(ReconcileError::TopLevelNotMap) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:551:9 [INFO] [stdout] | [INFO] [stdout] 550 | fn bytes>(&mut self, value: B) -> Result<(), Self::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 551 | / self.action [INFO] [stdout] 552 | | .create_primitive(self.doc, &self.current_obj, value.as_ref().to_vec()) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:569:9 [INFO] [stdout] | [INFO] [stdout] 568 | fn str>(&mut self, value: S) -> Result<(), Self::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | / self.action [INFO] [stdout] 570 | | .create_primitive(self.doc, &self.current_obj, value.as_ref()) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 717 | fn entry>(&self, prop: P) -> Option> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 718 | / self.doc [INFO] [stdout] 719 | | .get(&self.current_obj, prop.as_ref()) [INFO] [stdout] 720 | | .ok() [INFO] [stdout] 721 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reconcile.rs:737:9 [INFO] [stdout] | [INFO] [stdout] 736 | fn delete>(&mut self, prop: P) -> Result<(), Self::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 737 | / self.doc [INFO] [stdout] 738 | | .delete(&self.current_obj, prop.as_ref()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map_with_parseable_keys.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn reconcile<'a, K, V, I, R>(items: I, reconciler: R) -> Result<(), R::Error> [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | items.into_iter().map(|(k, v)| (k.to_string(), v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map_with_parseable_keys.rs:64:52 [INFO] [stdout] | [INFO] [stdout] 64 | .map_err(|e| HydrateError::ParseMapKey(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `autosurgeon` (lib test) due to 16 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0b20669d691b6f3fd91e21845c4c3d36ec50521b85c1769abd5813cc1e71d95f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b20669d691b6f3fd91e21845c4c3d36ec50521b85c1769abd5813cc1e71d95f", kill_on_drop: false }` [INFO] [stdout] 0b20669d691b6f3fd91e21845c4c3d36ec50521b85c1769abd5813cc1e71d95f