[INFO] fetching crate audrey 0.3.0... [INFO] checking audrey-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate audrey 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate audrey 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate audrey 0.3.0 [INFO] finished tweaking crates.io crate audrey 0.3.0 [INFO] tweaked toml for crates.io crate audrey 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate audrey 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2453f10a06ce3a135d0cd52687244dfe0922e681f5004c641541c2fd4f5df89 [INFO] running `Command { std: "docker" "start" "-a" "a2453f10a06ce3a135d0cd52687244dfe0922e681f5004c641541c2fd4f5df89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2453f10a06ce3a135d0cd52687244dfe0922e681f5004c641541c2fd4f5df89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2453f10a06ce3a135d0cd52687244dfe0922e681f5004c641541c2fd4f5df89", kill_on_drop: false }` [INFO] [stdout] a2453f10a06ce3a135d0cd52687244dfe0922e681f5004c641541c2fd4f5df89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 61da3bea78675a100f64bdc16124ca7020873fd7d152e61909cdfa613e056779 [INFO] running `Command { std: "docker" "start" "-a" "61da3bea78675a100f64bdc16124ca7020873fd7d152e61909cdfa613e056779", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking bitreader v0.3.2 [INFO] [stderr] Compiling cpal v0.10.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking caf v0.1.0 [INFO] [stderr] Checking dasp_frame v0.11.0 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking mp4parse v0.10.1 [INFO] [stderr] Checking alac v0.5.0 [INFO] [stderr] Checking audrey v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:603:62 [INFO] [stdout] | [INFO] [stdout] 603 | FormatError::Flac(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:609:67 [INFO] [stdout] | [INFO] [stdout] 609 | FormatError::OggVorbis(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:611:61 [INFO] [stdout] | [INFO] [stdout] 611 | FormatError::Wav(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:617:61 [INFO] [stdout] | [INFO] [stdout] 617 | FormatError::Caf(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:645:58 [INFO] [stdout] | [INFO] [stdout] 645 | ReadError::Io(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:646:62 [INFO] [stdout] | [INFO] [stdout] 646 | ReadError::Reader(ref err) => std::error::Error::description(err), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:679:72 [INFO] [stdout] | [INFO] [stdout] 679 | FormatError::Alac(_) => write!(f, "{}", std::error::Error::description(self)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/read.rs:689:80 [INFO] [stdout] | [INFO] [stdout] 689 | ReadError::UnsupportedFormat => write!(f, "{}", std::error::Error::description(self)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caf_alac.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(rdr: T) -> Result, FormatError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let caf_reader = CafPacketReader::new(rdr, vec![ChunkType::MagicCookie])?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Some(AlacReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | caf_reader, [INFO] [stdout] 40 | | alac_decoder: Decoder::new(stream_info), [INFO] [stdout] 41 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking addr2line v0.14.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn new(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | Err(ReadError::UnsupportedFormat) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:428:17 [INFO] [stdout] | [INFO] [stdout] 427 | } => flac_samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | / sample [INFO] [stdout] 429 | | .map_err(FormatError::Flac) [INFO] [stdout] 430 | | .map(|sample| sample << (32 - sample_bits)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/read.rs:455:25 [INFO] [stdout] | [INFO] [stdout] 455 | std::mem::replace(buffer, packet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 455 | let _ = std::mem::replace(buffer, packet); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 467 | $samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | / sample [INFO] [stdout] 469 | | .map_err(FormatError::Wav) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 476 | WavSamples::I8(ref mut samples) => next_sample!(samples), [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `next_sample` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 467 | $samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | / sample [INFO] [stdout] 469 | | .map_err(FormatError::Wav) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 477 | WavSamples::I16(ref mut samples) => next_sample!(samples), [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `next_sample` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:479:25 [INFO] [stdout] | [INFO] [stdout] 478 | WavSamples::I24(ref mut samples) => samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | / sample [INFO] [stdout] 480 | | .map_err(FormatError::Wav) [INFO] [stdout] 481 | | .map(dasp_sample::I24::new_unchecked) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 467 | $samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | / sample [INFO] [stdout] 469 | | .map_err(FormatError::Wav) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 484 | WavSamples::I32(ref mut samples) => next_sample!(samples), [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `next_sample` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 467 | $samples.next().map(|sample| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | / sample [INFO] [stdout] 469 | | .map_err(FormatError::Wav) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 485 | WavSamples::F32(ref mut samples) => next_sample!(samples), [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `next_sample` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/read.rs:510:25 [INFO] [stdout] | [INFO] [stdout] 510 | std::mem::replace(buffer, packet); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 510 | let _ = std::mem::replace(buffer, packet); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:536:42 [INFO] [stdout] | [INFO] [stdout] 536 | let frame = F::from_fn(|_| match self.samples.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:589:27 [INFO] [stdout] | [INFO] [stdout] 588 | fn from(err: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | ReadError::Reader(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `audrey` (lib) due to 11 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "61da3bea78675a100f64bdc16124ca7020873fd7d152e61909cdfa613e056779", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61da3bea78675a100f64bdc16124ca7020873fd7d152e61909cdfa613e056779", kill_on_drop: false }` [INFO] [stdout] 61da3bea78675a100f64bdc16124ca7020873fd7d152e61909cdfa613e056779