[INFO] fetching crate audio 0.2.0... [INFO] checking audio-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate audio 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate audio 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate audio 0.2.0 [INFO] finished tweaking crates.io crate audio 0.2.0 [INFO] tweaked toml for crates.io crate audio 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding bittle v0.2.2 (latest: v0.5.7) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73566e468ef538f2186f07d239dec3e126d71c757e21893dbcc4d6df4ef77fd9 [INFO] running `Command { std: "docker" "start" "-a" "73566e468ef538f2186f07d239dec3e126d71c757e21893dbcc4d6df4ef77fd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73566e468ef538f2186f07d239dec3e126d71c757e21893dbcc4d6df4ef77fd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73566e468ef538f2186f07d239dec3e126d71c757e21893dbcc4d6df4ef77fd9", kill_on_drop: false }` [INFO] [stdout] 73566e468ef538f2186f07d239dec3e126d71c757e21893dbcc4d6df4ef77fd9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00b54351a8f0ab37bff3926521646ab8c71a9c4190a1ab1b52406e01c4ed7568 [INFO] running `Command { std: "docker" "start" "-a" "00b54351a8f0ab37bff3926521646ab8c71a9c4190a1ab1b52406e01c4ed7568", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking audio-core v0.2.0 [INFO] [stderr] Checking bittle v0.2.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking audio v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/channel/interleaved/macros.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | assert!(!self.ptr.as_ptr().is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/channel/interleaved.rs:374:1 [INFO] [stdout] | [INFO] [stdout] 374 | iterator!(struct Iter -> *const T, T, const, {/* no mut */}); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] = note: this warning originates in the macro `iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/channel/interleaved/macros.rs:194:30 [INFO] [stdout] | [INFO] [stdout] 194 | assert!(!self.ptr.as_ptr().is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/channel/interleaved.rs:374:1 [INFO] [stdout] | [INFO] [stdout] 374 | iterator!(struct Iter -> *const T, T, const, {/* no mut */}); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/channel/interleaved/macros.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | assert!(!self.ptr.as_ptr().is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/channel/interleaved.rs:375:1 [INFO] [stdout] | [INFO] [stdout] 375 | iterator!(struct IterMut -> *mut T, &'a mut T, mut, {&mut}); [INFO] [stdout] | ----------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/channel/interleaved/macros.rs:194:30 [INFO] [stdout] | [INFO] [stdout] 194 | assert!(!self.ptr.as_ptr().is_null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/channel/interleaved.rs:375:1 [INFO] [stdout] | [INFO] [stdout] 375 | iterator!(struct IterMut -> *mut T, &'a mut T, mut, {&mut}); [INFO] [stdout] | ----------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 23 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/read.rs:293:1 [INFO] [stdout] | [INFO] [stdout] 293 | / iter! { [INFO] [stdout] 294 | | available: usize, [INFO] [stdout] 295 | | => [INFO] [stdout] 296 | | self.tail(available) [INFO] [stdout] 297 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `iter` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 52 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/read.rs:299:1 [INFO] [stdout] | [INFO] [stdout] 299 | / iter_mut! { [INFO] [stdout] 300 | | available: usize, [INFO] [stdout] 301 | | => [INFO] [stdout] 302 | | self.tail(available) [INFO] [stdout] 303 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `iter_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 23 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/write.rs:300:1 [INFO] [stdout] | [INFO] [stdout] 300 | / iter! { [INFO] [stdout] 301 | | available: usize, [INFO] [stdout] 302 | | => [INFO] [stdout] 303 | | self.tail(available) [INFO] [stdout] 304 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `iter` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 52 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/write.rs:306:1 [INFO] [stdout] | [INFO] [stdout] 306 | / iter_mut! { [INFO] [stdout] 307 | | available: usize, [INFO] [stdout] 308 | | => [INFO] [stdout] 309 | | self.tail(available) [INFO] [stdout] 310 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `iter_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/read_write.rs:329:14 [INFO] [stdout] | [INFO] [stdout] 327 | let channel = self.buf.get_channel(channel)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let len = self.remaining(); [INFO] [stdout] 329 | Some(channel.skip(self.read).limit(len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 23 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/read_write.rs:396:1 [INFO] [stdout] | [INFO] [stdout] 396 | / iter! { [INFO] [stdout] 397 | | len: usize, [INFO] [stdout] 398 | | read: usize, [INFO] [stdout] 399 | | => [INFO] [stdout] 400 | | self.skip(read).limit(len) [INFO] [stdout] 401 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `iter` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/macros.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 52 | let channel = $self.iter.next()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Some(channel $(. $fn ($($self . $arg),*))*) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/io/read_write.rs:403:1 [INFO] [stdout] | [INFO] [stdout] 403 | / iter_mut! { [INFO] [stdout] 404 | | written: usize, [INFO] [stdout] 405 | | => [INFO] [stdout] 406 | | self.skip(written) [INFO] [stdout] 407 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `iter_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `audio` (lib) due to 8 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "00b54351a8f0ab37bff3926521646ab8c71a9c4190a1ab1b52406e01c4ed7568", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00b54351a8f0ab37bff3926521646ab8c71a9c4190a1ab1b52406e01c4ed7568", kill_on_drop: false }` [INFO] [stdout] 00b54351a8f0ab37bff3926521646ab8c71a9c4190a1ab1b52406e01c4ed7568