[INFO] fetching crate attribute-derive-macro 0.10.1... [INFO] checking attribute-derive-macro-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate attribute-derive-macro 0.10.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate attribute-derive-macro 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate attribute-derive-macro 0.10.1 [INFO] finished tweaking crates.io crate attribute-derive-macro 0.10.1 [INFO] tweaked toml for crates.io crate attribute-derive-macro 0.10.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afc21f95cc5ca423f9386701a83ca09731fcdf62ca13e0a2249d31838d015384 [INFO] running `Command { std: "docker" "start" "-a" "afc21f95cc5ca423f9386701a83ca09731fcdf62ca13e0a2249d31838d015384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afc21f95cc5ca423f9386701a83ca09731fcdf62ca13e0a2249d31838d015384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afc21f95cc5ca423f9386701a83ca09731fcdf62ca13e0a2249d31838d015384", kill_on_drop: false }` [INFO] [stdout] afc21f95cc5ca423f9386701a83ca09731fcdf62ca13e0a2249d31838d015384 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5096d96c0c619144f3bbff09d915eb38c35ef775055f8c62af4218b0715d86da [INFO] running `Command { std: "docker" "start" "-a" "5096d96c0c619144f3bbff09d915eb38c35ef775055f8c62af4218b0715d86da", kill_on_drop: false }` [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking collection_literals v1.0.1 [INFO] [stderr] Checking interpolator v0.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling proc-macro-utils v0.10.0 [INFO] [stderr] Compiling manyhow-macros v0.11.4 [INFO] [stderr] Checking manyhow v0.11.4 [INFO] [stderr] Compiling quote-use-macros v0.8.4 [INFO] [stderr] Checking quote-use v0.8.4 [INFO] [stderr] Checking attribute-derive-macro v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 176 | attrs: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let mut ident: Option = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 343 | | ident, [INFO] [stdout] 344 | | aliases, [INFO] [stdout] 345 | | error, [INFO] [stdout] 346 | | // duplicate, [INFO] [stdout] 347 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 361 | fn from_attrs(attrs: impl IntoIterator) -> Result { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let mut default: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | // let mut aggregate: bool = true; [INFO] [stdout] 367 | let mut conflicts: Vec = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 439 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 440 | | optional, [INFO] [stdout] 441 | | default, [INFO] [stdout] 442 | | // aggregate, [INFO] [stdout] ... | [INFO] [stdout] 445 | | positional, [INFO] [stdout] 446 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:535:12 [INFO] [stdout] | [INFO] [stdout] 530 | input: impl IntoIterator, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 531 | struct_error: &StructError, [INFO] [stdout] 532 | attribute_ident: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | ) -> Result<(Vec, Conflicts)> { [INFO] [stdout] 534 | let mut conflicts = Conflicts::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 536 | | input [INFO] [stdout] 537 | | .into_iter() [INFO] [stdout] 538 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 628 | | conflicts, [INFO] [stdout] 629 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:616:28 [INFO] [stdout] | [INFO] [stdout] 540 | |( [INFO] [stdout] | ______________________- [INFO] [stdout] 541 | | idx, [INFO] [stdout] 542 | | Field { [INFO] [stdout] 543 | | attrs, ident, ty, .. [INFO] [stdout] 544 | | }, [INFO] [stdout] 545 | | )| { [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 552 | default, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 553 | conflicts: field_conflicts, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | let duplicate = struct_error [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 608 | let default = if let Some(default) = default { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 611 | Some(quote!(<#ty as Default>::default())) [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 616 | Ok(AttrField { [INFO] [stdout] | ____________________________^ [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] 617 | | positional, [INFO] [stdout] 618 | | ident: ident.map_or(IdentOrIdx::Idx(idx), IdentOrIdx::Ident), [INFO] [stdout] 619 | | duplicate, [INFO] [stdout] ... | [INFO] [stdout] 623 | | ty, [INFO] [stdout] 624 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________________________| [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `attribute-derive-macro` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 176 | attrs: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let mut ident: Option = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 343 | | ident, [INFO] [stdout] 344 | | aliases, [INFO] [stdout] 345 | | error, [INFO] [stdout] 346 | | // duplicate, [INFO] [stdout] 347 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 361 | fn from_attrs(attrs: impl IntoIterator) -> Result { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let mut default: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | // let mut aggregate: bool = true; [INFO] [stdout] 367 | let mut conflicts: Vec = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 439 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 440 | | optional, [INFO] [stdout] 441 | | default, [INFO] [stdout] 442 | | // aggregate, [INFO] [stdout] ... | [INFO] [stdout] 445 | | positional, [INFO] [stdout] 446 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:535:12 [INFO] [stdout] | [INFO] [stdout] 530 | input: impl IntoIterator, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 531 | struct_error: &StructError, [INFO] [stdout] 532 | attribute_ident: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | ) -> Result<(Vec, Conflicts)> { [INFO] [stdout] 534 | let mut conflicts = Conflicts::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 536 | | input [INFO] [stdout] 537 | | .into_iter() [INFO] [stdout] 538 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 628 | | conflicts, [INFO] [stdout] 629 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:616:28 [INFO] [stdout] | [INFO] [stdout] 540 | |( [INFO] [stdout] | ______________________- [INFO] [stdout] 541 | | idx, [INFO] [stdout] 542 | | Field { [INFO] [stdout] 543 | | attrs, ident, ty, .. [INFO] [stdout] 544 | | }, [INFO] [stdout] 545 | | )| { [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 552 | default, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 553 | conflicts: field_conflicts, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | let duplicate = struct_error [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 608 | let default = if let Some(default) = default { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 611 | Some(quote!(<#ty as Default>::default())) [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 616 | Ok(AttrField { [INFO] [stdout] | ____________________________^ [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] | |____________________________| [INFO] [stdout] 617 | | positional, [INFO] [stdout] 618 | | ident: ident.map_or(IdentOrIdx::Idx(idx), IdentOrIdx::Ident), [INFO] [stdout] 619 | | duplicate, [INFO] [stdout] ... | [INFO] [stdout] 623 | | ty, [INFO] [stdout] 624 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________________________| [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `attribute-derive-macro` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5096d96c0c619144f3bbff09d915eb38c35ef775055f8c62af4218b0715d86da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5096d96c0c619144f3bbff09d915eb38c35ef775055f8c62af4218b0715d86da", kill_on_drop: false }` [INFO] [stdout] 5096d96c0c619144f3bbff09d915eb38c35ef775055f8c62af4218b0715d86da