[INFO] fetching crate attr_alias 0.1.3... [INFO] checking attr_alias-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate attr_alias 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate attr_alias 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate attr_alias 0.1.3 [INFO] finished tweaking crates.io crate attr_alias 0.1.3 [INFO] tweaked toml for crates.io crate attr_alias 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41ad970f1e5fd1b3fc32f03a1c754ff8bc358e50259583686db9e9631c3ddd54 [INFO] running `Command { std: "docker" "start" "-a" "41ad970f1e5fd1b3fc32f03a1c754ff8bc358e50259583686db9e9631c3ddd54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41ad970f1e5fd1b3fc32f03a1c754ff8bc358e50259583686db9e9631c3ddd54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41ad970f1e5fd1b3fc32f03a1c754ff8bc358e50259583686db9e9631c3ddd54", kill_on_drop: false }` [INFO] [stdout] 41ad970f1e5fd1b3fc32f03a1c754ff8bc358e50259583686db9e9631c3ddd54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 477c66396afe8b6f5a6d3a58ce40a850713d442cd3ea8d747b213bad47dfb5a8 [INFO] running `Command { std: "docker" "start" "-a" "477c66396afe8b6f5a6d3a58ce40a850713d442cd3ea8d747b213bad47dfb5a8", kill_on_drop: false }` [INFO] [stderr] Checking attr_alias v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 205 | fn parse_empty(tokens: I) -> Result<()> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / tokens [INFO] [stdout] 210 | | .into_iter() [INFO] [stdout] 211 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 218 | fn eval_item(item: TokenStream, resolved: &mut bool) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut attr = false; [INFO] [stdout] 220 | / item.into_iter() [INFO] [stdout] 221 | | .map(|mut token| { [INFO] [stdout] 222 | | if let TokenTree::Group(group) = &mut token { [INFO] [stdout] 223 | | let delimiter = group.delimiter(); [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(token) [INFO] [stdout] 238 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(token) = $item.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | args: TokenStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let mut args = args.into_iter().fuse(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let name = next!(args, Ident)?; [INFO] [stdout] 49 | let mut pattern = args [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(pattern [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | .map(|x| x.to_string()) [INFO] [stdout] 79 | | .as_ref() [INFO] [stdout] 80 | | .or_else(|| self.0.get(DEFAULT_NAME)) [INFO] [stdout] ... | [INFO] [stdout] 84 | | .parse() [INFO] [stdout] 85 | | .expect("error parsing alias")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let mut attr_iter = attr.clone().into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / next!(attr_iter, Ident, to_string => "attr_alias") [INFO] [stdout] 91 | | .ok() [INFO] [stdout] 92 | | .map(|_| { [INFO] [stdout] 93 | | let args = next!( [INFO] [stdout] ... | [INFO] [stdout] 100 | | }) [INFO] [stdout] 101 | | .transpose()? [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(token) = $item.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match token { [INFO] [stdout] 23 | TokenTree::$type(x) $(if x.$method() == $value)? => Ok(x), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut attr_iter = attr.clone().into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let args = next!( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(args.stream()) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|args| self.resolve_args(args).map(|x| *attr = x)) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `attr_alias` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 205 | fn parse_empty(tokens: I) -> Result<()> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / tokens [INFO] [stdout] 210 | | .into_iter() [INFO] [stdout] 211 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 218 | fn eval_item(item: TokenStream, resolved: &mut bool) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut attr = false; [INFO] [stdout] 220 | / item.into_iter() [INFO] [stdout] 221 | | .map(|mut token| { [INFO] [stdout] 222 | | if let TokenTree::Group(group) = &mut token { [INFO] [stdout] 223 | | let delimiter = group.delimiter(); [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(token) [INFO] [stdout] 238 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(token) = $item.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | args: TokenStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let mut args = args.into_iter().fuse(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let name = next!(args, Ident)?; [INFO] [stdout] 49 | let mut pattern = args [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(pattern [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | .map(|x| x.to_string()) [INFO] [stdout] 79 | | .as_ref() [INFO] [stdout] 80 | | .or_else(|| self.0.get(DEFAULT_NAME)) [INFO] [stdout] ... | [INFO] [stdout] 84 | | .parse() [INFO] [stdout] 85 | | .expect("error parsing alias")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let mut attr_iter = attr.clone().into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / next!(attr_iter, Ident, to_string => "attr_alias") [INFO] [stdout] 91 | | .ok() [INFO] [stdout] 92 | | .map(|_| { [INFO] [stdout] 93 | | let args = next!( [INFO] [stdout] ... | [INFO] [stdout] 100 | | }) [INFO] [stdout] 101 | | .transpose()? [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(token) = $item.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match token { [INFO] [stdout] 23 | TokenTree::$type(x) $(if x.$method() == $value)? => Ok(x), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut attr_iter = attr.clone().into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let args = next!( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(args.stream()) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aliases.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|args| self.resolve_args(args).map(|x| *attr = x)) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `attr_alias` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "477c66396afe8b6f5a6d3a58ce40a850713d442cd3ea8d747b213bad47dfb5a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "477c66396afe8b6f5a6d3a58ce40a850713d442cd3ea8d747b213bad47dfb5a8", kill_on_drop: false }` [INFO] [stdout] 477c66396afe8b6f5a6d3a58ce40a850713d442cd3ea8d747b213bad47dfb5a8