[INFO] fetching crate atticus 0.3.0... [INFO] checking atticus-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atticus 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate atticus 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atticus 0.3.0 [INFO] finished tweaking crates.io crate atticus 0.3.0 [INFO] tweaked toml for crates.io crate atticus 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate atticus 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86120591cfdaaf39ec7b1841ba534edfeda6eaae632634b160446297937bb804 [INFO] running `Command { std: "docker" "start" "-a" "86120591cfdaaf39ec7b1841ba534edfeda6eaae632634b160446297937bb804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86120591cfdaaf39ec7b1841ba534edfeda6eaae632634b160446297937bb804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86120591cfdaaf39ec7b1841ba534edfeda6eaae632634b160446297937bb804", kill_on_drop: false }` [INFO] [stdout] 86120591cfdaaf39ec7b1841ba534edfeda6eaae632634b160446297937bb804 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2888bd68fe11defb4e9b75a6b4b65c5cbfdba2a42abf485a3c616f8b9b1e8835 [INFO] running `Command { std: "docker" "start" "-a" "2888bd68fe11defb4e9b75a6b4b65c5cbfdba2a42abf485a3c616f8b9b1e8835", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking atticus v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send_event(&self, event: Req) -> JoinHandle> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let sender = self.0.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | sender [INFO] [stdout] 72 | | .send((event, None)) [INFO] [stdout] 73 | | .await [INFO] [stdout] 74 | | .map_err(|_e| Error::EventError) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send_event(&self, event: Req) -> JoinHandle> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let sender = self.0.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | tokio::spawn(async move { [INFO] [stdout] 71 | / sender [INFO] [stdout] 72 | | .send((event, None)) [INFO] [stdout] 73 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn run(mut actor: T, buffer: usize) -> Handle [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let (tx, mut rx) = mpsc::channel::>(buffer); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | [INFO] [stdout] 157 | let handle = tokio::spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | requestor: Requestor(tx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atticus` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send_event(&self, event: Req) -> JoinHandle> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let sender = self.0.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | sender [INFO] [stdout] 72 | | .send((event, None)) [INFO] [stdout] 73 | | .await [INFO] [stdout] 74 | | .map_err(|_e| Error::EventError) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn send_event(&self, event: Req) -> JoinHandle> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let sender = self.0.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | tokio::spawn(async move { [INFO] [stdout] 71 | / sender [INFO] [stdout] 72 | | .send((event, None)) [INFO] [stdout] 73 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn run(mut actor: T, buffer: usize) -> Handle [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let (tx, mut rx) = mpsc::channel::>(buffer); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | [INFO] [stdout] 157 | let handle = tokio::spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | requestor: Requestor(tx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atticus` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "2888bd68fe11defb4e9b75a6b4b65c5cbfdba2a42abf485a3c616f8b9b1e8835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2888bd68fe11defb4e9b75a6b4b65c5cbfdba2a42abf485a3c616f8b9b1e8835", kill_on_drop: false }` [INFO] [stdout] 2888bd68fe11defb4e9b75a6b4b65c5cbfdba2a42abf485a3c616f8b9b1e8835