[INFO] fetching crate atopology 0.0.34... [INFO] checking atopology-0.0.34 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atopology 0.0.34 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate atopology 0.0.34 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atopology 0.0.34 [INFO] finished tweaking crates.io crate atopology 0.0.34 [INFO] tweaked toml for crates.io crate atopology 0.0.34 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding errno v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v0.7.5 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.0.46 (latest: v0.6.5) [INFO] [stderr] Adding procfs v0.13.3 (latest: v0.16.0) [INFO] [stderr] Adding raw-cpuid v10.7.0 (latest: v11.1.0) [INFO] [stderr] Adding rustix v0.35.16 (latest: v0.38.35) [INFO] [stderr] Adding windows-sys v0.42.0 (latest: v0.59.0) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c691b54476830fad0b26d339641cda0bcd2d5bcace2b9bb0e8dc0d824173a994 [INFO] running `Command { std: "docker" "start" "-a" "c691b54476830fad0b26d339641cda0bcd2d5bcace2b9bb0e8dc0d824173a994", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c691b54476830fad0b26d339641cda0bcd2d5bcace2b9bb0e8dc0d824173a994", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c691b54476830fad0b26d339641cda0bcd2d5bcace2b9bb0e8dc0d824173a994", kill_on_drop: false }` [INFO] [stdout] c691b54476830fad0b26d339641cda0bcd2d5bcace2b9bb0e8dc0d824173a994 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24af8c8f4db2fe28355361ad08f9b6b99599a695a4ccd50e811e55cd3bd7bf92 [INFO] running `Command { std: "docker" "start" "-a" "24af8c8f4db2fe28355361ad08f9b6b99599a695a4ccd50e811e55cd3bd7bf92", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling io-lifetimes v0.7.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling rustix v0.35.16 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling procfs v0.13.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling x86 v0.52.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking cstr_core v0.2.6 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking atopology v0.0.34 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `X2Apic` is never constructed [INFO] [stdout] --> src/lib.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 56 | enum ApicThreadInfo { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 57 | Apic(LocalApic), [INFO] [stdout] 58 | X2Apic(LocalX2Apic), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ApicThreadInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new_with_apic` and `new_with_x2apic` are never used [INFO] [stdout] --> src/lib.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 109 | impl Thread { [INFO] [stdout] | ----------- associated functions in this implementation [INFO] [stdout] 110 | /// Construct a thread with a LocalApic struct. [INFO] [stdout] 111 | fn new_with_apic( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn new_with_x2apic( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `max_proximity_info` and `proximity_domains` are never read [INFO] [stdout] --> src/lib.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 529 | pub struct MachineInfo { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 538 | max_proximity_info: MaximumSystemCharacteristics, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 539 | proximity_domains: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MachineInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PowersOf2` is never used [INFO] [stdout] --> src/cpuid.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | trait PowersOf2 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cpuid_bits_needed` is never used [INFO] [stdout] --> src/cpuid.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn cpuid_bits_needed(count: u8) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_processor_limits` is never used [INFO] [stdout] --> src/cpuid.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn get_processor_limits() -> (u8, u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_topology_from_apic_id` is never used [INFO] [stdout] --> src/cpuid.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_topology_from_apic_id(xapic_id: u8) -> (ThreadId, CoreId, PackageId) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_topology_from_x2apic_id` is never used [INFO] [stdout] --> src/cpuid.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn get_topology_from_x2apic_id(x2apic_id: u32) -> (ThreadId, CoreId, PackageId) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:29 [INFO] [stdout] | [INFO] [stdout] 286 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atopology` (lib) due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `X2Apic` is never constructed [INFO] [stdout] --> src/lib.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 56 | enum ApicThreadInfo { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 57 | Apic(LocalApic), [INFO] [stdout] 58 | X2Apic(LocalX2Apic), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ApicThreadInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new_with_apic` and `new_with_x2apic` are never used [INFO] [stdout] --> src/lib.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 109 | impl Thread { [INFO] [stdout] | ----------- associated functions in this implementation [INFO] [stdout] 110 | /// Construct a thread with a LocalApic struct. [INFO] [stdout] 111 | fn new_with_apic( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn new_with_x2apic( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `max_proximity_info` and `proximity_domains` are never read [INFO] [stdout] --> src/lib.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 529 | pub struct MachineInfo { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 538 | max_proximity_info: MaximumSystemCharacteristics, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 539 | proximity_domains: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MachineInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PowersOf2` is never used [INFO] [stdout] --> src/cpuid.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | trait PowersOf2 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cpuid_bits_needed` is never used [INFO] [stdout] --> src/cpuid.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn cpuid_bits_needed(count: u8) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_processor_limits` is never used [INFO] [stdout] --> src/cpuid.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn get_processor_limits() -> (u8, u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_topology_from_apic_id` is never used [INFO] [stdout] --> src/cpuid.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_topology_from_apic_id(xapic_id: u8) -> (ThreadId, CoreId, PackageId) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_topology_from_x2apic_id` is never used [INFO] [stdout] --> src/cpuid.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn get_topology_from_x2apic_id(x2apic_id: u32) -> (ThreadId, CoreId, PackageId) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:29 [INFO] [stdout] | [INFO] [stdout] 286 | .and_then(|nid| MACHINE_TOPOLOGY.nodes().find(move |node| node.id == nid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:674:9 [INFO] [stdout] | [INFO] [stdout] 674 | env_logger::try_init(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 674 | let _ = env_logger::try_init(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atopology` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "24af8c8f4db2fe28355361ad08f9b6b99599a695a4ccd50e811e55cd3bd7bf92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24af8c8f4db2fe28355361ad08f9b6b99599a695a4ccd50e811e55cd3bd7bf92", kill_on_drop: false }` [INFO] [stdout] 24af8c8f4db2fe28355361ad08f9b6b99599a695a4ccd50e811e55cd3bd7bf92