[INFO] fetching crate atomicslice 0.1.0... [INFO] checking atomicslice-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atomicslice 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate atomicslice 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atomicslice 0.1.0 [INFO] finished tweaking crates.io crate atomicslice 0.1.0 [INFO] tweaked toml for crates.io crate atomicslice 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19a03648de6915a4d5a652ac6bb25c47095d9b36a973d6f5669aab98085f07cf [INFO] running `Command { std: "docker" "start" "-a" "19a03648de6915a4d5a652ac6bb25c47095d9b36a973d6f5669aab98085f07cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19a03648de6915a4d5a652ac6bb25c47095d9b36a973d6f5669aab98085f07cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19a03648de6915a4d5a652ac6bb25c47095d9b36a973d6f5669aab98085f07cf", kill_on_drop: false }` [INFO] [stdout] 19a03648de6915a4d5a652ac6bb25c47095d9b36a973d6f5669aab98085f07cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6188442ea55bc5aef5846b8e76ca76736a3e65cddbb0f4d28dc9d4d5dfccb9d1 [INFO] running `Command { std: "docker" "start" "-a" "6188442ea55bc5aef5846b8e76ca76736a3e65cddbb0f4d28dc9d4d5dfccb9d1", kill_on_drop: false }` [INFO] [stderr] Checking atomicslice v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(mut data: Vec) -> AtomicSlice { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | data: UnsafeCell::new(data.into_boxed_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomicslice` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(mut data: Vec) -> AtomicSlice { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | data: UnsafeCell::new(data.into_boxed_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:37:32 [INFO] [stdout] | [INFO] [stdout] 36 | let atomic_slice = Arc::clone(&atomic_slice); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | std::thread::spawn(move || { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 38 | | for iter in 0..config.num_iterations { [INFO] [stdout] 39 | | // Read the slice and assert that its length is as expected and that all values are the same [INFO] [stdout] 40 | | let guard = atomic_slice.read(); [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:60:32 [INFO] [stdout] | [INFO] [stdout] 58 | let atomic_slice = Arc::clone(&atomic_slice); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let next_value_to_write = Arc::clone(&next_value_to_write); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | std::thread::spawn(move || { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 61 | | let mut data = Vec::::new(); [INFO] [stdout] 62 | | data.resize(config.length, T::default()); [INFO] [stdout] 63 | | for _ in 0..config.num_iterations { [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomicslice` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "6188442ea55bc5aef5846b8e76ca76736a3e65cddbb0f4d28dc9d4d5dfccb9d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6188442ea55bc5aef5846b8e76ca76736a3e65cddbb0f4d28dc9d4d5dfccb9d1", kill_on_drop: false }` [INFO] [stdout] 6188442ea55bc5aef5846b8e76ca76736a3e65cddbb0f4d28dc9d4d5dfccb9d1