[INFO] fetching crate atomic-destroy 0.1.0... [INFO] checking atomic-destroy-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atomic-destroy 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate atomic-destroy 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atomic-destroy 0.1.0 [INFO] finished tweaking crates.io crate atomic-destroy 0.1.0 [INFO] tweaked toml for crates.io crate atomic-destroy 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa1394ac610cd68c879c292d35e03240379542799f662310843f93ecb8b495b3 [INFO] running `Command { std: "docker" "start" "-a" "fa1394ac610cd68c879c292d35e03240379542799f662310843f93ecb8b495b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa1394ac610cd68c879c292d35e03240379542799f662310843f93ecb8b495b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa1394ac610cd68c879c292d35e03240379542799f662310843f93ecb8b495b3", kill_on_drop: false }` [INFO] [stdout] fa1394ac610cd68c879c292d35e03240379542799f662310843f93ecb8b495b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e82254bb35b1e8b2f67e2e321eabc40de5e27ccffb7fde220a438446fd42e20 [INFO] running `Command { std: "docker" "start" "-a" "8e82254bb35b1e8b2f67e2e321eabc40de5e27ccffb7fde220a438446fd42e20", kill_on_drop: false }` [INFO] [stderr] Checking atomic-destroy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicU8::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | if self.drop_state.compare_and_swap(0, 1, Ordering::SeqCst) == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicU8::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | .compare_and_swap(1, 2, Ordering::SeqCst) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn with(&self, f: impl FnOnce(&T) -> R) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.get().map(|v| f(&*v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn with(&self, f: impl FnOnce(&T) -> R) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.get().map(|v| f(&*v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomic-destroy` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU8::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | if self.drop_state.compare_and_swap(0, 1, Ordering::SeqCst) == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU8::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | .compare_and_swap(1, 2, Ordering::SeqCst) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn with(&self, f: impl FnOnce(&T) -> R) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.get().map(|v| f(&*v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn with(&self, f: impl FnOnce(&T) -> R) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.get().map(|v| f(&*v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:236:27 [INFO] [stdout] | [INFO] [stdout] 234 | let value = value.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | [INFO] [stdout] 236 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 237 | | while Instant::now() < limit { [INFO] [stdout] 238 | | match value.get() { [INFO] [stdout] 239 | | Some(v) => assert_eq!(**v, 5), [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:251:27 [INFO] [stdout] | [INFO] [stdout] 249 | let value = value.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | [INFO] [stdout] 251 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 252 | | for _ in 0..800 { [INFO] [stdout] 253 | | value.destroy(); [INFO] [stdout] 254 | | } [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomic-destroy` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8e82254bb35b1e8b2f67e2e321eabc40de5e27ccffb7fde220a438446fd42e20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e82254bb35b1e8b2f67e2e321eabc40de5e27ccffb7fde220a438446fd42e20", kill_on_drop: false }` [INFO] [stdout] 8e82254bb35b1e8b2f67e2e321eabc40de5e27ccffb7fde220a438446fd42e20