[INFO] fetching crate atm0s-sdn-transport-tcp 0.1.7... [INFO] checking atm0s-sdn-transport-tcp-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atm0s-sdn-transport-tcp 0.1.7 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate atm0s-sdn-transport-tcp 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atm0s-sdn-transport-tcp 0.1.7 [INFO] finished tweaking crates.io crate atm0s-sdn-transport-tcp 0.1.7 [INFO] tweaked toml for crates.io crate atm0s-sdn-transport-tcp 0.1.7 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 193 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-notify v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding atm0s-sdn-identity v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding atm0s-sdn-network v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding atm0s-sdn-router v0.1.4 (latest: v0.2.1) [INFO] [stderr] Adding atm0s-sdn-utils v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding local-ip-address v0.5.7 (latest: v0.6.2) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unsigned-varint v0.7.2 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abcc19884b0be1d657b8b8c706751560a93cb1a0ea22b833d6cd6bfe0eb2f3c8 [INFO] running `Command { std: "docker" "start" "-a" "abcc19884b0be1d657b8b8c706751560a93cb1a0ea22b833d6cd6bfe0eb2f3c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abcc19884b0be1d657b8b8c706751560a93cb1a0ea22b833d6cd6bfe0eb2f3c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abcc19884b0be1d657b8b8c706751560a93cb1a0ea22b833d6cd6bfe0eb2f3c8", kill_on_drop: false }` [INFO] [stdout] abcc19884b0be1d657b8b8c706751560a93cb1a0ea22b833d6cd6bfe0eb2f3c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 007c0eb110a9f732d10a86087917cb159c89658e7c4428dba1d29dfe61f166fe [INFO] running `Command { std: "docker" "start" "-a" "007c0eb110a9f732d10a86087917cb159c89658e7c4428dba1d29dfe61f166fe", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking multihash v0.19.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Compiling snow v0.9.6 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling convert-enum v0.1.0 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking libp2p-identity v0.2.9 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-notify v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking atm0s-sdn-utils v0.1.1 [INFO] [stderr] Checking multiaddr v0.18.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking async-bincode v0.7.2 [INFO] [stderr] Checking atm0s-sdn-identity v0.2.0 [INFO] [stderr] Checking atm0s-sdn-router v0.1.4 [INFO] [stderr] Checking atm0s-sdn-network v0.3.1 [INFO] [stderr] Compiling neli-proc-macros v0.1.3 [INFO] [stderr] Checking neli v0.6.4 [INFO] [stderr] Checking local-ip-address v0.5.7 [INFO] [stderr] Checking atm0s-sdn-transport-tcp v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 51 | remote_addr: NodeAddr, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | mut socket: AsyncBincodeStreamU16, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | timer: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | snow_state: Arc>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | ) -> (Self, Sender) { [INFO] [stdout] 58 | let (unreliable_sender, unr_rx) = bounded(unreliable_queue_size); [INFO] [stdout] | ----------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let task = async_std::task::spawn(async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / Self { [INFO] [stdout] 99 | | remote_addr, [INFO] [stdout] 100 | | remote_node_id, [INFO] [stdout] 101 | | conn_id, [INFO] [stdout] ... | [INFO] [stdout] 105 | | tmp_buf: Arc::new(Mutex::new([0; 1500])), [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 59 | if let Some((remote_node_id, remote_node_addr, remote_addr)) = self.pending_outgoing.remove(&conn_id) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | log::info!("[TcpConnector] connect to node {}", remote_node_addr); [INFO] [stdout] 61 | let timer = self.timer.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let node_id = self.node_id; [INFO] [stdout] 63 | let node_addr = self.node_addr.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let internal_tx = self.internal_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let secure = self.secure.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match TcpStream::connect(remote_addr).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | secure: secure.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | internal_tx: internal_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | connector: TcpConnector { [INFO] [stdout] | ________________________^ [INFO] [stdout] 69 | | secure, [INFO] [stdout] 70 | | conn_id_seed: 0, [INFO] [stdout] 71 | | node_addr, [INFO] [stdout] ... | [INFO] [stdout] 75 | | timer: Arc::new(SystemTimer()), [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | timer: Arc::new(SystemTimer()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 92 | Ok((socket, addr)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | log::info!("[TcpTransport] incoming connect from {}", addr); [INFO] [stdout] 94 | let internal_tx = self.internal_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let timer = self.timer.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let secure = self.secure.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut socket_read = AsyncBincodeStream::<_, TcpMsg, TcpMsg, _>::from(socket.clone()).for_async(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let socket_write = AsyncBincodeStream::<_, TcpMsg, TcpMsg, _>::from(socket.clone()).for_async(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | match incoming_handshake(secure, node_id, &mut socket_read, conn_id, &internal_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-transport-tcp` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 51 | remote_addr: NodeAddr, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | mut socket: AsyncBincodeStreamU16, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | timer: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | snow_state: Arc>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | ) -> (Self, Sender) { [INFO] [stdout] 58 | let (unreliable_sender, unr_rx) = bounded(unreliable_queue_size); [INFO] [stdout] | ----------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let task = async_std::task::spawn(async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / Self { [INFO] [stdout] 99 | | remote_addr, [INFO] [stdout] 100 | | remote_node_id, [INFO] [stdout] 101 | | conn_id, [INFO] [stdout] ... | [INFO] [stdout] 105 | | tmp_buf: Arc::new(Mutex::new([0; 1500])), [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 59 | if let Some((remote_node_id, remote_node_addr, remote_addr)) = self.pending_outgoing.remove(&conn_id) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | log::info!("[TcpConnector] connect to node {}", remote_node_addr); [INFO] [stdout] 61 | let timer = self.timer.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let node_id = self.node_id; [INFO] [stdout] 63 | let node_addr = self.node_addr.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let internal_tx = self.internal_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let secure = self.secure.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match TcpStream::connect(remote_addr).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | secure: secure.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | internal_tx: internal_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | connector: TcpConnector { [INFO] [stdout] | ________________________^ [INFO] [stdout] 69 | | secure, [INFO] [stdout] 70 | | conn_id_seed: 0, [INFO] [stdout] 71 | | node_addr, [INFO] [stdout] ... | [INFO] [stdout] 75 | | timer: Arc::new(SystemTimer()), [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(node_addr: NodeAddr, listener: TcpListener, secure: Arc) -> Self { [INFO] [stdout] | ------------------- --------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let node_id = node_addr.node_id(); [INFO] [stdout] 59 | let (internal_tx, internal_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | timer: Arc::new(SystemTimer()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 92 | Ok((socket, addr)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | log::info!("[TcpTransport] incoming connect from {}", addr); [INFO] [stdout] 94 | let internal_tx = self.internal_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let timer = self.timer.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let secure = self.secure.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut socket_read = AsyncBincodeStream::<_, TcpMsg, TcpMsg, _>::from(socket.clone()).for_async(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let socket_write = AsyncBincodeStream::<_, TcpMsg, TcpMsg, _>::from(socket.clone()).for_async(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | match incoming_handshake(secure, node_id, &mut socket_read, conn_id, &internal_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-transport-tcp` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "007c0eb110a9f732d10a86087917cb159c89658e7c4428dba1d29dfe61f166fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "007c0eb110a9f732d10a86087917cb159c89658e7c4428dba1d29dfe61f166fe", kill_on_drop: false }` [INFO] [stdout] 007c0eb110a9f732d10a86087917cb159c89658e7c4428dba1d29dfe61f166fe