[INFO] fetching crate atm0s-sdn-dht-discovery 0.1.6... [INFO] checking atm0s-sdn-dht-discovery-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate atm0s-sdn-dht-discovery 0.1.6 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate atm0s-sdn-dht-discovery 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atm0s-sdn-dht-discovery 0.1.6 [INFO] finished tweaking crates.io crate atm0s-sdn-dht-discovery 0.1.6 [INFO] tweaked toml for crates.io crate atm0s-sdn-dht-discovery 0.1.6 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 183 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-notify v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding atm0s-sdn-identity v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding atm0s-sdn-network v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding atm0s-sdn-router v0.1.4 (latest: v0.2.1) [INFO] [stderr] Adding atm0s-sdn-utils v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unsigned-varint v0.7.2 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd3b3b0a7455fd76ab17c7a612ac79fba90198b7b94cbafa3aed3ce9cc11cfd8 [INFO] running `Command { std: "docker" "start" "-a" "bd3b3b0a7455fd76ab17c7a612ac79fba90198b7b94cbafa3aed3ce9cc11cfd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd3b3b0a7455fd76ab17c7a612ac79fba90198b7b94cbafa3aed3ce9cc11cfd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd3b3b0a7455fd76ab17c7a612ac79fba90198b7b94cbafa3aed3ce9cc11cfd8", kill_on_drop: false }` [INFO] [stdout] bd3b3b0a7455fd76ab17c7a612ac79fba90198b7b94cbafa3aed3ce9cc11cfd8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83ad33b4efbd41f486f0ba35ada23fb3ab7a2ed39b5f63a4c6546102364c932f [INFO] running `Command { std: "docker" "start" "-a" "83ad33b4efbd41f486f0ba35ada23fb3ab7a2ed39b5f63a4c6546102364c932f", kill_on_drop: false }` [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking multihash v0.19.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking libp2p-identity v0.2.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling convert-enum v0.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking async-notify v0.2.0 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking multiaddr v0.18.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking atm0s-sdn-identity v0.2.0 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking atm0s-sdn-router v0.1.4 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking atm0s-sdn-utils v0.1.1 [INFO] [stderr] Checking atm0s-sdn-network v0.3.1 [INFO] [stderr] Checking atm0s-sdn-transport-vnet v0.2.1 [INFO] [stderr] Checking atm0s-sdn-dht-discovery v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/behavior.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | for (node, addr) in bootstrap { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/logic.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | for (node, addr, connected) in need_contact_nodes { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `started_at` is never read [INFO] [stdout] --> src/kbucket/entry.rs:4:52 [INFO] [stdout] | [INFO] [stdout] 4 | Connecting { distance: NodeId, addr: NodeAddr, started_at: u64 }, [INFO] [stdout] | ---------- field in this variant ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `started_at` is never read [INFO] [stdout] --> src/kbucket/entry.rs:5:51 [INFO] [stdout] | [INFO] [stdout] 5 | Connected { distance: NodeId, addr: NodeAddr, started_at: u64 }, [INFO] [stdout] | --------- field in this variant ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(opts: DiscoveryNetworkBehaviorOpts) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let logic_conf = DiscoveryLogicConf { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | logic: DiscoveryLogic::new(logic_conf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(opts: DiscoveryNetworkBehaviorOpts) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let logic_conf = DiscoveryLogicConf { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | outputs: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:129:14 [INFO] [stdout] | [INFO] [stdout] 127 | ...fn on_incoming_connection_connected(&mut self, ctx: &BehaviorContext, _now_ms: u64, connection: Arc) -> Option(ctx, connection); [INFO] [stdout] 129 | ... Some(Box::new(DiscoveryConnectionHandler::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 132 | ...fn on_outgoing_connection_connected(&mut self, ctx: &BehaviorContext, _now_ms: u64, connection: Arc) -> Option(ctx, connection); [INFO] [stdout] 134 | ... Some(Box::new(DiscoveryConnectionHandler::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 150 | fn on_handler_event(&mut self, ctx: &BehaviorContext, _now_ms: u64, node_id: NodeId, _connection_id: ConnId, event: BE) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | match event.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | table: KBucketTableWrap::new(conf.local_node_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | action_queues: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | request_memory: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Protocol` [INFO] [stdout] --> src/kbucket.rs:211:40 [INFO] [stdout] | [INFO] [stdout] 211 | use atm0s_sdn_identity::{NodeAddr, Protocol}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-dht-discovery` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/behavior.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | for (node, addr) in bootstrap { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/logic.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | for (node, addr, connected) in need_contact_nodes { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Msg` is never used [INFO] [stdout] --> src/find_key_request.rs:200:10 [INFO] [stdout] | [INFO] [stdout] 200 | enum Msg {} [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `started_at` is never read [INFO] [stdout] --> src/kbucket/entry.rs:4:52 [INFO] [stdout] | [INFO] [stdout] 4 | Connecting { distance: NodeId, addr: NodeAddr, started_at: u64 }, [INFO] [stdout] | ---------- field in this variant ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `started_at` is never read [INFO] [stdout] --> src/kbucket/entry.rs:5:51 [INFO] [stdout] | [INFO] [stdout] 5 | Connected { distance: NodeId, addr: NodeAddr, started_at: u64 }, [INFO] [stdout] | --------- field in this variant ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(opts: DiscoveryNetworkBehaviorOpts) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let logic_conf = DiscoveryLogicConf { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | logic: DiscoveryLogic::new(logic_conf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(opts: DiscoveryNetworkBehaviorOpts) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let logic_conf = DiscoveryLogicConf { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | outputs: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:129:14 [INFO] [stdout] | [INFO] [stdout] 127 | ...fn on_incoming_connection_connected(&mut self, ctx: &BehaviorContext, _now_ms: u64, connection: Arc) -> Option(ctx, connection); [INFO] [stdout] 129 | ... Some(Box::new(DiscoveryConnectionHandler::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 132 | ...fn on_outgoing_connection_connected(&mut self, ctx: &BehaviorContext, _now_ms: u64, connection: Arc) -> Option(ctx, connection); [INFO] [stdout] 134 | ... Some(Box::new(DiscoveryConnectionHandler::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 150 | fn on_handler_event(&mut self, ctx: &BehaviorContext, _now_ms: u64, node_id: NodeId, _connection_id: ConnId, event: BE) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | match event.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | table: KBucketTableWrap::new(conf.local_node_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | action_queues: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logic.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(conf: DiscoveryLogicConf) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | request_memory: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-dht-discovery` (lib test) due to 9 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "83ad33b4efbd41f486f0ba35ada23fb3ab7a2ed39b5f63a4c6546102364c932f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83ad33b4efbd41f486f0ba35ada23fb3ab7a2ed39b5f63a4c6546102364c932f", kill_on_drop: false }` [INFO] [stdout] 83ad33b4efbd41f486f0ba35ada23fb3ab7a2ed39b5f63a4c6546102364c932f