[INFO] fetching crate athene_macro 0.2.3... [INFO] checking athene_macro-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate athene_macro 0.2.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate athene_macro 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate athene_macro 0.2.3 [INFO] finished tweaking crates.io crate athene_macro 0.2.3 [INFO] tweaked toml for crates.io crate athene_macro 0.2.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d93f5f0ab66384c9a31ffa82d88ac415f0e32ee80ab4bf889e56b5635b7ce6ab [INFO] running `Command { std: "docker" "start" "-a" "d93f5f0ab66384c9a31ffa82d88ac415f0e32ee80ab4bf889e56b5635b7ce6ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d93f5f0ab66384c9a31ffa82d88ac415f0e32ee80ab4bf889e56b5635b7ce6ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d93f5f0ab66384c9a31ffa82d88ac415f0e32ee80ab4bf889e56b5635b7ce6ab", kill_on_drop: false }` [INFO] [stdout] d93f5f0ab66384c9a31ffa82d88ac415f0e32ee80ab4bf889e56b5635b7ce6ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4ba30274af749f13556e3b0bdae374d52265c95cec1f20f8546e5961969b157 [INFO] running `Command { std: "docker" "start" "-a" "e4ba30274af749f13556e3b0bdae374d52265c95cec1f20f8546e5961969b157", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking athene_macro v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `validator_exclusions` is never read [INFO] [stdout] --> src/controller/handler.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 241 | pub struct HandlerAttrs { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 242 | pub method_path: Vec<(String, String)>, [INFO] [stdout] 243 | pub validator_exclusions: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HandlerAttrs` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `validator_exclusions` is never read [INFO] [stdout] --> src/controller/handler.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 241 | pub struct HandlerAttrs { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 242 | pub method_path: Vec<(String, String)>, [INFO] [stdout] 243 | pub validator_exclusions: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HandlerAttrs` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:152:31 [INFO] [stdout] | [INFO] [stdout] 152 | .and_then(|t| t.path.segments.into_iter().next()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/attribute.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(args: AttributeArgs, input: &ItemImpl) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(ControllerAttr { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | ident: ident.clone(), [INFO] [stdout] 90 | | name, [INFO] [stdout] 91 | | version, [INFO] [stdout] 92 | | prefix, [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:152:31 [INFO] [stdout] | [INFO] [stdout] 152 | .and_then(|t| t.path.segments.into_iter().next()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 188 | let fn_arguments = m [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 225 | | sync_handler, [INFO] [stdout] 226 | | request_unused, [INFO] [stdout] 227 | | parse_query, [INFO] [stdout] 228 | | fn_arguments, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/attribute.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(args: AttributeArgs, input: &ItemImpl) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(ControllerAttr { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | ident: ident.clone(), [INFO] [stdout] 90 | | name, [INFO] [stdout] 91 | | version, [INFO] [stdout] 92 | | prefix, [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn new(mut m: ImplItemMethod) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let attrs = HandlerAttrs::new(std::mem::take(&mut m.attrs), &m)?; [INFO] [stdout] 257 | let wrapper_options = HandlerOption::new(&attrs, &m)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | let return_type = if let ReturnType::Type(_0, typ) = &m.sig.output { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | Ok(Handler { [INFO] [stdout] | ____________^ [INFO] [stdout] 264 | | attrs, [INFO] [stdout] 265 | | method: m, [INFO] [stdout] 266 | | return_type, [INFO] [stdout] 267 | | option: wrapper_options, [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:382:5 [INFO] [stdout] | [INFO] [stdout] 381 | pub fn parse_handlers(input: ItemImpl) -> Result> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | / input [INFO] [stdout] 383 | | .items [INFO] [stdout] 384 | | .into_iter() [INFO] [stdout] 385 | | .filter_map(|item| match item { [INFO] [stdout] 386 | | ImplItem::Method(m) => Some(Handler::new(m)), [INFO] [stdout] 387 | | _ => None, [INFO] [stdout] 388 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 188 | let fn_arguments = m [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 225 | | sync_handler, [INFO] [stdout] 226 | | request_unused, [INFO] [stdout] 227 | | parse_query, [INFO] [stdout] 228 | | fn_arguments, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(middleware_fn: ImplItem) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut m = if let ImplItem::Method(m) = middleware_fn { [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let fn_ident = Ident::new(&format!("{}_raw", m.sig.ident), Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | def: ImplItem::Method(m), [INFO] [stdout] 67 | | fn_ident, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn new(mut m: ImplItemMethod) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let attrs = HandlerAttrs::new(std::mem::take(&mut m.attrs), &m)?; [INFO] [stdout] 257 | let wrapper_options = HandlerOption::new(&attrs, &m)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | let return_type = if let ReturnType::Type(_0, typ) = &m.sig.output { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | Ok(Handler { [INFO] [stdout] | ____________^ [INFO] [stdout] 264 | | attrs, [INFO] [stdout] 265 | | method: m, [INFO] [stdout] 266 | | return_type, [INFO] [stdout] 267 | | option: wrapper_options, [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/handler.rs:382:5 [INFO] [stdout] | [INFO] [stdout] 381 | pub fn parse_handlers(input: ItemImpl) -> Result> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | / input [INFO] [stdout] 383 | | .items [INFO] [stdout] 384 | | .into_iter() [INFO] [stdout] 385 | | .filter_map(|item| match item { [INFO] [stdout] 386 | | ImplItem::Method(m) => Some(Handler::new(m)), [INFO] [stdout] 387 | | _ => None, [INFO] [stdout] 388 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(middleware_fn: ImplItem) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut m = if let ImplItem::Method(m) = middleware_fn { [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let fn_ident = Ident::new(&format!("{}_raw", m.sig.ident), Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | def: ImplItem::Method(m), [INFO] [stdout] 67 | | fn_ident, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `athene_macro` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `athene_macro` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e4ba30274af749f13556e3b0bdae374d52265c95cec1f20f8546e5961969b157", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4ba30274af749f13556e3b0bdae374d52265c95cec1f20f8546e5961969b157", kill_on_drop: false }` [INFO] [stdout] e4ba30274af749f13556e3b0bdae374d52265c95cec1f20f8546e5961969b157