[INFO] fetching crate async-weighted-semaphore 0.2.1... [INFO] checking async-weighted-semaphore-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-weighted-semaphore 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate async-weighted-semaphore 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-weighted-semaphore 0.2.1 [INFO] finished tweaking crates.io crate async-weighted-semaphore 0.2.1 [INFO] tweaked toml for crates.io crate async-weighted-semaphore 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 165 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding futures-locks v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_xorshift v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-test v0.2.1 (latest: v0.4.4) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c2f2865747cc18b77aeeb81c604aa023c7d205867d29dbb5b96f77a2f159b2a [INFO] running `Command { std: "docker" "start" "-a" "4c2f2865747cc18b77aeeb81c604aa023c7d205867d29dbb5b96f77a2f159b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c2f2865747cc18b77aeeb81c604aa023c7d205867d29dbb5b96f77a2f159b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c2f2865747cc18b77aeeb81c604aa023c7d205867d29dbb5b96f77a2f159b2a", kill_on_drop: false }` [INFO] [stdout] 4c2f2865747cc18b77aeeb81c604aa023c7d205867d29dbb5b96f77a2f159b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f9615cc1a3f37534b8478b9199ff4cc734260650cae85b846db8d35dd6f016d [INFO] running `Command { std: "docker" "start" "-a" "0f9615cc1a3f37534b8478b9199ff4cc734260650cae85b846db8d35dd6f016d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking async-weighted-semaphore v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking toml v0.7.8 [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/guard.rs:109:42 [INFO] [stdout] | [INFO] [stdout] 109 | semaphore: self.semaphore.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Semaphore` does not implement `Clone`, so calling `clone` on `&Semaphore` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 109 - semaphore: self.semaphore.clone(), [INFO] [stdout] 109 + semaphore: self.semaphore, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Semaphore`, implement `Clone` for it [INFO] [stdout] --> src/semaphore.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct Semaphore { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:121:40 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn new(semaphore: Arc, amount: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | SemaphoreGuardArc { semaphore: Some(semaphore), amount, panicking: panicking() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-weighted-semaphore` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0f9615cc1a3f37534b8478b9199ff4cc734260650cae85b846db8d35dd6f016d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f9615cc1a3f37534b8478b9199ff4cc734260650cae85b846db8d35dd6f016d", kill_on_drop: false }` [INFO] [stdout] 0f9615cc1a3f37534b8478b9199ff4cc734260650cae85b846db8d35dd6f016d