[INFO] fetching crate async-unsync 0.3.0... [INFO] checking async-unsync-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-unsync 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate async-unsync 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-unsync 0.3.0 [INFO] finished tweaking crates.io crate async-unsync 0.3.0 [INFO] tweaked toml for crates.io crate async-unsync 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b815e3f8bb79f4f247e4efe01fc621ba4f7c1caad0d9d3990e9c5a99fe92feb [INFO] running `Command { std: "docker" "start" "-a" "3b815e3f8bb79f4f247e4efe01fc621ba4f7c1caad0d9d3990e9c5a99fe92feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b815e3f8bb79f4f247e4efe01fc621ba4f7c1caad0d9d3990e9c5a99fe92feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b815e3f8bb79f4f247e4efe01fc621ba4f7c1caad0d9d3990e9c5a99fe92feb", kill_on_drop: false }` [INFO] [stdout] 3b815e3f8bb79f4f247e4efe01fc621ba4f7c1caad0d9d3990e9c5a99fe92feb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1ecc83c1f4b9e06e3f99b784eff47045727d9b3c145eea89a891e3e9437019a [INFO] running `Command { std: "docker" "start" "-a" "d1ecc83c1f4b9e06e3f99b784eff47045727d9b3c145eea89a891e3e9437019a", kill_on_drop: false }` [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking async-unsync v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bounded.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn from_iter(capacity: usize, iter: impl IntoIterator) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Self { queue: BoundedQueue::from_iter(capacity, iter) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bounded.rs:109:10 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn into_split(mut self) -> (Sender, Receiver) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.queue.0.get_mut().set_counted(); [INFO] [stdout] 108 | let queue = Rc::new(self.queue); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | (Sender { queue: Rc::clone(&queue) }, Receiver { queue }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bounded.rs:109:47 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn into_split(mut self) -> (Sender, Receiver) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | self.queue.0.get_mut().set_counted(); [INFO] [stdout] 108 | let queue = Rc::new(self.queue); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | (Sender { queue: Rc::clone(&queue) }, Receiver { queue }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bounded.rs:442:12 [INFO] [stdout] | [INFO] [stdout] 437 | pub fn try_reserve_owned(self) -> Result, TrySendError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | Ok(OwnedPermit { sender: Some(self) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unbounded.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 31 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self { queue: UnboundedQueue::from_iter(iter) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unbounded.rs:78:10 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn into_split(mut self) -> (UnboundedSender, UnboundedReceiver) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.queue.0.get_mut().set_counted(); [INFO] [stdout] 77 | let queue = Rc::new(self.queue); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | (UnboundedSender { queue: Rc::clone(&queue) }, UnboundedReceiver { queue }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unbounded.rs:78:56 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn into_split(mut self) -> (UnboundedSender, UnboundedReceiver) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.queue.0.get_mut().set_counted(); [INFO] [stdout] 77 | let queue = Rc::new(self.queue); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | (UnboundedSender { queue: Rc::clone(&queue) }, UnboundedReceiver { queue }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneshot.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn into_split(self) -> (Sender, Receiver) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let slot = Rc::new(self.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | (Sender { slot: Rc::clone(&slot) }, Receiver { slot }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneshot.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn into_split(self) -> (Sender, Receiver) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let slot = Rc::new(self.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | (Sender { slot: Rc::clone(&slot) }, Receiver { slot }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn into_deque(self) -> VecDeque { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.0.into_inner().queue [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 87 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self(UnsafeCell::new(Queue::new(VecDeque::from_iter(iter), Unbounded))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 115 | pub(crate) fn from_iter(capacity: usize, iter: impl IntoIterator) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let queue = VecDeque::from_iter(iter); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Self(UnsafeCell::new(Queue::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 121 | | queue, [INFO] [stdout] 122 | | Bounded { [INFO] [stdout] 123 | | semaphore: Semaphore::new(initial_capacity), [INFO] [stdout] ... | [INFO] [stdout] 126 | | }, [INFO] [stdout] 127 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:258:64 [INFO] [stdout] | [INFO] [stdout] 257 | const fn new(queue: VecDeque, extra: B) -> Self { [INFO] [stdout] | ------------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | Queue { mask: Mask::new(), queue, pop_count: 0, waker: None, extra } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-unsync` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d1ecc83c1f4b9e06e3f99b784eff47045727d9b3c145eea89a891e3e9437019a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1ecc83c1f4b9e06e3f99b784eff47045727d9b3c145eea89a891e3e9437019a", kill_on_drop: false }` [INFO] [stdout] d1ecc83c1f4b9e06e3f99b784eff47045727d9b3c145eea89a891e3e9437019a