[INFO] fetching crate async-traceroute 0.1.2... [INFO] checking async-traceroute-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-traceroute 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate async-traceroute 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-traceroute 0.1.2 [INFO] finished tweaking crates.io crate async-traceroute 0.1.2 [INFO] tweaked toml for crates.io crate async-traceroute 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate async-traceroute 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80ab3907364f6d3cc2922623a46070558d1ae8fbc95c75035e8f8496665d32a3 [INFO] running `Command { std: "docker" "start" "-a" "80ab3907364f6d3cc2922623a46070558d1ae8fbc95c75035e8f8496665d32a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80ab3907364f6d3cc2922623a46070558d1ae8fbc95c75035e8f8496665d32a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80ab3907364f6d3cc2922623a46070558d1ae8fbc95c75035e8f8496665d32a3", kill_on_drop: false }` [INFO] [stdout] 80ab3907364f6d3cc2922623a46070558d1ae8fbc95c75035e8f8496665d32a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37c4314d1251faa2f9bc9c071bc10aac64da5e1deb38271af7aab95d07586636 [INFO] running `Command { std: "docker" "start" "-a" "37c4314d1251faa2f9bc9c071bc10aac64da5e1deb38271af7aab95d07586636", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking pnet_base v0.35.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking pnet_macros_support v0.35.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking raw-cpuid v11.0.2 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling moka v0.12.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking triomphe v0.1.12 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling pnet v0.35.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking octseq v0.5.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking pnet_sys v0.35.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking pnet_datalink v0.35.0 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling pnet_macros v0.35.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pnet_packet v0.35.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pnet_transport v0.35.0 [INFO] [stderr] Checking domain v0.10.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking async-traceroute v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `ipv6_datagram` [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:170:24 [INFO] [stdout] | [INFO] [stdout] 170 | IpDatagram::V6(ipv6_datagram) => todo!() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ipv6_datagram` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ttl` [INFO] [stdout] --> src/traceroute/probe/task.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | ttl: u8, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ttl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `source_address` [INFO] [stdout] --> src/traceroute/probe/task.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | source_address: Ipv6Addr, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_source_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `destination_address` [INFO] [stdout] --> src/traceroute/probe/task.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | destination_address: Ipv6Addr, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_destination_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ip_id` [INFO] [stdout] --> src/traceroute/probe/task.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | ip_id: u16 [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_ip_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ipv6_datagram` [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:170:24 [INFO] [stdout] | [INFO] [stdout] 170 | IpDatagram::V6(ipv6_datagram) => todo!() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ipv6_datagram` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RandomUniquePort` is never constructed [INFO] [stdout] --> src/traceroute/utils.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct RandomUniquePort { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ttl` [INFO] [stdout] --> src/traceroute/probe/task.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | ttl: u8, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ttl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `source_address` [INFO] [stdout] --> src/traceroute/probe/task.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | source_address: Ipv6Addr, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_source_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `generate_ports`, and `generate_port` are never used [INFO] [stdout] --> src/traceroute/utils.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl RandomUniquePort { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn generate_ports(&mut self, tot_ports: u16) -> HashSet { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn generate_port(&mut self) -> u16 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_udp_datagram_with_ports` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:120:8 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn build_udp_datagram_with_ports(source_port: u16, destination_port: u16) -> Udp { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `destination_address` [INFO] [stdout] --> src/traceroute/probe/task.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | destination_address: Ipv6Addr, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_destination_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_default_ipv4_addr_interface` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:186:8 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn get_default_ipv4_addr_interface() -> Ipv4Addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ip_id` [INFO] [stdout] --> src/traceroute/probe/task.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | ip_id: u16 [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_ip_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_default_ipv6_addr_interface` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn get_default_ipv6_addr_interface() -> Ipv6Addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ttl` is never read [INFO] [stdout] --> src/traceroute/terminal.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 144 | struct PrintableHop { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 145 | ttl: u8, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_address` is never used [INFO] [stdout] --> src/traceroute/probe.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl ProbeResponse { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn from_address(&self) -> Ipv4Addr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `source_address` is never read [INFO] [stdout] --> src/traceroute/probe/task.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct UdpProbeTask { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | source_address: IpAddr, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `DEFAULT_DESTINATION_PORT` and `build` are never used [INFO] [stdout] --> src/traceroute/probe/generator.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 57 | impl TcpProbeTaskGenerator { [INFO] [stdout] | -------------------------- associated items in this implementation [INFO] [stdout] 58 | const DEFAULT_DESTINATION_PORT: u16 = 80; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | [INFO] [stdout] 60 | pub fn build(ip_id: u16, destination_port: u16) -> Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `stop` is never used [INFO] [stdout] --> src/traceroute/probe/sniffer.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait Sniffer { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn stop(&self) -> io::Result<()>; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `connect`, `local_addr`, and `send` are never used [INFO] [stdout] --> src/traceroute/async_socket.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 20 | impl AsyncSocket { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub async fn connect(&self, ip: Ipv4Addr) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn local_addr(&self) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | pub async fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `connect`, `local_addr`, and `send` are never used [INFO] [stdout] --> src/traceroute/async_socket.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 82 | impl MioTokioSocket { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 102 | fn connect(&self, ip: Ipv4Addr) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | fn local_addr(&self) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | current_ttl: Box::new(RefCell::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | current_query: Box::new(RefCell::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | probe_task_generator: Box::new(RefCell::new(probe_task_generator)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | icmp_probe_response_sniffer: Arc::new(icmp_probe_response_sniffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 76 | let icmp_probe_response_sniffer = Arc::clone(&self.icmp_probe_response_sniffer); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | tokio::spawn(async move { [INFO] [stdout] 78 | icmp_probe_response_sniffer.sniff().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 145 | let mut probe_task_generator = self.probe_task_generator.borrow_mut(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match probe_task_generator.generate_probe_task( [INFO] [stdout] | _______________^ [INFO] [stdout] 147 | | self.source_address, [INFO] [stdout] 148 | | self.destination_address, [INFO] [stdout] 149 | | &icmp_probe_response_sniffer, [INFO] [stdout] 150 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:155:65 [INFO] [stdout] | [INFO] [stdout] 151 | Ok((_, mut probe_task)) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | probe_task.send_probe(current_ttl, timeout).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> io::Result { [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | id: destination_port.to_string(), [INFO] [stdout] 92 | | socket: Self::build_socket( [INFO] [stdout] 93 | | source_address, [INFO] [stdout] ... | [INFO] [stdout] 103 | | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 197 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> io::Result { [INFO] [stdout] 199 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | id: ip_id.to_string(), [INFO] [stdout] 201 | | isn: Self::generate_isn(), [INFO] [stdout] 202 | | ip_id, [INFO] [stdout] ... | [INFO] [stdout] 213 | | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] 214 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:395:38 [INFO] [stdout] | [INFO] [stdout] 385 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | tx_to_icmp_raw_socket: Sender<(Vec, SocketAddr)>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/generator.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 101 | let (tx_to_shared_socket, rx_to_shared_socket) = mpsc::channel(Self::SHARED_SOCKET_BUFFER_SIZE); [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | icmp_id: crate::traceroute::utils::generate_u16(), [INFO] [stdout] 106 | | icmp_isn: isn, [INFO] [stdout] 107 | | tx_to_shared_socket [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/generator.rs:122:35 [INFO] [stdout] | [INFO] [stdout] 112 | let mut shared_socket = SharedAsyncTokioSocket::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | shared_socket.share().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mio_sck = MioTokioSocket::new(domain, ty, protocol)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let fd_mio_sck = AsyncFd::new(mio_sck)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | socket: Arc::new(fd_mio_sck), [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 92 | let socket = Socket::new(domain, ty, protocol)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Self { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 190 | rx: Receiver<(Vec, SocketAddr)>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | ) -> io::Result { [INFO] [stdout] 192 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 193 | | socket: AsyncSocket::new(domain, ty, protocol)?, [INFO] [stdout] 194 | | rx [INFO] [stdout] 195 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/builder.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 95 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let icmp_sniffer = match IcmpProbeResponseSniffer::new(probe_reply_parser) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(icmp_sniffer) => icmp_sniffer, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Err(error) => return Err(String::from(&format!("{}", error.to_string()))) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Traceroute::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | source_address, [INFO] [stdout] 126 | | self.destination_address.unwrap(), [INFO] [stdout] 127 | | self.max_ttl, [INFO] [stdout] ... | [INFO] [stdout] 133 | | icmp_sniffer, [INFO] [stdout] 134 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-traceroute` (lib) due to 17 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `RandomUniquePort` is never constructed [INFO] [stdout] --> src/traceroute/utils.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct RandomUniquePort { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `generate_ports`, and `generate_port` are never used [INFO] [stdout] --> src/traceroute/utils.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl RandomUniquePort { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn generate_ports(&mut self, tot_ports: u16) -> HashSet { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn generate_port(&mut self) -> u16 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_udp_datagram_with_ports` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:120:8 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn build_udp_datagram_with_ports(source_port: u16, destination_port: u16) -> Udp { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_default_ipv4_addr_interface` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:186:8 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn get_default_ipv4_addr_interface() -> Ipv4Addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_default_ipv6_addr_interface` is never used [INFO] [stdout] --> src/traceroute/utils/packet_utils.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn get_default_ipv6_addr_interface() -> Ipv6Addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ttl` is never read [INFO] [stdout] --> src/traceroute/terminal.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 144 | struct PrintableHop { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 145 | ttl: u8, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_address` is never used [INFO] [stdout] --> src/traceroute/probe.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl ProbeResponse { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn from_address(&self) -> Ipv4Addr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `source_address` is never read [INFO] [stdout] --> src/traceroute/probe/task.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct UdpProbeTask { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | source_address: IpAddr, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `DEFAULT_DESTINATION_PORT` and `build` are never used [INFO] [stdout] --> src/traceroute/probe/generator.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 57 | impl TcpProbeTaskGenerator { [INFO] [stdout] | -------------------------- associated items in this implementation [INFO] [stdout] 58 | const DEFAULT_DESTINATION_PORT: u16 = 80; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 59 | [INFO] [stdout] 60 | pub fn build(ip_id: u16, destination_port: u16) -> Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `stop` is never used [INFO] [stdout] --> src/traceroute/probe/sniffer.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait Sniffer { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn stop(&self) -> io::Result<()>; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `connect`, `local_addr`, and `send` are never used [INFO] [stdout] --> src/traceroute/async_socket.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 20 | impl AsyncSocket { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub async fn connect(&self, ip: Ipv4Addr) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn local_addr(&self) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | pub async fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `connect`, `local_addr`, and `send` are never used [INFO] [stdout] --> src/traceroute/async_socket.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 82 | impl MioTokioSocket { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 102 | fn connect(&self, ip: Ipv4Addr) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | fn local_addr(&self) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | fn send(&self, buf: &[u8]) -> io::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | current_ttl: Box::new(RefCell::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | current_query: Box::new(RefCell::new(1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | probe_task_generator: Box::new(RefCell::new(probe_task_generator)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 49 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | icmp_probe_response_sniffer: IcmpProbeResponseSniffer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | icmp_probe_response_sniffer: Arc::new(icmp_probe_response_sniffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 76 | let icmp_probe_response_sniffer = Arc::clone(&self.icmp_probe_response_sniffer); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | tokio::spawn(async move { [INFO] [stdout] 78 | icmp_probe_response_sniffer.sniff().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 145 | let mut probe_task_generator = self.probe_task_generator.borrow_mut(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match probe_task_generator.generate_probe_task( [INFO] [stdout] | _______________^ [INFO] [stdout] 147 | | self.source_address, [INFO] [stdout] 148 | | self.destination_address, [INFO] [stdout] 149 | | &icmp_probe_response_sniffer, [INFO] [stdout] 150 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute.rs:155:65 [INFO] [stdout] | [INFO] [stdout] 151 | Ok((_, mut probe_task)) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | probe_task.send_probe(current_ttl, timeout).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> io::Result { [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | id: destination_port.to_string(), [INFO] [stdout] 92 | | socket: Self::build_socket( [INFO] [stdout] 93 | | source_address, [INFO] [stdout] ... | [INFO] [stdout] 103 | | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 197 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | ) -> io::Result { [INFO] [stdout] 199 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | id: ip_id.to_string(), [INFO] [stdout] 201 | | isn: Self::generate_isn(), [INFO] [stdout] 202 | | ip_id, [INFO] [stdout] ... | [INFO] [stdout] 213 | | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] 214 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/task.rs:395:38 [INFO] [stdout] | [INFO] [stdout] 385 | probe_response_receiver: ProbeResponseReceiver, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | tx_to_icmp_raw_socket: Sender<(Vec, SocketAddr)>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | probe_response_receiver: Some(probe_response_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/generator.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 101 | let (tx_to_shared_socket, rx_to_shared_socket) = mpsc::channel(Self::SHARED_SOCKET_BUFFER_SIZE); [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | icmp_id: crate::traceroute::utils::generate_u16(), [INFO] [stdout] 106 | | icmp_isn: isn, [INFO] [stdout] 107 | | tx_to_shared_socket [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/probe/generator.rs:122:35 [INFO] [stdout] | [INFO] [stdout] 112 | let mut shared_socket = SharedAsyncTokioSocket::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | shared_socket.share().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mio_sck = MioTokioSocket::new(domain, ty, protocol)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let fd_mio_sck = AsyncFd::new(mio_sck)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | socket: Arc::new(fd_mio_sck), [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 92 | let socket = Socket::new(domain, ty, protocol)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Self { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/async_socket.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 190 | rx: Receiver<(Vec, SocketAddr)>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | ) -> io::Result { [INFO] [stdout] 192 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 193 | | socket: AsyncSocket::new(domain, ty, protocol)?, [INFO] [stdout] 194 | | rx [INFO] [stdout] 195 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traceroute/builder.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 95 | probe_task_generator: Box, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let icmp_sniffer = match IcmpProbeResponseSniffer::new(probe_reply_parser) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(icmp_sniffer) => icmp_sniffer, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Err(error) => return Err(String::from(&format!("{}", error.to_string()))) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Traceroute::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | source_address, [INFO] [stdout] 126 | | self.destination_address.unwrap(), [INFO] [stdout] 127 | | self.max_ttl, [INFO] [stdout] ... | [INFO] [stdout] 133 | | icmp_sniffer, [INFO] [stdout] 134 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-traceroute` (lib test) due to 17 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "37c4314d1251faa2f9bc9c071bc10aac64da5e1deb38271af7aab95d07586636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37c4314d1251faa2f9bc9c071bc10aac64da5e1deb38271af7aab95d07586636", kill_on_drop: false }` [INFO] [stdout] 37c4314d1251faa2f9bc9c071bc10aac64da5e1deb38271af7aab95d07586636