[INFO] fetching crate async-svc 0.0.2... [INFO] checking async-svc-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-svc 0.0.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate async-svc 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-svc 0.0.2 [INFO] finished tweaking crates.io crate async-svc 0.0.2 [INFO] tweaked toml for crates.io crate async-svc 0.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.6.0 (latest: v1.7.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding mio v0.7.14 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding ntapi v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.3.7 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.3.2 (latest: v2.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f29af83298f958375f3b535d52a0882bf4c12e463f8dd6559454173111213851 [INFO] running `Command { std: "docker" "start" "-a" "f29af83298f958375f3b535d52a0882bf4c12e463f8dd6559454173111213851", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f29af83298f958375f3b535d52a0882bf4c12e463f8dd6559454173111213851", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f29af83298f958375f3b535d52a0882bf4c12e463f8dd6559454173111213851", kill_on_drop: false }` [INFO] [stdout] f29af83298f958375f3b535d52a0882bf4c12e463f8dd6559454173111213851 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 306927b495400db463ee9ce078c72ad01a8e0a99439d59085f2134dbb5e7452f [INFO] running `Command { std: "docker" "start" "-a" "306927b495400db463ee9ce078c72ad01a8e0a99439d59085f2134dbb5e7452f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling tokio v0.3.7 [INFO] [stderr] Checking bytes v0.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling tokio-macros v0.3.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking async-svc v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/boxed.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | fn poll_ready(mut self: Pin<&mut Self>, cx: Context<'_>) -> Poll<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 20 | self.as_mut().poll_ready(cx) [INFO] [stdout] | ---------------------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/boxed.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | fn exec(mut self: Pin<&mut Self>, req: Req) -> Self::Fut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 24 | self.as_mut().exec(req) [INFO] [stdout] | ----------------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | fn poll_ready(mut self: Pin<&mut Self>, cx: Context<'_>) -> Poll<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 53 | self.as_mut().poll_ready(cx) [INFO] [stdout] | ---------------------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | fn exec(mut self: Pin<&mut Self>, req: Req) -> Self::Fut { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 57 | self.as_mut().exec(req) [INFO] [stdout] | ----------------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `init_svc` is never used [INFO] [stdout] --> src/factory.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait SvcFactory { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 10 | fn init_svc(&self, cfg: Self::Cfg) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn box_svc(svc: S) -> BoxSvc [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Box::pin(SvcWrapper::new(svc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 65 | fn exec(self: Pin<&mut Self>, req: Req) -> Self::Fut { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let this = self.project(); [INFO] [stdout] 67 | Box::pin(this.svc.exec(req)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 39 | fn exec(self: Pin<&mut Self>, req: Req) -> Self::Fut { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mapper = self.mapper.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let this = self.project(); [INFO] [stdout] 42 | MapSvcFut::new(this.svc.exec(req), mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 77 | let res = ready!(this.fut.poll(cx)); [INFO] [stdout] | --- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Poll::Ready((this.mapper)(res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/then.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(svc1: S1, svc2: S2) -> Self { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | svc2: Some(svc2), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/then.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn exec(self: Pin<&mut Self>, req: Req) -> Self::Fut { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | state: State::Svc1( [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | this.svc1.exec(req), [INFO] [stdout] 47 | | this.svc2.take().expect("Service must not be executed twice."), [INFO] [stdout] 48 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-svc` (lib) due to 7 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "306927b495400db463ee9ce078c72ad01a8e0a99439d59085f2134dbb5e7452f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "306927b495400db463ee9ce078c72ad01a8e0a99439d59085f2134dbb5e7452f", kill_on_drop: false }` [INFO] [stdout] 306927b495400db463ee9ce078c72ad01a8e0a99439d59085f2134dbb5e7452f