[INFO] fetching crate async-proxies 0.1.0... [INFO] checking async-proxies-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-proxies 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate async-proxies 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-proxies 0.1.0 [INFO] finished tweaking crates.io crate async-proxies 0.1.0 [INFO] tweaked toml for crates.io crate async-proxies 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate async-proxies 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52f5bd8ed6bea97ec9ac5ee0f45d93562f6d93d37d5226da8e285d86ceffbc09 [INFO] running `Command { std: "docker" "start" "-a" "52f5bd8ed6bea97ec9ac5ee0f45d93562f6d93d37d5226da8e285d86ceffbc09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52f5bd8ed6bea97ec9ac5ee0f45d93562f6d93d37d5226da8e285d86ceffbc09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52f5bd8ed6bea97ec9ac5ee0f45d93562f6d93d37d5226da8e285d86ceffbc09", kill_on_drop: false }` [INFO] [stdout] 52f5bd8ed6bea97ec9ac5ee0f45d93562f6d93d37d5226da8e285d86ceffbc09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72daa8ba0e85e95ea2b7f7c4521ae7a3a78c165ded044aecd07a5c7a80d1b7f8 [INFO] running `Command { std: "docker" "start" "-a" "72daa8ba0e85e95ea2b7f7c4521ae7a3a78c165ded044aecd07a5c7a80d1b7f8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling proc-macro2 v1.0.17 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.29 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking pin-project-lite v0.1.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.31 [INFO] [stderr] Checking tokio v0.2.21 [INFO] [stderr] Checking async-proxies v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:155:14 [INFO] [stdout] | [INFO] [stdout] 155 | async fn write_buffer(&mut self, buffer: &[u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 156 | | -> Result [INFO] [stdout] 157 | | { [INFO] [stdout] 158 | | match stream.write_all(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 167 | | // .map_err(|e| ErrorKind::RawStreamIOFailed(e)) [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 170 | async fn read_buffer(&mut self, buffer: &mut [u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 171 | | -> Result [INFO] [stdout] 172 | | { [INFO] [stdout] 173 | | match stream.read(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:179:14 [INFO] [stdout] | [INFO] [stdout] 83 | #[async_trait] [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | async fn drop_stream(&mut self, _: Self::OutputStream) [INFO] [stdout] | ______________^ [INFO] [stdout] 180 | | -> Result<(), Self::ErrorKind> [INFO] [stdout] 181 | | { [INFO] [stdout] 182 | | Ok(()) [INFO] [stdout] 183 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 120 | async fn write_buffer(&mut self, buffer: &[u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 121 | | -> Result [INFO] [stdout] 122 | | { [INFO] [stdout] 123 | | match stream.write_all(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 132 | | // .map_err(|e| ErrorKind::RawStreamIOFailed(e)) [INFO] [stdout] 133 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | async fn read_buffer(&mut self, buffer: &mut [u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 136 | | -> Result [INFO] [stdout] 137 | | { [INFO] [stdout] 138 | | match stream.read(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 50 | #[async_trait] [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | async fn drop_stream(&mut self, _: Self::OutputStream) [INFO] [stdout] | ______________^ [INFO] [stdout] 145 | | -> Result<(), Self::ErrorKind> [INFO] [stdout] 146 | | { [INFO] [stdout] 147 | | Ok(()) [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-proxies` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:155:14 [INFO] [stdout] | [INFO] [stdout] 155 | async fn write_buffer(&mut self, buffer: &[u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 156 | | -> Result [INFO] [stdout] 157 | | { [INFO] [stdout] 158 | | match stream.write_all(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 167 | | // .map_err(|e| ErrorKind::RawStreamIOFailed(e)) [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 170 | async fn read_buffer(&mut self, buffer: &mut [u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 171 | | -> Result [INFO] [stdout] 172 | | { [INFO] [stdout] 173 | | match stream.read(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/general.rs:179:14 [INFO] [stdout] | [INFO] [stdout] 83 | #[async_trait] [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | async fn drop_stream(&mut self, _: Self::OutputStream) [INFO] [stdout] | ______________^ [INFO] [stdout] 180 | | -> Result<(), Self::ErrorKind> [INFO] [stdout] 181 | | { [INFO] [stdout] 182 | | Ok(()) [INFO] [stdout] 183 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 120 | async fn write_buffer(&mut self, buffer: &[u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 121 | | -> Result [INFO] [stdout] 122 | | { [INFO] [stdout] 123 | | match stream.write_all(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 132 | | // .map_err(|e| ErrorKind::RawStreamIOFailed(e)) [INFO] [stdout] 133 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | async fn read_buffer(&mut self, buffer: &mut [u8], mut stream: Self::OutputStream) [INFO] [stdout] | ^ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 136 | | -> Result [INFO] [stdout] 137 | | { [INFO] [stdout] 138 | | match stream.read(buffer).await { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxies/socks4/no_ident.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 50 | #[async_trait] [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | async fn drop_stream(&mut self, _: Self::OutputStream) [INFO] [stdout] | ______________^ [INFO] [stdout] 145 | | -> Result<(), Self::ErrorKind> [INFO] [stdout] 146 | | { [INFO] [stdout] 147 | | Ok(()) [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-proxies` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "72daa8ba0e85e95ea2b7f7c4521ae7a3a78c165ded044aecd07a5c7a80d1b7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72daa8ba0e85e95ea2b7f7c4521ae7a3a78c165ded044aecd07a5c7a80d1b7f8", kill_on_drop: false }` [INFO] [stdout] 72daa8ba0e85e95ea2b7f7c4521ae7a3a78c165ded044aecd07a5c7a80d1b7f8