[INFO] fetching crate async-observable 0.4.2... [INFO] checking async-observable-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-observable 0.4.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate async-observable 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-observable 0.4.2 [INFO] finished tweaking crates.io crate async-observable 0.4.2 [INFO] tweaked toml for crates.io crate async-observable 0.4.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate async-observable 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3292890aa088c222536b4e5ccccbad1a79db03b318c734cef1687be1a408b2bb [INFO] running `Command { std: "docker" "start" "-a" "3292890aa088c222536b4e5ccccbad1a79db03b318c734cef1687be1a408b2bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3292890aa088c222536b4e5ccccbad1a79db03b318c734cef1687be1a408b2bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3292890aa088c222536b4e5ccccbad1a79db03b318c734cef1687be1a408b2bb", kill_on_drop: false }` [INFO] [stdout] 3292890aa088c222536b4e5ccccbad1a79db03b318c734cef1687be1a408b2bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b77a61fbcbc9be642b39f5ca4c78463a803484b3c41a3a1b3d575a086549e8c [INFO] running `Command { std: "docker" "start" "-a" "4b77a61fbcbc9be642b39f5ca4c78463a803484b3c41a3a1b3d575a086549e8c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking value-bag v1.8.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.2.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking async-executor v1.9.1 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking polling v3.6.0 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking async-observable v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Observable { [INFO] [stdout] 123 | inner: Arc::new(Mutex::new(Inner::new(value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn modify_conditional(&mut self, condition: C, modify: M) -> bool [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | self.apply(|value| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 165 | | if condition(value) { [INFO] [stdout] 166 | | modify(value); [INFO] [stdout] 167 | | true [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:10 [INFO] [stdout] | [INFO] [stdout] 347 | pub fn split(self) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | (self.clone(), self) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 371 | pub fn publish_if_changed(&mut self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | self.apply(|v| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | if *v != value { [INFO] [stdout] 374 | | *v = value; [INFO] [stdout] 375 | | true [INFO] [stdout] ... | [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:520:20 [INFO] [stdout] | [INFO] [stdout] 516 | fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | waker: Slab::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-observable` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Observable { [INFO] [stdout] 123 | inner: Arc::new(Mutex::new(Inner::new(value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn modify_conditional(&mut self, condition: C, modify: M) -> bool [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | self.apply(|value| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 165 | | if condition(value) { [INFO] [stdout] 166 | | modify(value); [INFO] [stdout] 167 | | true [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:10 [INFO] [stdout] | [INFO] [stdout] 347 | pub fn split(self) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | (self.clone(), self) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 371 | pub fn publish_if_changed(&mut self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | self.apply(|v| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | if *v != value { [INFO] [stdout] 374 | | *v = value; [INFO] [stdout] 375 | | true [INFO] [stdout] ... | [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:520:20 [INFO] [stdout] | [INFO] [stdout] 516 | fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | waker: Slab::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-observable` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "4b77a61fbcbc9be642b39f5ca4c78463a803484b3c41a3a1b3d575a086549e8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b77a61fbcbc9be642b39f5ca4c78463a803484b3c41a3a1b3d575a086549e8c", kill_on_drop: false }` [INFO] [stdout] 4b77a61fbcbc9be642b39f5ca4c78463a803484b3c41a3a1b3d575a086549e8c