[INFO] fetching crate async-minecraft-ping 0.8.0... [INFO] checking async-minecraft-ping-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-minecraft-ping 0.8.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate async-minecraft-ping 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-minecraft-ping 0.8.0 [INFO] finished tweaking crates.io crate async-minecraft-ping 0.8.0 [INFO] tweaked toml for crates.io crate async-minecraft-ping 0.8.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate async-minecraft-ping 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3e5fc88d800e12980202111154cf6828e458ecbe56801781b35890a4e26aadb [INFO] running `Command { std: "docker" "start" "-a" "b3e5fc88d800e12980202111154cf6828e458ecbe56801781b35890a4e26aadb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3e5fc88d800e12980202111154cf6828e458ecbe56801781b35890a4e26aadb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3e5fc88d800e12980202111154cf6828e458ecbe56801781b35890a4e26aadb", kill_on_drop: false }` [INFO] [stdout] b3e5fc88d800e12980202111154cf6828e458ecbe56801781b35890a4e26aadb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c8549718d41ac76e742be4ff9180cff80a2ae568543f56c0c6ae12ff5ae896f [INFO] running `Command { std: "docker" "start" "-a" "1c8549718d41ac76e742be4ff9180cff80a2ae568543f56c0c6ae12ff5ae896f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.35 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking async-minecraft-ping v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `packet_id` is never read [INFO] [stdout] --> src/protocol.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 350 | pub struct ResponsePacket { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 351 | pub packet_id: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `packet_id` is never read [INFO] [stdout] --> src/protocol.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 403 | pub struct PongPacket { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 404 | pub packet_id: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `protocol_version`, `address`, and `port` are never read [INFO] [stdout] --> src/server.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 223 | pub struct PingConnection { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 224 | stream: TcpStream, [INFO] [stdout] 225 | protocol_version: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 226 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 227 | port: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:253:36 [INFO] [stdout] | [INFO] [stdout] 252 | packet: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | ) -> Result<(), ProtocolError> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 254 | | let packet_buffer = packet.write_to_buffer().await?; [INFO] [stdout] 255 | | [INFO] [stdout] 256 | | let raw_packet = RawPacket::new(packet.get_packet_id(), packet_buffer.into_boxed_slice()); [INFO] [stdout] ... | [INFO] [stdout] 266 | | Ok(()) [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:273:36 [INFO] [stdout] | [INFO] [stdout] 271 | packet: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | timeout: Duration, [INFO] [stdout] 273 | ) -> Result<(), ProtocolError> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 274 | | tokio::time::timeout(timeout, self.write_packet(packet)).await? [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-minecraft-ping` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `packet_id` is never read [INFO] [stdout] --> src/protocol.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 350 | pub struct ResponsePacket { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 351 | pub packet_id: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `packet_id` is never read [INFO] [stdout] --> src/protocol.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 403 | pub struct PongPacket { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 404 | pub packet_id: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `protocol_version`, `address`, and `port` are never read [INFO] [stdout] --> src/server.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 223 | pub struct PingConnection { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 224 | stream: TcpStream, [INFO] [stdout] 225 | protocol_version: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 226 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 227 | port: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:253:36 [INFO] [stdout] | [INFO] [stdout] 252 | packet: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | ) -> Result<(), ProtocolError> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 254 | | let packet_buffer = packet.write_to_buffer().await?; [INFO] [stdout] 255 | | [INFO] [stdout] 256 | | let raw_packet = RawPacket::new(packet.get_packet_id(), packet_buffer.into_boxed_slice()); [INFO] [stdout] ... | [INFO] [stdout] 266 | | Ok(()) [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:273:36 [INFO] [stdout] | [INFO] [stdout] 271 | packet: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | timeout: Duration, [INFO] [stdout] 273 | ) -> Result<(), ProtocolError> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 274 | | tokio::time::timeout(timeout, self.write_packet(packet)).await? [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-minecraft-ping` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c8549718d41ac76e742be4ff9180cff80a2ae568543f56c0c6ae12ff5ae896f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c8549718d41ac76e742be4ff9180cff80a2ae568543f56c0c6ae12ff5ae896f", kill_on_drop: false }` [INFO] [stdout] 1c8549718d41ac76e742be4ff9180cff80a2ae568543f56c0c6ae12ff5ae896f