[INFO] fetching crate async-global-executor 2.4.1... [INFO] checking async-global-executor-2.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-global-executor 2.4.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate async-global-executor 2.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-global-executor 2.4.1 [INFO] finished tweaking crates.io crate async-global-executor 2.4.1 [INFO] tweaked toml for crates.io crate async-global-executor 2.4.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio v0.3.7 (latest: v1.40.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06aee85ce8393f98906d2071bbd74136a3a4fb7360e9037462659af912cb56a8 [INFO] running `Command { std: "docker" "start" "-a" "06aee85ce8393f98906d2071bbd74136a3a4fb7360e9037462659af912cb56a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06aee85ce8393f98906d2071bbd74136a3a4fb7360e9037462659af912cb56a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06aee85ce8393f98906d2071bbd74136a3a4fb7360e9037462659af912cb56a8", kill_on_drop: false }` [INFO] [stdout] 06aee85ce8393f98906d2071bbd74136a3a4fb7360e9037462659af912cb56a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 057e94f7205b1ba38252fa690a740fd78ccc47d42583c844807f7dfc151f18b7 [INFO] running `Command { std: "docker" "start" "-a" "057e94f7205b1ba38252fa690a740fd78ccc47d42583c844807f7dfc151f18b7", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-global-executor v2.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 62 | pub(crate) fn seal(self) -> Config { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | thread_name_fn: self.thread_name_fn.unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 74 | | Box::new(|| { [INFO] [stdout] 75 | | static GLOBAL_EXECUTOR_NEXT_THREAD: AtomicUsize = AtomicUsize::new(1); [INFO] [stdout] 76 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 80 | | }) [INFO] [stdout] 81 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:67:32 [INFO] [stdout] | [INFO] [stdout] 67 | .unwrap_or_else(|| std::thread::available_parallelism().map_or(1, usize::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn block_on, T>(future: F) -> T { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | LOCAL_EXECUTOR.with(|executor| crate::reactor::block_on(executor.run(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:26:61 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn block_on, T>(future: F) -> T { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | LOCAL_EXECUTOR.with(|executor| crate::reactor::block_on(executor.run(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn spawn + Send + 'static, T: Send + 'static>(future: F) -> Task { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | crate::init(); [INFO] [stdout] 50 | GLOBAL_EXECUTOR.spawn(future) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn spawn_local + 'static, T: 'static>(future: F) -> Task { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | LOCAL_EXECUTOR.with(|executor| executor.spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:83:49 [INFO] [stdout] | [INFO] [stdout] 80 | let (s, r) = async_channel::bounded(1); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | // This wil be used to ack once shutdown is complete. [INFO] [stdout] 82 | let (s_ack, r_ack) = async_channel::bounded(1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | THREAD_SHUTDOWN.with(|thread_shutdown| drop(thread_shutdown.set((s, r_ack)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 62 | pub(crate) fn seal(self) -> Config { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | thread_name_fn: self.thread_name_fn.unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 74 | | Box::new(|| { [INFO] [stdout] 75 | | static GLOBAL_EXECUTOR_NEXT_THREAD: AtomicUsize = AtomicUsize::new(1); [INFO] [stdout] 76 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 80 | | }) [INFO] [stdout] 81 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:67:32 [INFO] [stdout] | [INFO] [stdout] 67 | .unwrap_or_else(|| std::thread::available_parallelism().map_or(1, usize::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn block_on, T>(future: F) -> T { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | LOCAL_EXECUTOR.with(|executor| crate::reactor::block_on(executor.run(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:26:61 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn block_on, T>(future: F) -> T { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | LOCAL_EXECUTOR.with(|executor| crate::reactor::block_on(executor.run(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn spawn + Send + 'static, T: Send + 'static>(future: F) -> Task { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | crate::init(); [INFO] [stdout] 50 | GLOBAL_EXECUTOR.spawn(future) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn spawn_local + 'static, T: 'static>(future: F) -> Task { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | LOCAL_EXECUTOR.with(|executor| executor.spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:83:49 [INFO] [stdout] | [INFO] [stdout] 80 | let (s, r) = async_channel::bounded(1); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | // This wil be used to ack once shutdown is complete. [INFO] [stdout] 82 | let (s_ack, r_ack) = async_channel::bounded(1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | THREAD_SHUTDOWN.with(|thread_shutdown| drop(thread_shutdown.set((s, r_ack)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-global-executor` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-global-executor` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "057e94f7205b1ba38252fa690a740fd78ccc47d42583c844807f7dfc151f18b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "057e94f7205b1ba38252fa690a740fd78ccc47d42583c844807f7dfc151f18b7", kill_on_drop: false }` [INFO] [stdout] 057e94f7205b1ba38252fa690a740fd78ccc47d42583c844807f7dfc151f18b7