[INFO] fetching crate async-filedb 0.3.7... [INFO] checking async-filedb-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-filedb 0.3.7 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate async-filedb 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-filedb 0.3.7 [INFO] finished tweaking crates.io crate async-filedb 0.3.7 [INFO] tweaked toml for crates.io crate async-filedb 0.3.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba6fe61d9b022c756b09cabe83e517820dbbfa69ec9d6afcdfd57fbb46a46b2a [INFO] running `Command { std: "docker" "start" "-a" "ba6fe61d9b022c756b09cabe83e517820dbbfa69ec9d6afcdfd57fbb46a46b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba6fe61d9b022c756b09cabe83e517820dbbfa69ec9d6afcdfd57fbb46a46b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba6fe61d9b022c756b09cabe83e517820dbbfa69ec9d6afcdfd57fbb46a46b2a", kill_on_drop: false }` [INFO] [stdout] ba6fe61d9b022c756b09cabe83e517820dbbfa69ec9d6afcdfd57fbb46a46b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4056546c1142623e54e39ea4a7e9d780b99be4f3f3ca7b3177eee10257a8d443 [INFO] running `Command { std: "docker" "start" "-a" "4056546c1142623e54e39ea4a7e9d780b99be4f3f3ca7b3177eee10257a8d443", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-kvdb v0.3.1 [INFO] [stderr] Checking async-memorydb v0.3.2 [INFO] [stderr] Checking async-filedb v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 82 | let mut mem = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let (tx, receiver) = mpsc::unbounded(); [INFO] [stdout] | -- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | mem: MenoryDb::new(mem), [INFO] [stdout] 126 | | write_ch: tx, [INFO] [stdout] 127 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:52 [INFO] [stdout] | [INFO] [stdout] 136 | async fn get(&self, key: Key) -> Option { [INFO] [stdout] | _________________________--------___________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | | self.mem.get(key).await [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:69 [INFO] [stdout] | [INFO] [stdout] 139 | async fn get_many(&self, keys: Vec) -> HashMap { [INFO] [stdout] | ______________________________--------------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | | self.mem.get_many(keys).await [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:49 [INFO] [stdout] | [INFO] [stdout] 142 | async fn set(&self, key: Key, value: Value) { [INFO] [stdout] | _________________________--------__------------__^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | | self.mem.set(key.clone(), value.clone()).await; [INFO] [stdout] 144 | | let _ = self.write_ch.send(DbOp::Insert { key, value }).await; [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:57 [INFO] [stdout] | [INFO] [stdout] 146 | async fn set_many(&self, data: HashMap) { [INFO] [stdout] | ______________________________-------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | | self.mem.set_many(data.clone()).await; [INFO] [stdout] 148 | | let _ = self.write_ch.send(DbOp::InsertMany { data }).await; [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:38 [INFO] [stdout] | [INFO] [stdout] 150 | async fn delete(&self, key: Key) { [INFO] [stdout] | ____________________________--------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | | self.mem.delete(key.clone()).await; [INFO] [stdout] 152 | | let _ = self.write_ch.send(DbOp::Delete { key }).await; [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | async fn delete_many(&self, keys: Vec) { [INFO] [stdout] | _________________________________--------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | | self.mem.delete_many(keys.clone()).await; [INFO] [stdout] 156 | | let _ = self.write_ch.send(DbOp::DeleteMany { keys }).await; [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-filedb` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 82 | let mut mem = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let (tx, receiver) = mpsc::unbounded(); [INFO] [stdout] | -- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | mem: MenoryDb::new(mem), [INFO] [stdout] 126 | | write_ch: tx, [INFO] [stdout] 127 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:52 [INFO] [stdout] | [INFO] [stdout] 136 | async fn get(&self, key: Key) -> Option { [INFO] [stdout] | _________________________--------___________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | | self.mem.get(key).await [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:69 [INFO] [stdout] | [INFO] [stdout] 139 | async fn get_many(&self, keys: Vec) -> HashMap { [INFO] [stdout] | ______________________________--------------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | | self.mem.get_many(keys).await [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:49 [INFO] [stdout] | [INFO] [stdout] 142 | async fn set(&self, key: Key, value: Value) { [INFO] [stdout] | _________________________--------__------------__^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | | self.mem.set(key.clone(), value.clone()).await; [INFO] [stdout] 144 | | let _ = self.write_ch.send(DbOp::Insert { key, value }).await; [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:57 [INFO] [stdout] | [INFO] [stdout] 146 | async fn set_many(&self, data: HashMap) { [INFO] [stdout] | ______________________________-------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | | self.mem.set_many(data.clone()).await; [INFO] [stdout] 148 | | let _ = self.write_ch.send(DbOp::InsertMany { data }).await; [INFO] [stdout] 149 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:38 [INFO] [stdout] | [INFO] [stdout] 150 | async fn delete(&self, key: Key) { [INFO] [stdout] | ____________________________--------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | | self.mem.delete(key.clone()).await; [INFO] [stdout] 152 | | let _ = self.write_ch.send(DbOp::Delete { key }).await; [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | async fn delete_many(&self, keys: Vec) { [INFO] [stdout] | _________________________________--------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | | self.mem.delete_many(keys.clone()).await; [INFO] [stdout] 156 | | let _ = self.write_ch.send(DbOp::DeleteMany { keys }).await; [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-filedb` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4056546c1142623e54e39ea4a7e9d780b99be4f3f3ca7b3177eee10257a8d443", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4056546c1142623e54e39ea4a7e9d780b99be4f3f3ca7b3177eee10257a8d443", kill_on_drop: false }` [INFO] [stdout] 4056546c1142623e54e39ea4a7e9d780b99be4f3f3ca7b3177eee10257a8d443