[INFO] fetching crate async-codec-lite 0.0.2... [INFO] checking async-codec-lite-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-codec-lite 0.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate async-codec-lite 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-codec-lite 0.0.2 [INFO] finished tweaking crates.io crate async-codec-lite 0.0.2 [INFO] tweaked toml for crates.io crate async-codec-lite 0.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 745e6190805c0bf897d06e41c7960f8fd58ba146c41e50e8b4aa1b6524b4119b [INFO] running `Command { std: "docker" "start" "-a" "745e6190805c0bf897d06e41c7960f8fd58ba146c41e50e8b4aa1b6524b4119b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "745e6190805c0bf897d06e41c7960f8fd58ba146c41e50e8b4aa1b6524b4119b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "745e6190805c0bf897d06e41c7960f8fd58ba146c41e50e8b4aa1b6524b4119b", kill_on_drop: false }` [INFO] [stdout] 745e6190805c0bf897d06e41c7960f8fd58ba146c41e50e8b4aa1b6524b4119b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fefcea19d7a2b5519366124045c87ea6c1bfd150354bfd42e8267db15bd004d [INFO] running `Command { std: "docker" "start" "-a" "3fefcea19d7a2b5519366124045c87ea6c1bfd150354bfd42e8267db15bd004d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking async-codec-lite v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Bytes` [INFO] [stdout] --> src/framed/read.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | pub use bytes::{Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BytesMut` and `Bytes` [INFO] [stdout] --> src/framed/write.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | pub use bytes::{Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Bytes` [INFO] [stdout] --> src/framed/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | pub use bytes::{Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/limit.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(inner: C, max_frame_size: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | skip_ahead_state: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(inner: T, codec: U) -> Framed { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Framed { [INFO] [stdout] 33 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 34 | | inner, [INFO] [stdout] 35 | | codec, [INFO] [stdout] 36 | | state: Default::default(), [INFO] [stdout] 37 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/mod.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn with_capacity(inner: T, codec: U, capacity: usize) -> Framed { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Framed { [INFO] [stdout] 43 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 44 | | inner, [INFO] [stdout] 45 | | codec, [INFO] [stdout] 46 | | state: RWFrames { [INFO] [stdout] ... | [INFO] [stdout] 54 | | }, [INFO] [stdout] 55 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/mod.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn from_parts(parts: FramedParts) -> Framed { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Framed { [INFO] [stdout] 61 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 62 | | inner: parts.io, [INFO] [stdout] 63 | | codec: parts.codec, [INFO] [stdout] 64 | | state: RWFrames { [INFO] [stdout] ... | [INFO] [stdout] 67 | | }, [INFO] [stdout] 68 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/mod.rs:182:23 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(io: T, codec: U) -> FramedParts [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | read_buf: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/mod.rs:183:24 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(io: T, codec: U) -> FramedParts [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | write_buf: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/inner.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 172 | fn start_send(self: Pin<&mut Self>, item: U::Item) -> Result<(), Self::Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let pinned = self.project(); [INFO] [stdout] 174 | / pinned [INFO] [stdout] 175 | | .codec [INFO] [stdout] 176 | | .encode(item, &mut pinned.state.borrow_mut().buffer) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/read.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(inner: T, decoder: D) -> FramedRead { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | FramedRead { [INFO] [stdout] 28 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 29 | | inner, [INFO] [stdout] 30 | | codec: decoder, [INFO] [stdout] 31 | | state: Default::default(), [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/read.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn with_capacity(inner: T, decoder: D, capacity: usize) -> FramedRead { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | FramedRead { [INFO] [stdout] 38 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 39 | | inner, [INFO] [stdout] 40 | | codec: decoder, [INFO] [stdout] 41 | | state: ReadFrame { [INFO] [stdout] ... | [INFO] [stdout] 46 | | }, [INFO] [stdout] 47 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/write.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(inner: T, encoder: E) -> FramedWrite { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | FramedWrite { [INFO] [stdout] 27 | inner: FramedInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | inner, [INFO] [stdout] 29 | | codec: encoder, [INFO] [stdout] 30 | | state: WriteFrame::default(), [INFO] [stdout] 31 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-codec-lite` (lib) due to 11 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3fefcea19d7a2b5519366124045c87ea6c1bfd150354bfd42e8267db15bd004d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fefcea19d7a2b5519366124045c87ea6c1bfd150354bfd42e8267db15bd004d", kill_on_drop: false }` [INFO] [stdout] 3fefcea19d7a2b5519366124045c87ea6c1bfd150354bfd42e8267db15bd004d