[INFO] fetching crate async-cmd 0.1.1... [INFO] checking async-cmd-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate async-cmd 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate async-cmd 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-cmd 0.1.1 [INFO] finished tweaking crates.io crate async-cmd 0.1.1 [INFO] tweaked toml for crates.io crate async-cmd 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding structopt v0.2.18 (latest: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.2.18 (latest: v0.4.18) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1849bb6ad70c586e9a4e329a99a2f21074078ca4fa5dc18c0df5b9846ce84d1b [INFO] running `Command { std: "docker" "start" "-a" "1849bb6ad70c586e9a4e329a99a2f21074078ca4fa5dc18c0df5b9846ce84d1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1849bb6ad70c586e9a4e329a99a2f21074078ca4fa5dc18c0df5b9846ce84d1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1849bb6ad70c586e9a4e329a99a2f21074078ca4fa5dc18c0df5b9846ce84d1b", kill_on_drop: false }` [INFO] [stdout] 1849bb6ad70c586e9a4e329a99a2f21074078ca4fa5dc18c0df5b9846ce84d1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 436f53f198f58c2e8f38b70e587e2da0154b42dc6133ea3b2e6076103dbb4537 [INFO] running `Command { std: "docker" "start" "-a" "436f53f198f58c2e8f38b70e587e2da0154b42dc6133ea3b2e6076103dbb4537", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking async-cmd v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comm.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 169 | fn to_task_results_ser(results: exec::TaskResults) -> TaskResultsSer { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | / results [INFO] [stdout] 171 | | .into_iter() [INFO] [stdout] 172 | | .map(|(op, result)| match result { [INFO] [stdout] 173 | | Ok(exit_status) => (op, Ok(exit_status.code())), [INFO] [stdout] 174 | | Err(err) => (op, Err(format!("{}", err))), [INFO] [stdout] 175 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 22 | fn with_context(self, context: S) -> Result [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | self.map_err(|e| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 27 | | let mut err = e.into(); [INFO] [stdout] 28 | | err.context = Some(context.into()); [INFO] [stdout] 29 | | return err; [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | fn with_cause(cause: Cause) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn with_context(context: S) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | cause: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 99 | fn from(err: io::Error) -> Error { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Error::with_cause(Cause::Io(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 105 | fn from(err: bincode::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Error::with_cause(Cause::Serde(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-cmd` (bin "async") due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comm.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 169 | fn to_task_results_ser(results: exec::TaskResults) -> TaskResultsSer { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | / results [INFO] [stdout] 171 | | .into_iter() [INFO] [stdout] 172 | | .map(|(op, result)| match result { [INFO] [stdout] 173 | | Ok(exit_status) => (op, Ok(exit_status.code())), [INFO] [stdout] 174 | | Err(err) => (op, Err(format!("{}", err))), [INFO] [stdout] 175 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 22 | fn with_context(self, context: S) -> Result [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | self.map_err(|e| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 27 | | let mut err = e.into(); [INFO] [stdout] 28 | | err.context = Some(context.into()); [INFO] [stdout] 29 | | return err; [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | fn with_cause(cause: Cause) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn with_context(context: S) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | cause: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 99 | fn from(err: io::Error) -> Error { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Error::with_cause(Cause::Io(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 105 | fn from(err: bincode::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Error::with_cause(Cause::Serde(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-cmd` (bin "async" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "436f53f198f58c2e8f38b70e587e2da0154b42dc6133ea3b2e6076103dbb4537", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "436f53f198f58c2e8f38b70e587e2da0154b42dc6133ea3b2e6076103dbb4537", kill_on_drop: false }` [INFO] [stdout] 436f53f198f58c2e8f38b70e587e2da0154b42dc6133ea3b2e6076103dbb4537