[INFO] fetching crate astrology 3.0.3... [INFO] checking astrology-3.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate astrology 3.0.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate astrology 3.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate astrology 3.0.3 [INFO] finished tweaking crates.io crate astrology 3.0.3 [INFO] tweaked toml for crates.io crate astrology 3.0.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate astrology 3.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5b814237e70f05bf083f18e12952b087def9cb880cdbb70e63f1821498b26cd [INFO] running `Command { std: "docker" "start" "-a" "f5b814237e70f05bf083f18e12952b087def9cb880cdbb70e63f1821498b26cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5b814237e70f05bf083f18e12952b087def9cb880cdbb70e63f1821498b26cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5b814237e70f05bf083f18e12952b087def9cb880cdbb70e63f1821498b26cd", kill_on_drop: false }` [INFO] [stdout] f5b814237e70f05bf083f18e12952b087def9cb880cdbb70e63f1821498b26cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b78153f095dda0dcbd54d7b7e238b9f83ce17c1dcf7dacf7cc1dd5f32d0a226c [INFO] running `Command { std: "docker" "start" "-a" "b78153f095dda0dcbd54d7b7e238b9f83ce17c1dcf7dacf7cc1dd5f32d0a226c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.108 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.71 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strum v0.17.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking svg v0.6.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking libmath v0.2.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling libswe-sys v0.2.7 [INFO] [stderr] Compiling strum_macros v0.17.1 [INFO] [stderr] Checking astrology v3.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/cfg/parse.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | let items: Vec<_> = time.clone().split(&[':'][..]).collect(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_draw/compute_chart.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Serialize, Deserialize, Clone, PartialEq, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg_draw/compute_chart.rs:1054:25 [INFO] [stdout] | [INFO] [stdout] 1054 | Some(x) => x.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `DataChartNatal` does not implement `Clone`, so calling `clone` on `&DataChartNatal` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 1054 - Some(x) => x.clone(), [INFO] [stdout] 1054 + Some(x) => x, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `DataChartNatal`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct DataChartNatal { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `astrology` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/cfg/parse.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | let items: Vec<_> = time.clone().split(&[':'][..]).collect(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_draw/compute_chart.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Serialize, Deserialize, Clone, PartialEq, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg_draw/compute_chart.rs:1054:25 [INFO] [stdout] | [INFO] [stdout] 1054 | Some(x) => x.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `DataChartNatal` does not implement `Clone`, so calling `clone` on `&DataChartNatal` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 1054 - Some(x) => x.clone(), [INFO] [stdout] 1054 + Some(x) => x, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `DataChartNatal`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub struct DataChartNatal { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `astrology` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b78153f095dda0dcbd54d7b7e238b9f83ce17c1dcf7dacf7cc1dd5f32d0a226c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b78153f095dda0dcbd54d7b7e238b9f83ce17c1dcf7dacf7cc1dd5f32d0a226c", kill_on_drop: false }` [INFO] [stdout] b78153f095dda0dcbd54d7b7e238b9f83ce17c1dcf7dacf7cc1dd5f32d0a226c