[INFO] fetching crate assembly-data 0.3.0... [INFO] checking assembly-data-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate assembly-data 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate assembly-data 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate assembly-data 0.3.0 [INFO] finished tweaking crates.io crate assembly-data 0.3.0 [INFO] tweaked toml for crates.io crate assembly-data 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate assembly-data 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0a96c8371f3eeb5d498d411f2c85256502608e7c58dfbfcdeebc0eb42c7e9a2 [INFO] running `Command { std: "docker" "start" "-a" "b0a96c8371f3eeb5d498d411f2c85256502608e7c58dfbfcdeebc0eb42c7e9a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0a96c8371f3eeb5d498d411f2c85256502608e7c58dfbfcdeebc0eb42c7e9a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0a96c8371f3eeb5d498d411f2c85256502608e7c58dfbfcdeebc0eb42c7e9a2", kill_on_drop: false }` [INFO] [stdout] b0a96c8371f3eeb5d498d411f2c85256502608e7c58dfbfcdeebc0eb42c7e9a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0141886b1bde0fa1c1fb403fcaeacafe3a78b3a76334632c69da6e71b08c749f [INFO] running `Command { std: "docker" "start" "-a" "0141886b1bde0fa1c1fb403fcaeacafe3a78b3a76334632c69da6e71b08c749f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.20 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling eyre v0.6.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking gimli v0.25.0 [INFO] [stderr] Checking tracing-subscriber v0.2.21 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling libsqlite3-sys v0.17.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling backtrace v0.3.61 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking hsieh-hash v0.1.1 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking mapr v0.8.0 [INFO] [stderr] Checking addr2line v0.16.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling displaydoc v0.1.7 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling bytemuck_derive v1.0.1 [INFO] [stderr] Compiling structopt-derive v0.4.16 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking assembly-core v0.2.1 [INFO] [stderr] Checking structopt v0.3.23 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking rusqlite v0.21.0 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking quick-xml v0.20.0 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking assembly-data v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/mod.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new_arc(inner: B) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self::new(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/mod.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 172 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | mapper: impl Fn(Buffer<'a>, T) -> Result, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ) -> Result, E> { [INFO] [stdout] 175 | let raw = mapper(self.mem, self.raw)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Handle { mem: self.mem, raw }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/handle.rs:98:15 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn map_into(self, map: M) -> BaseResult [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | match map(self.mem.deref().as_ref(), self.raw) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/store/mod.rs:207:27 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn push_column(&mut self, name: S, data_type: ValueType) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | self.columns.push(Column { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 208 | | data_type, [INFO] [stdout] 209 | | name: name.into(), [INFO] [stdout] 210 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml/localization.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 29 | fn from(e: XmlError) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Self::Xml(Error::Xml(e)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `assembly-data` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/mod.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new_arc(inner: B) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self::new(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/mod.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 172 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | mapper: impl Fn(Buffer<'a>, T) -> Result, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ) -> Result, E> { [INFO] [stdout] 175 | let raw = mapper(self.mem, self.raw)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Handle { mem: self.mem, raw }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/ro/handle.rs:98:15 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn map_into(self, map: M) -> BaseResult [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | match map(self.mem.deref().as_ref(), self.raw) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fdb/store/mod.rs:207:27 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn push_column(&mut self, name: S, data_type: ValueType) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | self.columns.push(Column { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 208 | | data_type, [INFO] [stdout] 209 | | name: name.into(), [INFO] [stdout] 210 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml/localization.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 29 | fn from(e: XmlError) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Self::Xml(Error::Xml(e)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `assembly-data` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "0141886b1bde0fa1c1fb403fcaeacafe3a78b3a76334632c69da6e71b08c749f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0141886b1bde0fa1c1fb403fcaeacafe3a78b3a76334632c69da6e71b08c749f", kill_on_drop: false }` [INFO] [stdout] 0141886b1bde0fa1c1fb403fcaeacafe3a78b3a76334632c69da6e71b08c749f