[INFO] fetching crate askar-crypto 0.3.1... [INFO] checking askar-crypto-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate askar-crypto 0.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate askar-crypto 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate askar-crypto 0.3.1 [INFO] finished tweaking crates.io crate askar-crypto 0.3.1 [INFO] tweaked toml for crates.io crate askar-crypto 0.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 146 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding serde-json-core v0.5.1 (latest: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 785097f3b84226b05135c4c8532b448379420d83b31fe1df15ea42416570669c [INFO] running `Command { std: "docker" "start" "-a" "785097f3b84226b05135c4c8532b448379420d83b31fe1df15ea42416570669c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "785097f3b84226b05135c4c8532b448379420d83b31fe1df15ea42416570669c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "785097f3b84226b05135c4c8532b448379420d83b31fe1df15ea42416570669c", kill_on_drop: false }` [INFO] [stdout] 785097f3b84226b05135c4c8532b448379420d83b31fe1df15ea42416570669c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3053818f4111035e1ca528d44fb7b564cbc0ea9b58178aa9e379629e83b1f42a [INFO] running `Command { std: "docker" "start" "-a" "3053818f4111035e1ca528d44fb7b564cbc0ea9b58178aa9e379629e83b1f42a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking block-modes v0.9.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking bls12_381 v0.8.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking crypto_secretbox v0.1.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking crypto_box v0.9.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking serde-json-core v0.5.1 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking askar-crypto v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/alg/k256.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 129 | if let Ok(key) = key.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/alg/p256.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | if let Ok(key) = key.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/alg/p384.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 131 | if let Ok(key) = key.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/any.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 136 | fn from_key(key: K) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Box::new(KeyT(key)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/any.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 171 | fn from_key(key: K) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Arc::new(KeyT(key)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/aes/mod.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 94 | fn generate(rng: impl KeyMaterial) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok(AesKey(KeyType::::generate(rng))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/aes/mod.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_key_derivation(mut derive: D) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(Self(KeyType::::try_new_with(|arr| { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | derive.derive_key_bytes(arr) [INFO] [stdout] 119 | | })?)) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/bls.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) fn from_secret_key(sk: BlsSecretKey) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let public = Pk::from_secret_scalar(&sk.0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self { [INFO] [stdout] 52 | secret: Some(sk), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/bls.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 115 | fn generate(rng: impl KeyMaterial) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let secret = BlsSecretKey::generate(rng)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Ok(Self::from_secret_key(secret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/bls.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 126 | let sk = BlsSecretKey::from_bytes(key)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(Self::from_secret_key(sk)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/bls.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 214 | fn generate(mut rng: impl KeyMaterial) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let mut secret = Zeroizing::new([0u8; 64]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(Self(Scalar::from_bytes_wide(&secret))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/bls.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 225 | let mut skb = Zeroizing::new([0u8; 32]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Self(result.ok_or_else(|| err_msg!(InvalidKeyData))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/chacha20.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | fn generate(rng: impl KeyMaterial) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Chacha20Key(KeyType::::generate(rng))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/chacha20.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 138 | fn from_key_derivation(mut derive: D) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Ok(Self(KeyType::::try_new_with(|arr| { [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | derive.derive_key_bytes(arr) [INFO] [stdout] 144 | | })?)) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/ed25519.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|sk| Ed25519SigningKey(SigningKey::from(sk))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/ed25519.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 121 | fn generate(rng: impl KeyMaterial) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let sk = ArrayKey::::generate(rng); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Ok(Self::from_secret_key((&sk).try_into().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/x25519.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) fn from_secret_key(sk: SecretKey) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | secret: Some(sk), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/x25519.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 101 | fn generate(rng: impl KeyMaterial) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let sk = ArrayKey::::generate(rng); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let sk = SecretKey::from(*<&[u8; SECRET_KEY_LENGTH]>::try_from(&sk).unwrap()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let pk = PublicKey::from(&sk); [INFO] [stdout] 105 | Ok(Self::new(Some(sk), pk)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/k256.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) fn from_secret_key(sk: SecretKey) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | secret: Some(sk), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/p256.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) fn from_secret_key(sk: SecretKey) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | secret: Some(sk), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alg/p384.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) fn from_secret_key(sk: SecretKey) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | secret: Some(sk), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `askar-crypto` (lib) due to 19 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3053818f4111035e1ca528d44fb7b564cbc0ea9b58178aa9e379629e83b1f42a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3053818f4111035e1ca528d44fb7b564cbc0ea9b58178aa9e379629e83b1f42a", kill_on_drop: false }` [INFO] [stdout] 3053818f4111035e1ca528d44fb7b564cbc0ea9b58178aa9e379629e83b1f42a