[INFO] fetching crate asciigraph 0.10.0... [INFO] checking asciigraph-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate asciigraph 0.10.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate asciigraph 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate asciigraph 0.10.0 [INFO] finished tweaking crates.io crate asciigraph 0.10.0 [INFO] tweaked toml for crates.io crate asciigraph 0.10.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate asciigraph 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8aabdb521da50eed4fdbbeaf7c9b784356831f79683c629d90b563144872857 [INFO] running `Command { std: "docker" "start" "-a" "b8aabdb521da50eed4fdbbeaf7c9b784356831f79683c629d90b563144872857", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8aabdb521da50eed4fdbbeaf7c9b784356831f79683c629d90b563144872857", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8aabdb521da50eed4fdbbeaf7c9b784356831f79683c629d90b563144872857", kill_on_drop: false }` [INFO] [stdout] b8aabdb521da50eed4fdbbeaf7c9b784356831f79683c629d90b563144872857 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7797782d5e5e5b543e44a2ac15e02f14d824688b1731c96acc82b337f3de5a2b [INFO] running `Command { std: "docker" "start" "-a" "7797782d5e5e5b543e44a2ac15e02f14d824688b1731c96acc82b337f3de5a2b", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hmath v0.1.17 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking asciibox v0.1.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.10 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking clap v4.5.10 [INFO] [stderr] Checking asciigraph v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `is_valid` is never used [INFO] [stdout] --> src/lines.rs:511:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Lines { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 511 | pub fn is_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Table` is never constructed [INFO] [stdout] --> src/table.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `draw` and `get_rect` are never used [INFO] [stdout] --> src/table.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Table { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 23 | // it's a bit inefficient, but I cannot think of any better implementation... [INFO] [stdout] 24 | pub fn draw(&self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | fn get_rect(&self, col: usize, row: usize) -> (usize, usize, usize, usize) { // (x, y, w, h) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cell` is never constructed [INFO] [stdout] --> src/table.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 224 | pub struct Cell { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cell` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:166:95 [INFO] [stdout] | [INFO] [stdout] 166 | ... let data: Vec<(String, Ratio)> = data.iter().enumerate().map(|(i, n)| (i.to_string(), n.clone().try_into().unwrap_or(Ratio::zero())... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:178:91 [INFO] [stdout] | [INFO] [stdout] 178 | ... let data: Vec<(String, Ratio)> = data.iter().map(|(label, n)| (label.to_string(), n.clone().try_into().unwrap_or(Ratio::zero()))).c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:322:26 [INFO] [stdout] | [INFO] [stdout] 322 | from.map(|n| n.clone().try_into().unwrap_or(Ratio::zero())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | to.map(|n| n.clone().try_into().unwrap_or(Ratio::zero())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asciigraph` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `Table` is never constructed [INFO] [stdout] --> src/table.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `draw` and `get_rect` are never used [INFO] [stdout] --> src/table.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Table { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 23 | // it's a bit inefficient, but I cannot think of any better implementation... [INFO] [stdout] 24 | pub fn draw(&self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | fn get_rect(&self, col: usize, row: usize) -> (usize, usize, usize, usize) { // (x, y, w, h) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cell` is never constructed [INFO] [stdout] --> src/table.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 224 | pub struct Cell { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cell` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:166:95 [INFO] [stdout] | [INFO] [stdout] 166 | ... let data: Vec<(String, Ratio)> = data.iter().enumerate().map(|(i, n)| (i.to_string(), n.clone().try_into().unwrap_or(Ratio::zero())... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:178:91 [INFO] [stdout] | [INFO] [stdout] 178 | ... let data: Vec<(String, Ratio)> = data.iter().map(|(label, n)| (label.to_string(), n.clone().try_into().unwrap_or(Ratio::zero()))).c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:322:26 [INFO] [stdout] | [INFO] [stdout] 322 | from.map(|n| n.clone().try_into().unwrap_or(Ratio::zero())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/setters.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | to.map(|n| n.clone().try_into().unwrap_or(Ratio::zero())), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asciigraph` (lib) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7797782d5e5e5b543e44a2ac15e02f14d824688b1731c96acc82b337f3de5a2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7797782d5e5e5b543e44a2ac15e02f14d824688b1731c96acc82b337f3de5a2b", kill_on_drop: false }` [INFO] [stdout] 7797782d5e5e5b543e44a2ac15e02f14d824688b1731c96acc82b337f3de5a2b