[INFO] fetching crate asar_rs 0.2.0... [INFO] checking asar_rs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate asar_rs 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate asar_rs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate asar_rs 0.2.0 [INFO] finished tweaking crates.io crate asar_rs 0.2.0 [INFO] tweaked toml for crates.io crate asar_rs 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate asar_rs 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ecfb2cc7ffd30198b03da4de01734b27bdf501eda396d68c291dd6de7f4fd397 [INFO] running `Command { std: "docker" "start" "-a" "ecfb2cc7ffd30198b03da4de01734b27bdf501eda396d68c291dd6de7f4fd397", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ecfb2cc7ffd30198b03da4de01734b27bdf501eda396d68c291dd6de7f4fd397", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecfb2cc7ffd30198b03da4de01734b27bdf501eda396d68c291dd6de7f4fd397", kill_on_drop: false }` [INFO] [stdout] ecfb2cc7ffd30198b03da4de01734b27bdf501eda396d68c291dd6de7f4fd397 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2201a2dfc3bdbb50e4d240517abf3c4e0154bed8078b5fdc80a12faf555756d1 [INFO] running `Command { std: "docker" "start" "-a" "2201a2dfc3bdbb50e4d240517abf3c4e0154bed8078b5fdc80a12faf555756d1", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling serde v1.0.176 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Compiling serde_derive v1.0.176 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking path-dedot v3.1.0 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking aho-corasick v1.0.3 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Checking path-absolutize v3.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking chromium_pickle v0.1.0 [INFO] [stderr] Checking pathdiff v0.1.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.7.1 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking asar_rs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asar.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn open>(archive: T) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let (_, header, header_size, fd) = read_archive_header(&archive)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(AsarFile { fd, filesystem }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asar.rs:110:41 [INFO] [stdout] | [INFO] [stdout] 110 | .ok_or_else(|| Error::new(ErrorKind::UnknownOffset(filename.to_owned())))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asar.rs:151:37 [INFO] [stdout] | [INFO] [stdout] 151 | .ok_or_else(|| Error::new(ErrorKind::UnknownOffset(filename.to_owned())))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk.rs:29:6 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn read_archive_header>(archive: T) -> Result<(String, Node, usize, File)> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut fd = File::open(archive)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok((header, json_value, size, fd)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | .map_err(|_| Error::new(ErrorKind::InvalidHeaderSize))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | .map_err(|_| Error::new(ErrorKind::InvalidHeader))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 189 | pub(crate) fn new(kind: ErrorKind) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Error { [INFO] [stdout] 191 | repr: Box::new(ErrorImpl { kind }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:243:16 [INFO] [stdout] | [INFO] [stdout] 242 | fn from(value: GlobError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | Error::new(ErrorKind::Glob(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:249:16 [INFO] [stdout] | [INFO] [stdout] 248 | fn from(value: io::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Error::new(ErrorKind::Io(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:255:16 [INFO] [stdout] | [INFO] [stdout] 254 | fn from(value: serde_json::Error) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | Error::new(ErrorKind::Json(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | .ok_or_else(|| Error::new(ErrorKind::NoSuchEntry(p.to_owned())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:98:41 [INFO] [stdout] | [INFO] [stdout] 98 | .ok_or_else(|| Error::new(ErrorKind::NoSuchEntry(p.to_owned())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:230:41 [INFO] [stdout] | [INFO] [stdout] 230 | .ok_or_else(|| Error::new(ErrorKind::NoSuchEntry(p.to_owned())))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asar_rs` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2201a2dfc3bdbb50e4d240517abf3c4e0154bed8078b5fdc80a12faf555756d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2201a2dfc3bdbb50e4d240517abf3c4e0154bed8078b5fdc80a12faf555756d1", kill_on_drop: false }` [INFO] [stdout] 2201a2dfc3bdbb50e4d240517abf3c4e0154bed8078b5fdc80a12faf555756d1