[INFO] fetching crate asar-snes 0.1.6... [INFO] checking asar-snes-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate asar-snes 0.1.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate asar-snes 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate asar-snes 0.1.6 [INFO] finished tweaking crates.io crate asar-snes 0.1.6 [INFO] tweaked toml for crates.io crate asar-snes 0.1.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19911b1fcd65d8e10d140be0edc92883d4ff3e291b93c3303bc4d80629da375a [INFO] running `Command { std: "docker" "start" "-a" "19911b1fcd65d8e10d140be0edc92883d4ff3e291b93c3303bc4d80629da375a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19911b1fcd65d8e10d140be0edc92883d4ff3e291b93c3303bc4d80629da375a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19911b1fcd65d8e10d140be0edc92883d4ff3e291b93c3303bc4d80629da375a", kill_on_drop: false }` [INFO] [stdout] 19911b1fcd65d8e10d140be0edc92883d4ff3e291b93c3303bc4d80629da375a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ddb58113c32f198188801760d2cbc5544f521a8d4773d7d82153dded840c0f1 [INFO] running `Command { std: "docker" "start" "-a" "0ddb58113c32f198188801760d2cbc5544f521a8d4773d7d82153dded840c0f1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling asar-snes-proc-macros v0.1.4 [INFO] [stderr] Compiling asar-snes v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:946:12 [INFO] [stdout] | [INFO] [stdout] 934 | patch: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | Ok(ApplyResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 947 | | romdata, [INFO] [stdout] 948 | | success: result, [INFO] [stdout] 949 | | _marker: std::marker::PhantomData, [INFO] [stdout] 950 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:582:22 [INFO] [stdout] | [INFO] [stdout] 582 | .map(|p| CString::new(p.clone()).unwrap().into_raw() as *const i8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:585:63 [INFO] [stdout] | [INFO] [stdout] 585 | let stdincludesfile = options.stdincludesfile.map(|s| CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:586:61 [INFO] [stdout] | [INFO] [stdout] 586 | let stddefinesfile = options.stddefinesfile.map(|s| CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:946:12 [INFO] [stdout] | [INFO] [stdout] 934 | patch: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | Ok(ApplyResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 947 | | romdata, [INFO] [stdout] 948 | | success: result, [INFO] [stdout] 949 | | _marker: std::marker::PhantomData, [INFO] [stdout] 950 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:582:22 [INFO] [stdout] | [INFO] [stdout] 582 | .map(|p| CString::new(p.clone()).unwrap().into_raw() as *const i8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:585:63 [INFO] [stdout] | [INFO] [stdout] 585 | let stdincludesfile = options.stdincludesfile.map(|s| CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:586:61 [INFO] [stdout] | [INFO] [stdout] 586 | let stddefinesfile = options.stddefinesfile.map(|s| CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asar-snes` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `asar-snes` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0ddb58113c32f198188801760d2cbc5544f521a8d4773d7d82153dded840c0f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ddb58113c32f198188801760d2cbc5544f521a8d4773d7d82153dded840c0f1", kill_on_drop: false }` [INFO] [stdout] 0ddb58113c32f198188801760d2cbc5544f521a8d4773d7d82153dded840c0f1