[INFO] fetching crate arsc-rs 0.1.0... [INFO] checking arsc-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arsc-rs 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate arsc-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arsc-rs 0.1.0 [INFO] finished tweaking crates.io crate arsc-rs 0.1.0 [INFO] tweaked toml for crates.io crate arsc-rs 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding memoffset v0.8.0 (latest: v0.9.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 045ba41d2440a012dc481edef879ef8773fc1d883d616f2f910099473e0038bb [INFO] running `Command { std: "docker" "start" "-a" "045ba41d2440a012dc481edef879ef8773fc1d883d616f2f910099473e0038bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "045ba41d2440a012dc481edef879ef8773fc1d883d616f2f910099473e0038bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "045ba41d2440a012dc481edef879ef8773fc1d883d616f2f910099473e0038bb", kill_on_drop: false }` [INFO] [stdout] 045ba41d2440a012dc481edef879ef8773fc1d883d616f2f910099473e0038bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3cee3fa36fa3d96fbfd93f3d4e55b1bf5121ae8a920202810dc063e55592dfe [INFO] running `Command { std: "docker" "start" "-a" "d3cee3fa36fa3d96fbfd93f3d4e55b1bf5121ae8a920202810dc063e55592dfe", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Checking arsc-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `pointer_byte_offsets` has been stable since 1.75.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | #![feature(pointer_byte_offsets)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `pointer_byte_offsets` has been stable since 1.75.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | #![feature(pointer_byte_offsets)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn try_new_in(data: T, alloc: A) -> Result { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Arsc { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | inner, [INFO] [stdout] 67 | | _marker: PhantomData, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn try_new_uninit_in(alloc: A) -> Result, A>, AllocError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Arsc { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | inner, [INFO] [stdout] 83 | | _marker: PhantomData, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arsc-rs` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self::try_new(data).expect("Failed to create an Arsc") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | a.inner.as_ptr() == b.inner.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 153 | std::ptr::addr_eq(a.inner.as_ptr(), b.inner.as_ptr()) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 153 | std::ptr::eq(a.inner.as_ptr(), b.inner.as_ptr()) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | Self::try_make_mut_with(this, |t| Ok((T::clone(t), A::clone(alloc)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn try_new_in(data: T, alloc: A) -> Result { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Arsc { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | inner, [INFO] [stdout] 67 | | _marker: PhantomData, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn try_new_uninit_in(alloc: A) -> Result, A>, AllocError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Arsc { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | inner, [INFO] [stdout] 83 | | _marker: PhantomData, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self::try_new(data).expect("Failed to create an Arsc") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | a.inner.as_ptr() == b.inner.as_ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 153 | std::ptr::addr_eq(a.inner.as_ptr(), b.inner.as_ptr()) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 153 | std::ptr::eq(a.inner.as_ptr(), b.inner.as_ptr()) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | Self::try_make_mut_with(this, |t| Ok((T::clone(t), A::clone(alloc)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arsc-rs` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d3cee3fa36fa3d96fbfd93f3d4e55b1bf5121ae8a920202810dc063e55592dfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3cee3fa36fa3d96fbfd93f3d4e55b1bf5121ae8a920202810dc063e55592dfe", kill_on_drop: false }` [INFO] [stdout] d3cee3fa36fa3d96fbfd93f3d4e55b1bf5121ae8a920202810dc063e55592dfe