[INFO] fetching crate arroyo-udf-plugin 0.2.0... [INFO] checking arroyo-udf-plugin-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arroyo-udf-plugin 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate arroyo-udf-plugin 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arroyo-udf-plugin 0.2.0 [INFO] finished tweaking crates.io crate arroyo-udf-plugin 0.2.0 [INFO] tweaked toml for crates.io crate arroyo-udf-plugin 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 130 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrow v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-arith v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-array v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-buffer v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-cast v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-csv v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-data v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ipc v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-json v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ord v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-row v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-schema v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-select v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-string v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (latest: v24.3.25) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae97b5528bcb3dd93ad8c1222bdbdd895bea52ac628cda0a82aaf6f029e27e51 [INFO] running `Command { std: "docker" "start" "-a" "ae97b5528bcb3dd93ad8c1222bdbdd895bea52ac628cda0a82aaf6f029e27e51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae97b5528bcb3dd93ad8c1222bdbdd895bea52ac628cda0a82aaf6f029e27e51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae97b5528bcb3dd93ad8c1222bdbdd895bea52ac628cda0a82aaf6f029e27e51", kill_on_drop: false }` [INFO] [stdout] ae97b5528bcb3dd93ad8c1222bdbdd895bea52ac628cda0a82aaf6f029e27e51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 97fae49763662031ee02820f1df5f1810cc8a79dc214f6006c5ca0a493bc97a2 [INFO] running `Command { std: "docker" "start" "-a" "97fae49763662031ee02820f1df5f1810cc8a79dc214f6006c5ca0a493bc97a2", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking arrow-schema v51.0.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lexical-util v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling lexical-write-integer v0.8.5 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Compiling lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling lexical-write-float v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling lexical-parse-float v0.8.5 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling csv-core v0.1.11 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling tokio v1.40.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v51.0.0 [INFO] [stderr] Checking arrow-data v51.0.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking arrow-array v51.0.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-ffi-macros v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-ffi v0.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking arrow-select v51.0.0 [INFO] [stderr] Checking arrow-row v51.0.0 [INFO] [stderr] Checking arrow-arith v51.0.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking arrow-cast v51.0.0 [INFO] [stderr] Checking arrow-ord v51.0.0 [INFO] [stderr] Checking arrow-string v51.0.0 [INFO] [stderr] Compiling rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Compiling rand v0.9.0-alpha.2 [INFO] [stderr] Checking arrow-ipc v51.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling csv v1.3.0 [INFO] [stderr] Compiling arrow-csv v51.0.0 [INFO] [stderr] Compiling arrow-json v51.0.0 [INFO] [stderr] Compiling arrow v51.0.0 [INFO] [stderr] Compiling arroyo-udf-common v0.2.0 [INFO] [stderr] Compiling arroyo-udf-macros v0.2.0 [INFO] [stderr] Checking arroyo-udf-plugin v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn into_ffi(self) -> *mut FfiAsyncUdfHandle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Box::leak(Box::new(self)) as *mut AsyncUdfHandle as *mut FfiAsyncUdfHandle [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 126 | builder: Box, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | func: FnT, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> (Self, AsyncUdfHandle) { [INFO] [stdout] 129 | let (tx, rx) = channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | [INFO] [stdout] 131 | let results = Arc::new(Mutex::new((UInt64Builder::new(), builder))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let handle = AsyncUdfHandle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | / Self { [INFO] [stdout] 140 | | futures: if ordered { [INFO] [stdout] 141 | | FuturesEnum::Ordered(FuturesOrdered::new()) [INFO] [stdout] 142 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 149 | | allowed_in_flight: allowed_in_flight as usize, [INFO] [stdout] 150 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn start(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | std::thread::spawn(move || { [INFO] [stdout] 157 | let runtime = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | runtime.block_on(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 162 | | self.run().await; [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn into_ffi(self) -> *mut FfiAsyncUdfHandle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Box::leak(Box::new(self)) as *mut AsyncUdfHandle as *mut FfiAsyncUdfHandle [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 126 | builder: Box, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | func: FnT, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> (Self, AsyncUdfHandle) { [INFO] [stdout] 129 | let (tx, rx) = channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | [INFO] [stdout] 131 | let results = Arc::new(Mutex::new((UInt64Builder::new(), builder))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let handle = AsyncUdfHandle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | / Self { [INFO] [stdout] 140 | | futures: if ordered { [INFO] [stdout] 141 | | FuturesEnum::Ordered(FuturesOrdered::new()) [INFO] [stdout] 142 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 149 | | allowed_in_flight: allowed_in_flight as usize, [INFO] [stdout] 150 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_udf.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn start(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | std::thread::spawn(move || { [INFO] [stdout] 157 | let runtime = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | runtime.block_on(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 162 | | self.run().await; [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arroyo-udf-plugin` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arroyo-udf-plugin` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "97fae49763662031ee02820f1df5f1810cc8a79dc214f6006c5ca0a493bc97a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97fae49763662031ee02820f1df5f1810cc8a79dc214f6006c5ca0a493bc97a2", kill_on_drop: false }` [INFO] [stdout] 97fae49763662031ee02820f1df5f1810cc8a79dc214f6006c5ca0a493bc97a2