[INFO] fetching crate arroyo-udf-common 0.2.0... [INFO] checking arroyo-udf-common-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arroyo-udf-common 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate arroyo-udf-common 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arroyo-udf-common 0.2.0 [INFO] finished tweaking crates.io crate arroyo-udf-common 0.2.0 [INFO] tweaked toml for crates.io crate arroyo-udf-common 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 111 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrow v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-arith v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-array v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-buffer v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-cast v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-csv v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-data v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ipc v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-json v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ord v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-row v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-schema v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-select v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-string v51.0.0 (latest: v52.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (latest: v24.3.25) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1602c204820433a7761067b573b6e9801a7b268c66631f8a595cf933df8d5331 [INFO] running `Command { std: "docker" "start" "-a" "1602c204820433a7761067b573b6e9801a7b268c66631f8a595cf933df8d5331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1602c204820433a7761067b573b6e9801a7b268c66631f8a595cf933df8d5331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1602c204820433a7761067b573b6e9801a7b268c66631f8a595cf933df8d5331", kill_on_drop: false }` [INFO] [stdout] 1602c204820433a7761067b573b6e9801a7b268c66631f8a595cf933df8d5331 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8909a81970e38295211562a0e1e116b974064ddf7a33fa90bc3c808b7988d408 [INFO] running `Command { std: "docker" "start" "-a" "8909a81970e38295211562a0e1e116b974064ddf7a33fa90bc3c808b7988d408", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking arrow-schema v51.0.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v51.0.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-ffi-macros v0.5.0 [INFO] [stderr] Checking async-ffi v0.5.0 [INFO] [stderr] Checking arrow-data v51.0.0 [INFO] [stderr] Checking arrow-array v51.0.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking arrow-select v51.0.0 [INFO] [stderr] Checking arrow-arith v51.0.0 [INFO] [stderr] Checking arrow-row v51.0.0 [INFO] [stderr] Checking arrow-cast v51.0.0 [INFO] [stderr] Checking arrow-ord v51.0.0 [INFO] [stderr] Checking arrow-string v51.0.0 [INFO] [stderr] Checking arrow-ipc v51.0.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking arrow-csv v51.0.0 [INFO] [stderr] Checking arrow-json v51.0.0 [INFO] [stderr] Checking arrow v51.0.0 [INFO] [stderr] Checking arroyo-udf-common v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|a| to_ffi(&a).unwrap()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 56 | let vec = unsafe { Vec::from_raw_parts(self.ptr, self.len, self.capacity) }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | / vec.into_iter() [INFO] [stdout] 59 | | .map(|FfiArraySchema(array, schema)| unsafe { from_ffi(array, &schema).unwrap() }) [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:59 [INFO] [stdout] | [INFO] [stdout] 59 | .map(|FfiArraySchema(array, schema)| unsafe { from_ffi(array, &schema).unwrap() }) [INFO] [stdout] | ----------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 41 | let Some(inner) = ParsedUdf::vec_inner_type(typ) else { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | rust_to_arrow(&inner, true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|s| s.to_token_stream().to_string().replace(' ', "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:339:12 [INFO] [stdout] | [INFO] [stdout] 256 | let mut args = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | let ret = match &function.sig.output { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(ParsedUdf { [INFO] [stdout] | ____________^ [INFO] [stdout] 340 | | function: function.into_token_stream().to_string(), [INFO] [stdout] 341 | | name, [INFO] [stdout] 342 | | args, [INFO] [stdout] ... | [INFO] [stdout] 345 | | udf_type, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|a| to_ffi(&a).unwrap()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 56 | let vec = unsafe { Vec::from_raw_parts(self.ptr, self.len, self.capacity) }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | / vec.into_iter() [INFO] [stdout] 59 | | .map(|FfiArraySchema(array, schema)| unsafe { from_ffi(array, &schema).unwrap() }) [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:59 [INFO] [stdout] | [INFO] [stdout] 59 | .map(|FfiArraySchema(array, schema)| unsafe { from_ffi(array, &schema).unwrap() }) [INFO] [stdout] | ----------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arroyo-udf-common` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 41 | let Some(inner) = ParsedUdf::vec_inner_type(typ) else { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | rust_to_arrow(&inner, true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|s| s.to_token_stream().to_string().replace(' ', "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:339:12 [INFO] [stdout] | [INFO] [stdout] 256 | let mut args = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | let ret = match &function.sig.output { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(ParsedUdf { [INFO] [stdout] | ____________^ [INFO] [stdout] 340 | | function: function.into_token_stream().to_string(), [INFO] [stdout] 341 | | name, [INFO] [stdout] 342 | | args, [INFO] [stdout] ... | [INFO] [stdout] 345 | | udf_type, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arroyo-udf-common` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "8909a81970e38295211562a0e1e116b974064ddf7a33fa90bc3c808b7988d408", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8909a81970e38295211562a0e1e116b974064ddf7a33fa90bc3c808b7988d408", kill_on_drop: false }` [INFO] [stdout] 8909a81970e38295211562a0e1e116b974064ddf7a33fa90bc3c808b7988d408