[INFO] fetching crate arrow-avro 52.2.0... [INFO] checking arrow-avro-52.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arrow-avro 52.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate arrow-avro 52.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arrow-avro 52.2.0 [INFO] finished tweaking crates.io crate arrow-avro 52.2.0 [INFO] tweaked toml for crates.io crate arrow-avro 52.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f013afd8972f98c91f3d104981151d66b359f240a2dfa2019bc62cb21e767de7 [INFO] running `Command { std: "docker" "start" "-a" "f013afd8972f98c91f3d104981151d66b359f240a2dfa2019bc62cb21e767de7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f013afd8972f98c91f3d104981151d66b359f240a2dfa2019bc62cb21e767de7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f013afd8972f98c91f3d104981151d66b359f240a2dfa2019bc62cb21e767de7", kill_on_drop: false }` [INFO] [stdout] f013afd8972f98c91f3d104981151d66b359f240a2dfa2019bc62cb21e767de7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb9c15e73c066824cbcd5c2a4ce9450688dbc5381c380cee8fe286ced071edaa [INFO] running `Command { std: "docker" "start" "-a" "bb9c15e73c066824cbcd5c2a4ce9450688dbc5381c380cee8fe286ced071edaa", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking arrow-avro v52.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:71:24 [INFO] [stdout] | [INFO] [stdout] 53 | fn read_blocks(mut reader: R) -> impl Iterator> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut try_next = move || { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | std::iter::from_fn(move || try_next().transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 56 | let mut try_next = move || { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | std::iter::from_fn(move || try_next().transpose()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/header.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get(&self, key: impl AsRef<[u8]>) -> Option<&[u8]> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | self.metadata() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | .map_err(|e| ArrowError::ExternalError(Box::new(e)))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | let d = self.codec.data_type(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Field::new(name, d, self.nulls.is_some()).with_metadata(self.metadata.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:210:37 [INFO] [stdout] | [INFO] [stdout] 210 | .position(|x| x == &Schema::TypeName(TypeName::Primitive(PrimitiveType::Null))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arrow-avro` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:71:24 [INFO] [stdout] | [INFO] [stdout] 53 | fn read_blocks(mut reader: R) -> impl Iterator> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut try_next = move || { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | std::iter::from_fn(move || try_next().transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 56 | let mut try_next = move || { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | std::iter::from_fn(move || try_next().transpose()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/header.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn get(&self, key: impl AsRef<[u8]>) -> Option<&[u8]> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | self.metadata() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/header.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 281 | let file = File::open(file).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | read_header(BufReader::with_capacity(100, file)).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | .map_err(|e| ArrowError::ExternalError(Box::new(e)))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | let d = self.codec.data_type(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Field::new(name, d, self.nulls.is_some()).with_metadata(self.metadata.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:210:37 [INFO] [stdout] | [INFO] [stdout] 210 | .position(|x| x == &Schema::TypeName(TypeName::Primitive(PrimitiveType::Null))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arrow-avro` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "bb9c15e73c066824cbcd5c2a4ce9450688dbc5381c380cee8fe286ced071edaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb9c15e73c066824cbcd5c2a4ce9450688dbc5381c380cee8fe286ced071edaa", kill_on_drop: false }` [INFO] [stdout] bb9c15e73c066824cbcd5c2a4ce9450688dbc5381c380cee8fe286ced071edaa