[INFO] fetching crate array_pool 0.1.2... [INFO] checking array_pool-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate array_pool 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate array_pool 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate array_pool 0.1.2 [INFO] finished tweaking crates.io crate array_pool 0.1.2 [INFO] tweaked toml for crates.io crate array_pool 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7c3ebc9d84006f3282d5e16536b2fb7067ea2bad995e3670bbfba5df70cd8f9 [INFO] running `Command { std: "docker" "start" "-a" "b7c3ebc9d84006f3282d5e16536b2fb7067ea2bad995e3670bbfba5df70cd8f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7c3ebc9d84006f3282d5e16536b2fb7067ea2bad995e3670bbfba5df70cd8f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7c3ebc9d84006f3282d5e16536b2fb7067ea2bad995e3670bbfba5df70cd8f9", kill_on_drop: false }` [INFO] [stdout] b7c3ebc9d84006f3282d5e16536b2fb7067ea2bad995e3670bbfba5df70cd8f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9feb3ce63a951c3d9b8ad39e43ea5db1cacd315a18891feba00513116ae6582 [INFO] running `Command { std: "docker" "start" "-a" "f9feb3ce63a951c3d9b8ad39e43ea5db1cacd315a18891feba00513116ae6582", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking array_pool v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:69:33 [INFO] [stdout] | [INFO] [stdout] 68 | let arc_count = self.chunk_count.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.local_chain.get_or(move ||{ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 70 | | let arc = Arc::new(LocalBufferChain { [INFO] [stdout] 71 | | chunk_linked_list: Mutex::new(vec![]), [INFO] [stdout] 72 | | chunk_count: arc_count, [INFO] [stdout] ... | [INFO] [stdout] 78 | | arc [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:207:20 [INFO] [stdout] | [INFO] [stdout] 193 | let new_buffer = match self.chain.get_local().borrow(){ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Some(mut v) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | chain: self.chain.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 220 | let mut map: BTreeMap>> = BTreeMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | empty_chain: BufferChain::new(0), [INFO] [stdout] 227 | | chunk_map: map [INFO] [stdout] 228 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn create(pool: Arc>, fabricator: F) -> Self { [INFO] [stdout] | ----------------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | buffer: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `array_pool` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/lib.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let a = 1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Fetch` is never constructed [INFO] [stdout] --> src/raw_buffer.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 6 | #[cfg(test)] #[derive(Copy, Clone)] pub(crate) enum TestFlag { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 9 | Fetch [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestFlag` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:69:33 [INFO] [stdout] | [INFO] [stdout] 68 | let arc_count = self.chunk_count.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.local_chain.get_or(move ||{ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 70 | | let arc = Arc::new(LocalBufferChain { [INFO] [stdout] 71 | | chunk_linked_list: Mutex::new(vec![]), [INFO] [stdout] 72 | | chunk_count: arc_count, [INFO] [stdout] ... | [INFO] [stdout] 78 | | arc [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:207:20 [INFO] [stdout] | [INFO] [stdout] 193 | let new_buffer = match self.chain.get_local().borrow(){ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Some(mut v) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | chain: self.chain.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 220 | let mut map: BTreeMap>> = BTreeMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | empty_chain: BufferChain::new(0), [INFO] [stdout] 227 | | chunk_map: map [INFO] [stdout] 228 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn create(pool: Arc>, fabricator: F) -> Self { [INFO] [stdout] | ----------------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | buffer: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `array_pool` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f9feb3ce63a951c3d9b8ad39e43ea5db1cacd315a18891feba00513116ae6582", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9feb3ce63a951c3d9b8ad39e43ea5db1cacd315a18891feba00513116ae6582", kill_on_drop: false }` [INFO] [stdout] f9feb3ce63a951c3d9b8ad39e43ea5db1cacd315a18891feba00513116ae6582