[INFO] fetching crate arpy-client 0.2.0... [INFO] checking arpy-client-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arpy-client 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate arpy-client 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arpy-client 0.2.0 [INFO] finished tweaking crates.io crate arpy-client 0.2.0 [INFO] tweaked toml for crates.io crate arpy-client 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5518963eea07dbd8c5c9299b8f94b27421f652105a05c0c744d2634a979a3b98 [INFO] running `Command { std: "docker" "start" "-a" "5518963eea07dbd8c5c9299b8f94b27421f652105a05c0c744d2634a979a3b98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5518963eea07dbd8c5c9299b8f94b27421f652105a05c0c744d2634a979a3b98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5518963eea07dbd8c5c9299b8f94b27421f652105a05c0c744d2634a979a3b98", kill_on_drop: false }` [INFO] [stdout] 5518963eea07dbd8c5c9299b8f94b27421f652105a05c0c744d2634a979a3b98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca97a365c7d3d5c46aadc3687062f7ae7480aab886d20ed8b50a70b51eeaadfe [INFO] running `Command { std: "docker" "start" "-a" "ca97a365c7d3d5c46aadc3687062f7ae7480aab886d20ed8b50a70b51eeaadfe", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling arpy-macros v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking arpy v0.2.0 [INFO] [stderr] Checking arpy-client v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:65:81 [INFO] [stdout] | [INFO] [stdout] 50 | ws_sink: impl Sink, Error = Error> + 'static, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ws_stream: impl Stream, Error>> + 'static, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let to_send = ReceiverStream::new(to_send); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let bg_ws = BackgroundWebsocket { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | spawner.spawn_local(async move { bg_ws.run(ws_sink, ws_stream, to_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 120 | async fn begin_call(&self, function: F) -> Result, Self::Error> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / { [INFO] [stdout] 124 | | let (notify, recv) = oneshot::channel(); [INFO] [stdout] 125 | | let client_id = self.msg_ids.borrow_mut().insert(notify); [INFO] [stdout] ... | [INFO] [stdout] 137 | | }) [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 142 | service: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | updates: impl Stream + 'static, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | / { [INFO] [stdout] 148 | | // TODO: Benchmark and adjust size. [INFO] [stdout] 149 | | // We use a small channel buffer as this is just to get messages to the [INFO] [stdout] 150 | | // websocket handler task. [INFO] [stdout] ... | [INFO] [stdout] 193 | | )) [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 219 | async fn call(&self, args: Args) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | / { [INFO] [stdout] 223 | | self.begin_call(args).await?.await [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 342 | fn serialize(writer: W, t: &T) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | / bincode::DefaultOptions::new() [INFO] [stdout] 348 | | .serialize_into(writer, t) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:357:5 [INFO] [stdout] | [INFO] [stdout] 352 | fn deserialize(reader: R) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | / bincode::DefaultOptions::new() [INFO] [stdout] 358 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 362 | fn deserialize_part(reader: R) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | / bincode::DefaultOptions::new() [INFO] [stdout] 368 | | .allow_trailing_bytes() [INFO] [stdout] 369 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arpy-client` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:65:81 [INFO] [stdout] | [INFO] [stdout] 50 | ws_sink: impl Sink, Error = Error> + 'static, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ws_stream: impl Stream, Error>> + 'static, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let to_send = ReceiverStream::new(to_send); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let bg_ws = BackgroundWebsocket { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | spawner.spawn_local(async move { bg_ws.run(ws_sink, ws_stream, to_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 120 | async fn begin_call(&self, function: F) -> Result, Self::Error> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / { [INFO] [stdout] 124 | | let (notify, recv) = oneshot::channel(); [INFO] [stdout] 125 | | let client_id = self.msg_ids.borrow_mut().insert(notify); [INFO] [stdout] ... | [INFO] [stdout] 137 | | }) [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 142 | service: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | updates: impl Stream + 'static, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | / { [INFO] [stdout] 148 | | // TODO: Benchmark and adjust size. [INFO] [stdout] 149 | | // We use a small channel buffer as this is just to get messages to the [INFO] [stdout] 150 | | // websocket handler task. [INFO] [stdout] ... | [INFO] [stdout] 193 | | )) [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 219 | async fn call(&self, args: Args) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | / { [INFO] [stdout] 223 | | self.begin_call(args).await?.await [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 342 | fn serialize(writer: W, t: &T) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | / bincode::DefaultOptions::new() [INFO] [stdout] 348 | | .serialize_into(writer, t) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:357:5 [INFO] [stdout] | [INFO] [stdout] 352 | fn deserialize(reader: R) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | / bincode::DefaultOptions::new() [INFO] [stdout] 358 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 362 | fn deserialize_part(reader: R) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | / bincode::DefaultOptions::new() [INFO] [stdout] 368 | | .allow_trailing_bytes() [INFO] [stdout] 369 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arpy-client` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "ca97a365c7d3d5c46aadc3687062f7ae7480aab886d20ed8b50a70b51eeaadfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca97a365c7d3d5c46aadc3687062f7ae7480aab886d20ed8b50a70b51eeaadfe", kill_on_drop: false }` [INFO] [stdout] ca97a365c7d3d5c46aadc3687062f7ae7480aab886d20ed8b50a70b51eeaadfe