[INFO] fetching crate arpx 0.5.0... [INFO] checking arpx-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arpx 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate arpx 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arpx 0.5.0 [INFO] finished tweaking crates.io crate arpx 0.5.0 [INFO] tweaked toml for crates.io crate arpx 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate arpx 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae34ed9f6fa9128daf6f290db534f6f3ab4a7f0b54f103337bc7c525fcc68bd0 [INFO] running `Command { std: "docker" "start" "-a" "ae34ed9f6fa9128daf6f290db534f6f3ab4a7f0b54f103337bc7c525fcc68bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae34ed9f6fa9128daf6f290db534f6f3ab4a7f0b54f103337bc7c525fcc68bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae34ed9f6fa9128daf6f290db534f6f3ab4a7f0b54f103337bc7c525fcc68bd0", kill_on_drop: false }` [INFO] [stdout] ae34ed9f6fa9128daf6f290db534f6f3ab4a7f0b54f103337bc7c525fcc68bd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f17f237d1f538f50e9500c42f41156e8c6c59dc037f7370726eef7bb1c6290fb [INFO] running `Command { std: "docker" "start" "-a" "f17f237d1f538f50e9500c42f41156e8c6c59dc037f7370726eef7bb1c6290fb", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling semver v1.0.6 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking ordered-float v2.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking arc-swap v0.4.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking arpx_job_parser v0.1.12 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking log4rs v1.0.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking arpx v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/runtime/job/task/process/stream.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | IO(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PipeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 | IO(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/runtime/job/task/process/stream.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | NotUtf8(FromUtf8Error), [INFO] [stdout] | ------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PipeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | NotUtf8(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logs.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 40 | let handle = log4rs::init_config(Self::get_config(level, verbose)?) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Self { handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logs.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 59 | let stdout = ConsoleAppender::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / Config::builder() [INFO] [stdout] 64 | | .appender(Appender::builder().build("stdout", Box::new(stdout))) [INFO] [stdout] 65 | | .build(Root::builder().appender("stdout").build(level)) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/job/task/log_monitor/mod.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 67 | ontrigger: OptionalAction, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let (sender, receiver) = unbounded::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let handle = thread::Builder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok((handle, sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/job/task/process/stream.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn init(mut stream: Box) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | lines: { [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | let (tx, rx) = unbounded(); [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | spawn(move || { [INFO] [stdout] ... | [INFO] [stdout] 65 | | rx [INFO] [stdout] 66 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/profile/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | RuntimeBuilder::from_profile_and_job_names(profile, job_names) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/profile/deserialize/jobs.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn deserialize<'de, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | Ok(deserialized [INFO] [stdout] | ________^ [INFO] [stdout] 14 | | .into_iter() [INFO] [stdout] 15 | | .map(|(k, Wrapper(v))| (k, v)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/profile/deserialize/log_monitors.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn deserialize<'de, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(deserialized [INFO] [stdout] | ________^ [INFO] [stdout] 26 | | .into_iter() [INFO] [stdout] 27 | | .map(|(k, Wrapper(mut v))| { [INFO] [stdout] 28 | | v.name = k.clone(); [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | (k, v) [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/profile/deserialize/processes.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn deserialize<'de, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(deserialized [INFO] [stdout] | ________^ [INFO] [stdout] 30 | | .into_iter() [INFO] [stdout] 31 | | .map(|(k, Wrapper(mut v))| { [INFO] [stdout] 32 | | v.name = k.clone(); [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | (k, v) [INFO] [stdout] 35 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arpx` (lib) due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f17f237d1f538f50e9500c42f41156e8c6c59dc037f7370726eef7bb1c6290fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f17f237d1f538f50e9500c42f41156e8c6c59dc037f7370726eef7bb1c6290fb", kill_on_drop: false }` [INFO] [stdout] f17f237d1f538f50e9500c42f41156e8c6c59dc037f7370726eef7bb1c6290fb