[INFO] fetching crate ark-relations 0.5.0-alpha.0... [INFO] checking ark-relations-0.5.0-alpha.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ark-relations 0.5.0-alpha.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ark-relations 0.5.0-alpha.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ark-relations 0.5.0-alpha.0 [INFO] finished tweaking crates.io crate ark-relations 0.5.0-alpha.0 [INFO] tweaked toml for crates.io crate ark-relations 0.5.0-alpha.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f5f7f3abd8541a20ad85ba967fed752d32c0088e44450f8a23e43f3a872a275 [INFO] running `Command { std: "docker" "start" "-a" "9f5f7f3abd8541a20ad85ba967fed752d32c0088e44450f8a23e43f3a872a275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f5f7f3abd8541a20ad85ba967fed752d32c0088e44450f8a23e43f3a872a275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f5f7f3abd8541a20ad85ba967fed752d32c0088e44450f8a23e43f3a872a275", kill_on_drop: false }` [INFO] [stdout] 9f5f7f3abd8541a20ad85ba967fed752d32c0088e44450f8a23e43f3a872a275 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73d8883bb224a90bb4a62c5bddcde9e7c0d7f89ccbbd96ddfcca896bc7877c3b [INFO] running `Command { std: "docker" "start" "-a" "73d8883bb224a90bb4a62c5bddcde9e7c0d7f89ccbbd96ddfcca896bc7877c3b", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling ark-serialize-derive v0.5.0-alpha.0 [INFO] [stderr] Compiling ark-ff-asm v0.5.0-alpha.0 [INFO] [stderr] Compiling ark-ff-macros v0.5.0-alpha.0 [INFO] [stderr] Compiling enum-ordinalize v4.3.0 [INFO] [stderr] Compiling educe v0.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ark-std v0.5.0-alpha.0 [INFO] [stderr] Checking ark-serialize v0.5.0-alpha.0 [INFO] [stderr] Checking ark-ff v0.5.0-alpha.0 [INFO] [stderr] Checking ark-poly v0.5.0-alpha.0 [INFO] [stderr] Checking ark-relations v0.5.0-alpha.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:760:18 [INFO] [stdout] | [INFO] [stdout] 759 | pub fn new(inner: ConstraintSystem) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | Self::CS(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:800:38 [INFO] [stdout] | [INFO] [stdout] 800 | self.inner().map_or((), |cs| cs.borrow_mut().set_mode(mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:807:33 [INFO] [stdout] | [INFO] [stdout] 807 | .map_or(false, |cs| cs.borrow().is_in_setup_mode()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:813:37 [INFO] [stdout] | [INFO] [stdout] 813 | self.inner().map_or(0, |cs| cs.borrow().num_constraints) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:820:29 [INFO] [stdout] | [INFO] [stdout] 820 | .map_or(0, |cs| cs.borrow().num_instance_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:827:29 [INFO] [stdout] | [INFO] [stdout] 827 | .map_or(0, |cs| cs.borrow().num_witness_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:844:30 [INFO] [stdout] | [INFO] [stdout] 844 | .map_or((), |cs| cs.borrow_mut().set_optimization_goal(goal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:851:33 [INFO] [stdout] | [INFO] [stdout] 851 | .map_or(false, |cs| cs.borrow().should_construct_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:862:23 [INFO] [stdout] | [INFO] [stdout] 856 | pub fn new_input_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 863 | | if !self.is_in_setup_mode() { [INFO] [stdout] 864 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 865 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 870 | | } [INFO] [stdout] 871 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:882:23 [INFO] [stdout] | [INFO] [stdout] 876 | pub fn new_witness_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 882 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 883 | | if !self.is_in_setup_mode() { [INFO] [stdout] 884 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 885 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 890 | | } [INFO] [stdout] 891 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:899:28 [INFO] [stdout] | [INFO] [stdout] 899 | .and_then(|cs| cs.borrow_mut().new_lc(lc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:912:28 [INFO] [stdout] | [INFO] [stdout] 912 | .and_then(|cs| cs.borrow_mut().enforce_constraint(a, b, c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:942:36 [INFO] [stdout] | [INFO] [stdout] 942 | self.inner().and_then(|cs| cs.borrow().to_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:968:36 [INFO] [stdout] | [INFO] [stdout] 968 | self.inner().and_then(|cs| cs.borrow().assigned_value(v)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ark-relations` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "73d8883bb224a90bb4a62c5bddcde9e7c0d7f89ccbbd96ddfcca896bc7877c3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73d8883bb224a90bb4a62c5bddcde9e7c0d7f89ccbbd96ddfcca896bc7877c3b", kill_on_drop: false }` [INFO] [stdout] 73d8883bb224a90bb4a62c5bddcde9e7c0d7f89ccbbd96ddfcca896bc7877c3b